From: "Mikle Kolyada" <zlogene@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-admin/logrotate/, app-admin/logrotate/files/
Date: Sat, 25 Jan 2020 17:48:22 +0000 (UTC) [thread overview]
Message-ID: <1579974455.47d22ae9aaaba1133f8f503cdb24a8a9f59494b6.zlogene@gentoo> (raw)
commit: 47d22ae9aaaba1133f8f503cdb24a8a9f59494b6
Author: Mikle Kolyada <zlogene <AT> gentoo <DOT> org>
AuthorDate: Sat Jan 25 17:47:35 2020 +0000
Commit: Mikle Kolyada <zlogene <AT> gentoo <DOT> org>
CommitDate: Sat Jan 25 17:47:35 2020 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=47d22ae9
app-admin/logrotate: fix build with -fno-common
Closes: https://bugs.gentoo.org/705882
Package-Manager: Portage-2.3.84, Repoman-2.3.20
Signed-off-by: Mikle Kolyada <zlogene <AT> gentoo.org>
app-admin/logrotate/files/gcc-fnocommon.patch | 41 +++++++++++++++++++++++++++
app-admin/logrotate/logrotate-3.14.0.ebuild | 2 +-
app-admin/logrotate/logrotate-3.15.1.ebuild | 3 +-
3 files changed, 44 insertions(+), 2 deletions(-)
diff --git a/app-admin/logrotate/files/gcc-fnocommon.patch b/app-admin/logrotate/files/gcc-fnocommon.patch
new file mode 100644
index 00000000000..d490c20ce0a
--- /dev/null
+++ b/app-admin/logrotate/files/gcc-fnocommon.patch
@@ -0,0 +1,41 @@
+From 908e86191bf062711ea44c922e66d27203e90214 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com>
+Date: Wed, 8 Jan 2020 10:54:53 +0100
+Subject: [PATCH] split declaration and definition of queue variable
+
+Support compilation with -fno-common flag, which is the default for GCC 10.
+
+Fixes: #288
+Closes #289
+---
+ config.c | 2 ++
+ logrotate.h | 3 ++-
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/config.c b/config.c
+index 0e9a828..f027c7e 100644
+--- a/config.c
++++ b/config.c
+@@ -28,6 +28,8 @@
+ #include "log.h"
+ #include "logrotate.h"
+
++struct logInfoHead logs;
++
+ #if !defined(GLOB_ABORTED) && defined(GLOB_ABEND)
+ #define GLOB_ABORTED GLOB_ABEND
+ #endif
+diff --git a/logrotate.h b/logrotate.h
+index 1c178da..6c1c2e7 100644
+--- a/logrotate.h
++++ b/logrotate.h
+@@ -89,7 +89,8 @@ struct logInfo {
+ TAILQ_ENTRY(logInfo) list;
+ };
+
+-TAILQ_HEAD(logInfoHead, logInfo) logs;
++TAILQ_HEAD(logInfoHead, logInfo);
++extern struct logInfoHead logs;
+
+ extern int numLogs;
+ extern int debug;
diff --git a/app-admin/logrotate/logrotate-3.14.0.ebuild b/app-admin/logrotate/logrotate-3.14.0.ebuild
index 4cb39bde390..729f5629d43 100644
--- a/app-admin/logrotate/logrotate-3.14.0.ebuild
+++ b/app-admin/logrotate/logrotate-3.14.0.ebuild
@@ -34,7 +34,7 @@ move_old_state_file() {
elog "See bug #357275"
if [[ -e "${OLDSTATEFILE}" ]] ; then
elog "Moving your current state file to new location: ${STATEFILE}"
- mv -n "${OLDSTATEFILE}" "${STATEFILE}"
+ mv -n "${OLDSTATEFILE}" "${STATEFILE}" || die
fi
}
diff --git a/app-admin/logrotate/logrotate-3.15.1.ebuild b/app-admin/logrotate/logrotate-3.15.1.ebuild
index 58b95631d2d..eef82c310b8 100644
--- a/app-admin/logrotate/logrotate-3.15.1.ebuild
+++ b/app-admin/logrotate/logrotate-3.15.1.ebuild
@@ -34,7 +34,7 @@ move_old_state_file() {
elog "See bug #357275"
if [[ -e "${OLDSTATEFILE}" ]] ; then
elog "Moving your current state file to new location: ${STATEFILE}"
- mv -n "${OLDSTATEFILE}" "${STATEFILE}"
+ mv -n "${OLDSTATEFILE}" "${STATEFILE}" || die
fi
}
@@ -45,6 +45,7 @@ install_cron_file() {
PATCHES=(
"${FILESDIR}/${PN}-3.15.0-ignore-hidden.patch"
+ "${FILESDIR}/gcc-fnocommon.patch"
)
src_prepare() {
next reply other threads:[~2020-01-25 17:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-25 17:48 Mikle Kolyada [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-01 23:02 [gentoo-commits] repo/gentoo:master commit in: app-admin/logrotate/, app-admin/logrotate/files/ David Seifert
2019-08-31 14:11 Mikle Kolyada
2018-12-19 15:40 José María Alonso
2018-02-01 20:42 José María Alonso
2017-10-14 17:03 José María Alonso
2016-01-25 19:58 José María Alonso
2015-10-06 8:55 José María Alonso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579974455.47d22ae9aaaba1133f8f503cdb24a8a9f59494b6.zlogene@gentoo \
--to=zlogene@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox