From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B0C79138350 for ; Wed, 22 Jan 2020 20:11:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C2D89E086E; Wed, 22 Jan 2020 20:11:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A4FD7E07A7 for ; Wed, 22 Jan 2020 20:11:31 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 56A6134E369 for ; Wed, 22 Jan 2020 20:11:30 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id D2928D5 for ; Wed, 22 Jan 2020 20:11:28 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579723747.bdda53e4e914c44b1c278c6df1e726ba5170cff0.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qmanifest.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: bdda53e4e914c44b1c278c6df1e726ba5170cff0 X-VCS-Branch: master Date: Wed, 22 Jan 2020 20:11:28 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: fcf27424-42c5-4d96-9577-abd011b1cffb X-Archives-Hash: b4bf8e8d239dc8a176179d0a04d7dab8 commit: bdda53e4e914c44b1c278c6df1e726ba5170cff0 Author: Fabian Groffen gentoo org> AuthorDate: Wed Jan 22 20:09:07 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Wed Jan 22 20:09:07 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=bdda53e4 qmanifest: fix Coverity 206535 Unchecked return value Signed-off-by: Fabian Groffen gentoo.org> qmanifest.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qmanifest.c b/qmanifest.c index 31c4696..b4057bb 100644 --- a/qmanifest.c +++ b/qmanifest.c @@ -690,7 +690,11 @@ generate_dir(const char *dir, enum type_manifest mtype) fclose(m); snprintf(path, sizeof(path), "%s/%s", dir, str_manifest); - rename(newmanifest, path); + if (rename(newmanifest, path) == -1) { + fprintf(stderr, "failed to rename file '%s' to '%s': %s\n", + newmanifest, path, strerror(errno)); + return NULL; + } if (tv[0].tv_sec != 0) { /* set Manifest and dir mtime to most recent file we found */