From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9A67B138350 for ; Sun, 19 Jan 2020 19:36:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E3DF2E09E8; Sun, 19 Jan 2020 19:36:14 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CF442E09E8 for ; Sun, 19 Jan 2020 19:36:14 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0301234E255 for ; Sun, 19 Jan 2020 19:36:14 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id B6B9E10F for ; Sun, 19 Jan 2020 19:36:12 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579461393.a3704712617d3a6d4810e5dba596f36a11a95196.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qmanifest.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: a3704712617d3a6d4810e5dba596f36a11a95196 X-VCS-Branch: master Date: Sun, 19 Jan 2020 19:36:12 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: b0b3817e-4524-42b7-9793-30f4ddad644b X-Archives-Hash: 85d012f02e403ea0393576385257e519 commit: a3704712617d3a6d4810e5dba596f36a11a95196 Author: Fabian Groffen gentoo org> AuthorDate: Sun Jan 19 19:16:33 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Sun Jan 19 19:16:33 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=a3704712 qmanifest: fix Coverity 206540 Resource leak Signed-off-by: Fabian Groffen gentoo.org> qmanifest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qmanifest.c b/qmanifest.c index bd04b96..f1bc82d 100644 --- a/qmanifest.c +++ b/qmanifest.c @@ -541,8 +541,10 @@ generate_dir(const char *dir, enum type_manifest mtype) } } - if (list_dir(&dentries, &dentrieslen, dir) != 0) + if (list_dir(&dentries, &dentrieslen, dir) != 0) { + gzclose(mf); return NULL; + } for (i = 0; i < dentrieslen; i++) { /* ignore existing Manifests */