From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 93E93138350 for ; Sun, 19 Jan 2020 16:37:28 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 41BACE08FA; Sun, 19 Jan 2020 16:37:27 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 27897E08FA for ; Sun, 19 Jan 2020 16:37:27 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 5CA5D34DC3D for ; Sun, 19 Jan 2020 16:37:25 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 166BAB0 for ; Sun, 19 Jan 2020 16:37:24 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579449634.1ebb60136546f233982386df561f4a83cb4d434c.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qmanifest.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 1ebb60136546f233982386df561f4a83cb4d434c X-VCS-Branch: master Date: Sun, 19 Jan 2020 16:37:24 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 92ccdbf4-8439-4ddd-ba35-cee6e3a0d663 X-Archives-Hash: 5eba62e1b2cb904d78b116866dda9fbd commit: 1ebb60136546f233982386df561f4a83cb4d434c Author: Fabian Groffen gentoo org> AuthorDate: Sun Jan 19 16:00:34 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Sun Jan 19 16:00:34 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=1ebb6013 qmanifest: fix Coverity 206565 Unchecked return value Signed-off-by: Fabian Groffen gentoo.org> qmanifest.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/qmanifest.c b/qmanifest.c index 597357b..d9452a4 100644 --- a/qmanifest.c +++ b/qmanifest.c @@ -220,8 +220,8 @@ write_hashes( if (m != NULL) fwrite(data, len, 1, m); - if (gm != NULL) - gzwrite(gm, data, len); + if (gm != NULL && gzwrite(gm, data, len) == 0) + fprintf(stderr, "failed to write to compressed stream\n"); } /** @@ -430,7 +430,11 @@ generate_dir(const char *dir, enum type_manifest mtype) "IGNORE lost+found\n" "IGNORE packages\n" "IGNORE snapshots\n"); - gzwrite(mf, path, len); + if (gzwrite(mf, path, len) == 0) { + fprintf(stderr, "failed to write to file '%s/%s': %s\n", + dir, str_manifest_files_gz, strerror(errno)); + return NULL; + } if (list_dir(&dentries, &dentrieslen, dir) != 0) return NULL;