From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 850D0138350 for ; Sun, 19 Jan 2020 12:37:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E70BEE0919; Sun, 19 Jan 2020 12:37:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C971DE0919 for ; Sun, 19 Jan 2020 12:37:19 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 5B18034E28B for ; Sun, 19 Jan 2020 12:37:18 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id E8E56D5 for ; Sun, 19 Jan 2020 12:37:15 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579434125.06458fcdfeb3d0b267b18dba043028d6accf3b0d.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: / X-VCS-Repository: proj/portage-utils X-VCS-Files: qcheck.c X-VCS-Directories: / X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 06458fcdfeb3d0b267b18dba043028d6accf3b0d X-VCS-Branch: master Date: Sun, 19 Jan 2020 12:37:15 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: c7cdee48-d66f-40ac-ac98-375cf730a121 X-Archives-Hash: d2df5296c9b2207889f677fa166bb181 commit: 06458fcdfeb3d0b267b18dba043028d6accf3b0d Author: Fabian Groffen gentoo org> AuthorDate: Sun Jan 19 11:42:05 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Sun Jan 19 11:42:05 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=06458fcd qcheck: address Coverity 206997 Insecure temporary file Signed-off-by: Fabian Groffen gentoo.org> qcheck.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qcheck.c b/qcheck.c index 1d8521a..72a68a9 100644 --- a/qcheck.c +++ b/qcheck.c @@ -105,7 +105,12 @@ qcheck_cb(tree_pkg_ctx *pkg_ctx, void *priv) /* Open contents_update, if needed */ if (state->qc_update) { char tempfile[] = "qcheck-tmp-XXXXXX"; - int fd = mkstemp(tempfile); + mode_t mask; + int fd; + + mask = umask(0077); + fd = mkstemp(tempfile); + umask(mask); if (fd == -1 || (fp_contents_update = fdopen(fd, "w+")) == NULL) { if (fd >= 0) close(fd);