From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 950A0138350 for ; Fri, 17 Jan 2020 08:22:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id BC539E0839; Fri, 17 Jan 2020 08:22:12 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9D9B5E0839 for ; Fri, 17 Jan 2020 08:22:12 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 2A90934E17A for ; Fri, 17 Jan 2020 08:22:11 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 2A3593E for ; Fri, 17 Jan 2020 08:22:09 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1579249267.0c691939a77d0056ced7f06d5142c1952f917fee.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: libq/ X-VCS-Repository: proj/portage-utils X-VCS-Files: libq/tree.c X-VCS-Directories: libq/ X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 0c691939a77d0056ced7f06d5142c1952f917fee X-VCS-Branch: master Date: Fri, 17 Jan 2020 08:22:09 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 7a7e3980-ddc0-46eb-b2d9-7dbddc853115 X-Archives-Hash: f1abc8afb808051f67f07628474d41aa commit: 0c691939a77d0056ced7f06d5142c1952f917fee Author: Fabian Groffen gentoo org> AuthorDate: Fri Jan 17 08:21:07 2020 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Fri Jan 17 08:21:07 2020 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=0c691939 libq/tree: avoid double free in sorted case for tree_next_pkg_int Thanks Georgy Yakovlev for the report with stacktrace. Bug: https://bugs.gentoo.org/705636 Signed-off-by: Fabian Groffen gentoo.org> libq/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libq/tree.c b/libq/tree.c index 0b01f14..0df2e0d 100644 --- a/libq/tree.c +++ b/libq/tree.c @@ -403,7 +403,7 @@ tree_next_pkg_int(tree_cat_ctx *cat_ctx) pkg_ctx = cat_ctx->pkg_ctxs[cat_ctx->pkg_cnt++] = tree_open_pkg(cat_ctx, name); if (pkg_ctx == NULL) { - free(name); + /* name was freed by tree_close_pkg on fail */ cat_ctx->pkg_cnt--; } }