public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: bin/
Date: Sat, 21 Dec 2019 05:19:58 +0000 (UTC)	[thread overview]
Message-ID: <1576905496.1bfa9bda3f10627a9798edfc65472d59bc9ffeba.ulm@gentoo> (raw)

commit:     1bfa9bda3f10627a9798edfc65472d59bc9ffeba
Author:     Göktürk Yüksek <gokturk <AT> gentoo <DOT> org>
AuthorDate: Sat Dec 21 04:36:03 2019 +0000
Commit:     Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Sat Dec 21 05:18:16 2019 +0000
URL:        https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=1bfa9bda

bin/build_search_documents.py: fix aggressive whitespace stripping

In stringify_node(), we aggressively strip the whitespaces around
children nodes. This results in something like
"<c>SLOT</c>, <c>:SLOT<c/>" being parsed as "SLOT,:SLOT",
removing the white space between ',' and ':'.

Signed-off-by: Göktürk Yüksek <gokturk <AT> gentoo.org>
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>

 bin/build_search_documents.py | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/bin/build_search_documents.py b/bin/build_search_documents.py
index 3816fdb..e19dce6 100755
--- a/bin/build_search_documents.py
+++ b/bin/build_search_documents.py
@@ -18,22 +18,32 @@ def stringify_node(parent: ET.Element) -> str:
     parent -- the node to convert to a string
 
     """
+    # We usually have something like:
+    #   <p>\nText
+    # Left strip the whitespace.
     if parent.text:
         text = parent.text.lstrip()
     else:
         text = str()
 
+    # For each child, strip the tags and append to text
+    # along with the tail text following it.
+    # The tail may include '\n' if it spans multiple lines.
+    # We will worry about those on return, not now.
     for child in parent.getchildren():
         # The '<d/>' tag is simply a fancier '-' character
         if child.tag == 'd':
             text += '-'
         if child.text:
-            text += child.text.lstrip()
+            text += child.text
         if child.tail:
-            text += child.tail.rstrip()
+            text += child.tail
 
-    text += parent.tail.rstrip()
-    return text.replace('\n', ' ')
+    # A paragraph typically ends with:
+    #   Text\n</p>
+    # Right strip any spurious whitespace.
+    # Finally, get rid of any intermediate newlines.
+    return text.rstrip().replace('\n', ' ')
 
 
 def process_node(documents: list, node: ET.Element, name: str, url: str) -> None:


             reply	other threads:[~2019-12-21  5:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-21  5:19 Ulrich Müller [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-10-29 11:41 [gentoo-commits] proj/devmanual:master commit in: bin/ Ulrich Müller
2024-10-29 11:41 Ulrich Müller
2024-10-29 11:19 Ulrich Müller
2024-10-29 11:41 ` Ulrich Müller
2024-10-29 11:19 Ulrich Müller
2022-04-26  7:41 Ulrich Müller
2021-02-25 19:30 Ulrich Müller
2020-10-26 15:42 Ulrich Müller
2020-02-28  6:58 Ulrich Müller
2020-02-28  6:20 Ulrich Müller
2020-02-13 12:28 Ulrich Müller
2020-02-03  0:05 Ulrich Müller
2020-01-29 18:00 Ulrich Müller
2020-01-27 20:55 Ulrich Müller
2020-01-18 10:15 Ulrich Müller
2020-01-16 18:53 Ulrich Müller
2020-01-12  9:23 Ulrich Müller
2020-01-09 21:25 Ulrich Müller
2020-01-02 23:59 Göktürk Yüksek
2019-12-26 22:44 Göktürk Yüksek
2019-12-26  1:56 Göktürk Yüksek
2019-12-26  1:56 Göktürk Yüksek
2019-12-26  1:56 Göktürk Yüksek
2019-12-25  4:36 Göktürk Yüksek
2019-12-15 18:05 Ulrich Müller
2019-12-15 17:25 Ulrich Müller
2019-12-15 17:25 Ulrich Müller
2019-12-14 13:19 Ulrich Müller
2019-12-14 12:01 Ulrich Müller
2019-12-09 21:39 Ulrich Müller
2019-11-07 15:06 Brian Evans
2019-11-07 14:09 Brian Evans
2019-08-25  8:43 Ulrich Müller
2019-03-22 19:46 Brian Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1576905496.1bfa9bda3f10627a9798edfc65472d59bc9ffeba.ulm@gentoo \
    --to=ulm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox