public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sergei Trofimovich" <slyfox@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-util/rr/
Date: Tue, 12 Nov 2019 22:45:15 +0000 (UTC)	[thread overview]
Message-ID: <1573598709.899e40469ea6be6d4b4202a6771ecdffd9264e5c.slyfox@gentoo> (raw)

commit:     899e40469ea6be6d4b4202a6771ecdffd9264e5c
Author:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
AuthorDate: Tue Nov 12 22:43:56 2019 +0000
Commit:     Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
CommitDate: Tue Nov 12 22:45:09 2019 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=899e4046

dev-util/rr: run tests only under FEATURE=-usersandbox

rr extensively uses ptrace() to set memory up for replays.
sandbox is also using ptrace() extensively.

As a result 'rr' can't use ptrace() at all:
```
[FATAL rr-5.2.0-r1/work/rr-5.2.0/src/Task.cc:2239:write_bytes_helper()
    errno: EIO]
 (task 967940 (rec:967602) at time 18)
 -> Assertion `nwritten == buf_size' failed to hold. Should have
   written 144 bytes to 0x7fff573a98a0, but only wrote -1
```

Similar to strace test suite allow running tests only under
FEATURES=-usersandbox.

This makes most tests to start passing for me.

Reported-by: Toralf Förster
Bug: https://bugs.gentoo.org/632394
Package-Manager: Portage-2.3.79, Repoman-2.3.18
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>

 dev-util/rr/rr-5.2.0-r1.ebuild | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/dev-util/rr/rr-5.2.0-r1.ebuild b/dev-util/rr/rr-5.2.0-r1.ebuild
index b621d7b2009..b673656cf02 100644
--- a/dev-util/rr/rr-5.2.0-r1.ebuild
+++ b/dev-util/rr/rr-5.2.0-r1.ebuild
@@ -53,6 +53,15 @@ src_prepare() {
 	sed -i 's:-Werror::' CMakeLists.txt || die #609192
 }
 
+src_test() {
+	if has usersandbox ${FEATURES} ; then
+		ewarn "Test suite fails under FEATURES=usersandbox (bug #632394). Skipping."
+		return 0
+	fi
+
+	cmake-utils_src_test
+}
+
 src_configure() {
 	local mycmakeargs=(
 		-DBUILD_TESTS=$(usex test)


             reply	other threads:[~2019-11-12 22:45 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 22:45 Sergei Trofimovich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-13 13:27 [gentoo-commits] repo/gentoo:master commit in: dev-util/rr/ Sam James
2025-01-25  5:37 Sam James
2025-01-24 15:45 Sam James
2024-10-03 10:05 Sam James
2024-10-03 10:00 Sam James
2024-05-25  7:35 Sam James
2024-04-29 21:48 Sam James
2023-10-03 23:38 Sam James
2023-04-25 19:49 Sam James
2023-01-10  4:32 Sam James
2023-01-10  4:32 Sam James
2022-10-17 21:45 Sam James
2022-10-17 21:45 Sam James
2022-08-20 13:29 Luca Barbato
2022-08-14  8:04 Luca Barbato
2021-09-27  8:55 Luca Barbato
2021-05-15 13:58 Sergei Trofimovich
2021-02-01 16:32 Sam James
2020-11-10 23:49 Sergei Trofimovich
2020-11-02 10:21 Sergei Trofimovich
2020-10-30 23:19 Sergei Trofimovich
2020-10-01 21:49 Sergei Trofimovich
2020-10-01 21:49 Sergei Trofimovich
2020-03-23 23:58 Sergei Trofimovich
2020-02-09 16:25 Michał Górny
2019-12-19 22:25 Sergei Trofimovich
2019-11-12 22:52 Sergei Trofimovich
2019-11-10 21:00 Sergei Trofimovich
2019-05-09 22:37 Sergei Trofimovich
2019-05-09 22:26 Sergei Trofimovich
2018-09-28 14:46 Luca Barbato
2018-06-10 16:29 Sergei Trofimovich
2018-03-12 16:50 Ettore Di Giacinto
2017-10-24 11:29 Luca Barbato
2017-04-20 20:48 David Seifert
2017-02-13 21:51 Mike Frysinger
2017-02-13 21:19 Mike Frysinger
2017-02-13 21:19 Mike Frysinger
2017-02-13 21:19 Mike Frysinger
2017-02-12 18:39 Ettore Di Giacinto
2017-02-12 18:15 Luca Barbato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573598709.899e40469ea6be6d4b4202a6771ecdffd9264e5c.slyfox@gentoo \
    --to=slyfox@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox