From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 7FF7F138334 for ; Wed, 25 Sep 2019 15:05:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 3FB31E0882; Wed, 25 Sep 2019 15:05:36 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 23748E0882 for ; Wed, 25 Sep 2019 15:05:35 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id A36CD34B563 for ; Wed, 25 Sep 2019 15:05:32 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 15AA96E8 for ; Wed, 25 Sep 2019 15:05:30 +0000 (UTC) From: "Fabian Groffen" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Fabian Groffen" Message-ID: <1569423863.5826ee815228775b61ed1587e1346f764dc93945.grobian@gentoo> Subject: [gentoo-commits] proj/portage-utils:master commit in: libq/ X-VCS-Repository: proj/portage-utils X-VCS-Files: libq/tree.c X-VCS-Directories: libq/ X-VCS-Committer: grobian X-VCS-Committer-Name: Fabian Groffen X-VCS-Revision: 5826ee815228775b61ed1587e1346f764dc93945 X-VCS-Branch: master Date: Wed, 25 Sep 2019 15:05:30 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: b50cb034-b81f-4797-ac70-7b0a4037fba2 X-Archives-Hash: 8150e463de798bdfa3e58cd29b98e9aa commit: 5826ee815228775b61ed1587e1346f764dc93945 Author: Fabian Groffen gentoo org> AuthorDate: Wed Sep 25 15:04:23 2019 +0000 Commit: Fabian Groffen gentoo org> CommitDate: Wed Sep 25 15:04:23 2019 +0000 URL: https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=5826ee81 libq/tree: don't close tree in tree_get_atoms The caller passes tree, so the caller should clean it up. This fixes double frees observed in bug #695586 Bug: https://bugs.gentoo.org/695586 Signed-off-by: Fabian Groffen gentoo.org> libq/tree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libq/tree.c b/libq/tree.c index 0699334..2797450 100644 --- a/libq/tree.c +++ b/libq/tree.c @@ -1078,7 +1078,6 @@ tree_get_atoms(tree_ctx *ctx, bool fullcpv, set *satoms) }; tree_foreach_pkg_fast(ctx, tree_get_atoms_cb, &state, NULL); - tree_close(ctx); return state.cpf; }