From: "Göktürk Yüksek" <gokturk@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: eclass-writing/
Date: Fri, 20 Sep 2019 22:52:03 +0000 (UTC) [thread overview]
Message-ID: <1569019870.9f63cc9e468400cc0feb64c3bd45cedb525b0451.gokturk@gentoo> (raw)
commit: 9f63cc9e468400cc0feb64c3bd45cedb525b0451
Author: Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Fri Sep 6 05:57:23 2019 +0000
Commit: Göktürk Yüksek <gokturk <AT> gentoo <DOT> org>
CommitDate: Fri Sep 20 22:51:10 2019 +0000
URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=9f63cc9e
eclass-writing: Make even more explicit, per gentoo-dev
Change 'should' into 'must' for initial reviews. Make it clear
that per-package eclass exception applies only to updates.
ML-Thread: https://archives.gentoo.org/gentoo-dev/message/122108eebce1c4da00a1838896b4b1c3
Signed-off-by: Michał Górny <mgorny <AT> gentoo.org>
Signed-off-by: Göktürk Yüksek <gokturk <AT> gentoo.org>
eclass-writing/text.xml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/eclass-writing/text.xml b/eclass-writing/text.xml
index e26dd00..1bc1768 100644
--- a/eclass-writing/text.xml
+++ b/eclass-writing/text.xml
@@ -46,9 +46,9 @@ Roughly speaking, there are three kinds of eclass:
<body>
<p>
-Before committing a new eclass to the tree, it should be emailed to the
-gentoo-dev mailing list with a justification and a proposed implementation. Do
-not skip this step <d/> sometimes a better implementation or an alternative which
+Before committing a new eclass to the tree, it must be emailed to the gentoo-dev
+mailing list with a justification and a proposed implementation. Do not skip
+this step <d/> sometimes a better implementation or an alternative which
does not require a new eclass will be suggested.
</p>
@@ -61,7 +61,7 @@ and end up breaking something, expect to be in a lot of trouble.
</p>
<p>
-The exceptions to this rule are per-package eclasses. For example,
+The exceptions to this rule are updates to per-package eclasses. For example,
the <c>apache-2</c> eclass is only used by the <c>www-servers/apache</c>
package, and thus does not typically require changes to be emailed for review.
</p>
next reply other threads:[~2019-09-20 22:52 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 22:52 Göktürk Yüksek [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-06 21:37 [gentoo-commits] proj/devmanual:master commit in: eclass-writing/ Ulrich Müller
2024-04-29 6:31 Ulrich Müller
2024-04-29 6:31 Ulrich Müller
2024-04-29 6:31 Ulrich Müller
2024-04-29 6:31 Ulrich Müller
2024-01-19 21:06 Ulrich Müller
2023-08-26 5:30 Ulrich Müller
2023-05-27 18:49 Ulrich Müller
2022-04-30 17:01 Ulrich Müller
2022-04-28 8:12 Ulrich Müller
2022-04-24 12:52 Ulrich Müller
2022-03-26 16:16 Ulrich Müller
2022-03-23 14:10 Ulrich Müller
2022-03-20 13:48 Ulrich Müller
2022-03-18 18:10 Sam James
2022-03-18 18:10 Sam James
2022-03-16 14:47 Sam James
2022-03-16 14:47 Sam James
2021-12-09 5:01 Sam James
2021-10-13 13:44 Ulrich Müller
2021-09-04 10:38 Ulrich Müller
2021-09-04 10:36 Ulrich Müller
2021-09-04 10:36 Ulrich Müller
2021-09-04 10:33 Ulrich Müller
2021-09-04 10:33 Ulrich Müller
2021-04-07 17:35 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2021-03-30 6:55 Ulrich Müller
2020-12-29 22:08 Göktürk Yüksek
2020-09-18 7:01 Ulrich Müller
2019-08-30 15:51 Göktürk Yüksek
2019-08-30 15:51 Göktürk Yüksek
2016-10-31 1:21 Göktürk Yüksek
2016-10-31 1:21 Göktürk Yüksek
2016-10-31 1:21 Göktürk Yüksek
2016-10-31 1:21 Göktürk Yüksek
2016-10-31 1:21 Göktürk Yüksek
2011-12-13 20:17 Petteri Räty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569019870.9f63cc9e468400cc0feb64c3bd45cedb525b0451.gokturk@gentoo \
--to=gokturk@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox