From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D91C5138334 for ; Mon, 2 Sep 2019 07:08:48 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id C4320E0885; Mon, 2 Sep 2019 07:08:47 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 8CE88E0883 for ; Mon, 2 Sep 2019 07:08:47 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id EEE4334AA02 for ; Mon, 2 Sep 2019 07:08:45 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 77818766 for ; Mon, 2 Sep 2019 07:08:44 +0000 (UTC) From: "Matt Turner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Matt Turner" Message-ID: <1567408093.5b2d7c955a8b3c0c422780d25bc2b1355f37df25.mattst88@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-fs/nfs-utils/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-fs/nfs-utils/nfs-utils-2.4.1.ebuild X-VCS-Directories: net-fs/nfs-utils/ X-VCS-Committer: mattst88 X-VCS-Committer-Name: Matt Turner X-VCS-Revision: 5b2d7c955a8b3c0c422780d25bc2b1355f37df25 X-VCS-Branch: master Date: Mon, 2 Sep 2019 07:08:44 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 7664b28f-07f2-41a8-b9de-995d37270764 X-Archives-Hash: c5c5278ea1e1727b625d098dfaf10ba4 commit: 5b2d7c955a8b3c0c422780d25bc2b1355f37df25 Author: Matt Whitlock mattwhitlock name> AuthorDate: Wed May 11 00:32:58 2016 +0000 Commit: Matt Turner gentoo org> CommitDate: Mon Sep 2 07:08:13 2019 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b2d7c95 net-fs/nfs-utils: warn if client tracking will be broken NFSDv4 supports client tracking across server restarts using two methods. The legacy method is in-kernel and requires CONFIG_CRYPTO_MD5, which is not automatically selected by CONFIG_NFSD_V4 (see https://bugzilla.kernel.org/show_bug.cgi?id=52271). The newer method involves a usermode helper upcall program (nfsdcltrack), which is built and installed only when USE="nfsdcld". If neither method is available, then the NFS server does not support tracking clients across restarts, and it emits a warning to the kernel log: NFSD: unable to generate recoverydir name (-2). NFSD: disabling legacy clientid tracking. Reboot recovery will not function correctly! This commit introduces an ewarn in pkg_setup to warn the user if their configuration will not support client tracking due to neither of these options being enabled. Closes: https://github.com/gentoo/gentoo/pull/1448 Closes: https://bugs.gentoo.org/582714 Signed-off-by: Matt Turner gentoo.org> net-fs/nfs-utils/nfs-utils-2.4.1.ebuild | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/net-fs/nfs-utils/nfs-utils-2.4.1.ebuild b/net-fs/nfs-utils/nfs-utils-2.4.1.ebuild index c579954763a..aff15752fd0 100644 --- a/net-fs/nfs-utils/nfs-utils-2.4.1.ebuild +++ b/net-fs/nfs-utils/nfs-utils-2.4.1.ebuild @@ -3,7 +3,7 @@ EAPI=7 -inherit autotools flag-o-matic multilib systemd +inherit autotools flag-o-matic linux-info multilib systemd DESCRIPTION="NFS client and server daemons" HOMEPAGE="http://linux-nfs.org/" @@ -70,6 +70,16 @@ PATCHES=( "${FILESDIR}"/${P}-gssd-Look-in-lib32-for-gss-libs-aswell.patch ) +pkg_setup() { + linux-info_pkg_setup + if use nfsv4 && ! use nfsdcld && linux_config_exists && ! linux_chkconfig_present CRYPTO_MD5 ; then + ewarn "Your NFS server will be unable to track clients across server restarts!" + ewarn "Please enable the \"${HILITE}nfsdcld${NORMAL}\" USE flag to install the nfsdcltrack usermode" + ewarn "helper upcall program, or enable ${HILITE}CONFIG_CRYPTO_MD5${NORMAL} in your kernel to" + ewarn "support the legacy, in-kernel client tracker." + fi +} + src_prepare() { default