public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-apps/ark/, kde-apps/ark/files/
Date: Tue, 13 Aug 2019 05:53:59 +0000 (UTC)	[thread overview]
Message-ID: <1565675600.5b21f5734def975d65bfb183641a8bcd05c53a0d.asturm@gentoo> (raw)

commit:     5b21f5734def975d65bfb183641a8bcd05c53a0d
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Tue Aug 13 05:52:49 2019 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Tue Aug 13 05:53:20 2019 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5b21f573

kde-apps/ark: Fix missing header with Frameworks 5.61

Reported-by: Geoff Madden <mgmadden <AT> internode.on.net>
Closes: https://bugs.gentoo.org/692034
Package-Manager: Portage-2.3.71, Repoman-2.3.17
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>

 kde-apps/ark/ark-19.04.3.ebuild                    |  2 +
 .../ark/files/ark-19.04.3-missing-header.patch     | 54 ++++++++++++++++++++++
 2 files changed, 56 insertions(+)

diff --git a/kde-apps/ark/ark-19.04.3.ebuild b/kde-apps/ark/ark-19.04.3.ebuild
index b9224f70aa0..1369e67045f 100644
--- a/kde-apps/ark/ark-19.04.3.ebuild
+++ b/kde-apps/ark/ark-19.04.3.ebuild
@@ -46,6 +46,8 @@ DEPEND="${RDEPEND}
 	$(add_qt_dep qtconcurrent)
 "
 
+PATCHES=( "${FILESDIR}/${P}-missing-header.patch" )
+
 # bug #560548, last checked with 16.04.1
 RESTRICT+=" test"
 

diff --git a/kde-apps/ark/files/ark-19.04.3-missing-header.patch b/kde-apps/ark/files/ark-19.04.3-missing-header.patch
new file mode 100644
index 00000000000..a0b16e93a4f
--- /dev/null
+++ b/kde-apps/ark/files/ark-19.04.3-missing-header.patch
@@ -0,0 +1,54 @@
+From dfad7a3f389c3b852f45563854df123ac6facdec Mon Sep 17 00:00:00 2001
+From: Nicolas Fella <nicolas.fella@gmx.de>
+Date: Mon, 15 Jul 2019 00:09:18 +0200
+Subject: Add missing QVector include
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Summary:
+My build was failing with
+```
+In file included from /home/nico/kde/src/ark/kerfuffle/pluginmanager.cpp:28:
+/home/nico/kde/src/ark/kerfuffle/pluginmanager.h:138:22: error: field ‘m_plugins’ has incomplete type ‘QVector<Kerfuffle::Plugin*>’
+     QVector<Plugin*> m_plugins;
+                      ^~~~~~~~~
+In file included from /usr/include/qt/QtCore/qglobal.h:1204,
+                 from /usr/include/qt/QtCore/qnamespace.h:43,
+                 from /usr/include/qt/QtCore/qobjectdefs.h:48,
+                 from /usr/include/qt/QtCore/qobject.h:46,
+                 from /usr/include/qt/QtCore/QObject:1,
+                 from /home/nico/kde/src/ark/kerfuffle/plugin.h:33,
+                 from /home/nico/kde/src/ark/kerfuffle/pluginmanager.h:31,
+                 from /home/nico/kde/src/ark/kerfuffle/pluginmanager.cpp:28
+```
+
+Test Plan: Builds. Can open a file
+
+Reviewers: #ark, elvisangelaccio
+
+Reviewed By: #ark, elvisangelaccio
+
+Subscribers: kde-utils-devel, #ark
+
+Tags: #ark
+
+Differential Revision: https://phabricator.kde.org/D22461
+---
+ kerfuffle/pluginmanager.h | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/kerfuffle/pluginmanager.h b/kerfuffle/pluginmanager.h
+index 75a971b..8b9ad69 100644
+--- a/kerfuffle/pluginmanager.h
++++ b/kerfuffle/pluginmanager.h
+@@ -31,6 +31,7 @@
+ #include "plugin.h"
+ 
+ #include <QMimeType>
++#include <QVector>
+ 
+ namespace Kerfuffle
+ {
+-- 
+cgit v1.1


             reply	other threads:[~2019-08-13  5:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  5:53 Andreas Sturmlechner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-10-15 15:23 [gentoo-commits] repo/gentoo:master commit in: kde-apps/ark/, kde-apps/ark/files/ Sam James
2023-10-12 13:23 Andreas Sturmlechner
2021-02-04 14:07 Andreas Sturmlechner
2020-11-25 18:13 Andreas Sturmlechner
2018-04-20  9:51 Andreas Sturmlechner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1565675600.5b21f5734def975d65bfb183641a8bcd05c53a0d.asturm@gentoo \
    --to=asturm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox