From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BAC07138334 for ; Wed, 7 Aug 2019 16:54:22 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id E3ED5E05C1; Wed, 7 Aug 2019 16:54:20 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B6F3BE05C1 for ; Wed, 7 Aug 2019 16:54:20 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 7755F3494A2 for ; Wed, 7 Aug 2019 16:54:19 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 951D9741 for ; Wed, 7 Aug 2019 16:54:17 +0000 (UTC) From: "Brian Evans" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Evans" Message-ID: <1565196849.c50fef32cdf155707ff367f2990996be6c010b1f.grknight@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-db/mariadb/files/, dev-db/mariadb/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-db/mariadb/files/MDEV-20247-replication-10.2.patch dev-db/mariadb/files/MDEV-20247-replication.patch dev-db/mariadb/mariadb-10.1.41-r1.ebuild dev-db/mariadb/mariadb-10.1.41.ebuild dev-db/mariadb/mariadb-10.2.26-r1.ebuild dev-db/mariadb/mariadb-10.2.26.ebuild dev-db/mariadb/mariadb-10.3.17-r1.ebuild dev-db/mariadb/mariadb-10.3.17.ebuild dev-db/mariadb/mariadb-10.4.7-r1.ebuild dev-db/mariadb/mariadb-10.4.7.ebuild X-VCS-Directories: dev-db/mariadb/ dev-db/mariadb/files/ X-VCS-Committer: grknight X-VCS-Committer-Name: Brian Evans X-VCS-Revision: c50fef32cdf155707ff367f2990996be6c010b1f X-VCS-Branch: master Date: Wed, 7 Aug 2019 16:54:17 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 6c0b9df4-2650-4a6c-ae65-a0b5dde158c4 X-Archives-Hash: ce00f23a0fbb39927a736de90ce486be commit: c50fef32cdf155707ff367f2990996be6c010b1f Author: Brian Evans gentoo org> AuthorDate: Wed Aug 7 16:53:24 2019 +0000 Commit: Brian Evans gentoo org> CommitDate: Wed Aug 7 16:54:09 2019 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c50fef32 dev-db/mariadb: Revbump for critical replication bug MDEV-20247 Replication hangs with "preparing" and never starts Include upstream fix Package-Manager: Portage-2.3.71, Repoman-2.3.17 Signed-off-by: Brian Evans gentoo.org> .../files/MDEV-20247-replication-10.2.patch | 108 ++++++++++++++++++ dev-db/mariadb/files/MDEV-20247-replication.patch | 121 +++++++++++++++++++++ ...db-10.1.41.ebuild => mariadb-10.1.41-r1.ebuild} | 1 + ...db-10.2.26.ebuild => mariadb-10.2.26-r1.ebuild} | 1 + ...db-10.3.17.ebuild => mariadb-10.3.17-r1.ebuild} | 1 + ...iadb-10.4.7.ebuild => mariadb-10.4.7-r1.ebuild} | 1 + 6 files changed, 233 insertions(+) diff --git a/dev-db/mariadb/files/MDEV-20247-replication-10.2.patch b/dev-db/mariadb/files/MDEV-20247-replication-10.2.patch new file mode 100644 index 00000000000..193f2dd7750 --- /dev/null +++ b/dev-db/mariadb/files/MDEV-20247-replication-10.2.patch @@ -0,0 +1,108 @@ +From 47f8a18fec604983e47fdf7c822d94b26d85cade Mon Sep 17 00:00:00 2001 +From: Thirunarayanan Balathandayuthapani +Date: Wed, 7 Aug 2019 12:35:04 +0530 +Subject: [PATCH] MDEV-20247 Replication hangs with "preparing" and never + starts + +- The commit ab6dd774082c57f48d998e03655c06b672799b2d wrongly sets the +condition inside innobase_srv_conc_enter_innodb(). Problem is that +InnoDB makes the thread to sleep indefinitely if it is a replication +slave thread. + +Thanks to Sujatha Sivakumar for contributing the replication test case. +--- + .../r/rpl_sync_with_innodb_thd_conc.result | 13 ++++++ + .../rpl/t/rpl_sync_with_innodb_thd_conc.test | 41 +++++++++++++++++++ + storage/innobase/handler/ha_innodb.cc | 6 +-- + 4 files changed, 60 insertions(+), 6 deletions(-) + create mode 100644 mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result + create mode 100644 mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test + +diff --git a/mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result b/mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result +new file mode 100644 +index 000000000000..0ed894336a1c +--- /dev/null ++++ b/mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result +@@ -0,0 +1,18 @@ ++include/master-slave.inc ++[connection master] ++connection slave; ++SET @old_innodb_thread_concurrency := @@innodb_thread_concurrency; ++SET @old_innodb_thread_sleep_delay := @@innodb_thread_sleep_delay; ++SET GLOBAL innodb_thread_concurrency = 100; ++connection master; ++CREATE TABLE t(f INT) ENGINE=INNODB; ++INSERT INTO t VALUES (10); ++connection slave; ++include/diff_tables.inc [master:t, slave:t] ++"===== Clean up=======" ++connection master; ++DROP TABLE t; ++connection slave; ++SET GLOBAL innodb_thread_concurrency = @old_innodb_thread_concurrency; ++SET GLOBAL innodb_thread_sleep_delay = @old_innodb_thread_sleep_delay; ++include/rpl_end.inc +diff --git a/mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test b/mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test +new file mode 100644 +index 000000000000..b4c2971d2fbc +--- /dev/null ++++ b/mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test +@@ -0,0 +1,41 @@ ++# ==== Purpose ==== ++# ++# Test verifies that replication shouldn't hang when number of active threads ++# on the slave server are less than the allowed innodb_thread_concurrency value. ++# ++# ==== Implementation ==== ++# ++# Steps: ++# 0 - Have master slave replication setup with engine being Innodb. ++# 1 - Configure innodb_thread_concurrency = 100. ++# 2 - Do some DML on master and sync the slave with master. ++# 3 - Ensure replication doesn't hang. ++# ++# ==== References ==== ++# ++# MDEV-20247: Replication hangs with "preparing" and never starts ++# ++ ++--source include/master-slave.inc ++--source include/have_innodb.inc ++ ++--connection slave ++SET @old_innodb_thread_concurrency := @@innodb_thread_concurrency; ++SET @old_innodb_thread_sleep_delay := @@innodb_thread_sleep_delay; ++SET GLOBAL innodb_thread_concurrency = 100; ++ ++--connection master ++CREATE TABLE t(f INT) ENGINE=INNODB; ++INSERT INTO t VALUES (10); ++--sync_slave_with_master ++ ++--let $diff_tables=master:t, slave:t ++--source include/diff_tables.inc ++ ++--echo "===== Clean up=======" ++--connection master ++DROP TABLE t; ++--sync_slave_with_master ++SET GLOBAL innodb_thread_concurrency = @old_innodb_thread_concurrency; ++SET GLOBAL innodb_thread_sleep_delay = @old_innodb_thread_sleep_delay; ++--source include/rpl_end.inc +diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc +index 081fcbd9c51e..5dfe240631b8 100644 +--- a/storage/innobase/handler/ha_innodb.cc ++++ b/storage/innobase/handler/ha_innodb.cc +@@ -1686,9 +1686,9 @@ innobase_srv_conc_enter_innodb( + && thd_is_replication_slave_thread(trx->mysql_thd)) { + const ulonglong end = my_interval_timer() + + ulonglong(srv_replication_delay) * 1000000; +- while (srv_conc_get_active_threads() +- >= srv_thread_concurrency +- || my_interval_timer() >= end) { ++ while ((srv_conc_get_active_threads() ++ >= srv_thread_concurrency) ++ && my_interval_timer() < end) { + os_thread_sleep(2000 /* 2 ms */); + } + } else { diff --git a/dev-db/mariadb/files/MDEV-20247-replication.patch b/dev-db/mariadb/files/MDEV-20247-replication.patch new file mode 100644 index 00000000000..92f8e0e1a67 --- /dev/null +++ b/dev-db/mariadb/files/MDEV-20247-replication.patch @@ -0,0 +1,121 @@ +From 47f8a18fec604983e47fdf7c822d94b26d85cade Mon Sep 17 00:00:00 2001 +From: Thirunarayanan Balathandayuthapani +Date: Wed, 7 Aug 2019 12:35:04 +0530 +Subject: [PATCH] MDEV-20247 Replication hangs with "preparing" and never + starts + +- The commit ab6dd774082c57f48d998e03655c06b672799b2d wrongly sets the +condition inside innobase_srv_conc_enter_innodb(). Problem is that +InnoDB makes the thread to sleep indefinitely if it is a replication +slave thread. + +Thanks to Sujatha Sivakumar for contributing the replication test case. +--- + .../r/rpl_sync_with_innodb_thd_conc.result | 13 ++++++ + .../rpl/t/rpl_sync_with_innodb_thd_conc.test | 41 +++++++++++++++++++ + storage/innobase/handler/ha_innodb.cc | 6 +-- + storage/xtradb/handler/ha_innodb.cc | 6 +-- + 4 files changed, 60 insertions(+), 6 deletions(-) + create mode 100644 mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result + create mode 100644 mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test + +diff --git a/mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result b/mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result +new file mode 100644 +index 000000000000..0ed894336a1c +--- /dev/null ++++ b/mysql-test/suite/rpl/r/rpl_sync_with_innodb_thd_conc.result +@@ -0,0 +1,13 @@ ++include/master-slave.inc ++[connection master] ++SET @old_innodb_thread_concurrency := @@innodb_thread_concurrency; ++SET @old_innodb_thread_sleep_delay := @@innodb_thread_sleep_delay; ++SET GLOBAL innodb_thread_concurrency = 100; ++CREATE TABLE t(f INT) ENGINE=INNODB; ++INSERT INTO t VALUES (10); ++include/diff_tables.inc [master:t, slave:t] ++"===== Clean up=======" ++DROP TABLE t; ++SET GLOBAL innodb_thread_concurrency = @old_innodb_thread_concurrency; ++SET GLOBAL innodb_thread_sleep_delay = @old_innodb_thread_sleep_delay; ++include/rpl_end.inc +diff --git a/mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test b/mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test +new file mode 100644 +index 000000000000..b4c2971d2fbc +--- /dev/null ++++ b/mysql-test/suite/rpl/t/rpl_sync_with_innodb_thd_conc.test +@@ -0,0 +1,41 @@ ++# ==== Purpose ==== ++# ++# Test verifies that replication shouldn't hang when number of active threads ++# on the slave server are less than the allowed innodb_thread_concurrency value. ++# ++# ==== Implementation ==== ++# ++# Steps: ++# 0 - Have master slave replication setup with engine being Innodb. ++# 1 - Configure innodb_thread_concurrency = 100. ++# 2 - Do some DML on master and sync the slave with master. ++# 3 - Ensure replication doesn't hang. ++# ++# ==== References ==== ++# ++# MDEV-20247: Replication hangs with "preparing" and never starts ++# ++ ++--source include/master-slave.inc ++--source include/have_innodb.inc ++ ++--connection slave ++SET @old_innodb_thread_concurrency := @@innodb_thread_concurrency; ++SET @old_innodb_thread_sleep_delay := @@innodb_thread_sleep_delay; ++SET GLOBAL innodb_thread_concurrency = 100; ++ ++--connection master ++CREATE TABLE t(f INT) ENGINE=INNODB; ++INSERT INTO t VALUES (10); ++--sync_slave_with_master ++ ++--let $diff_tables=master:t, slave:t ++--source include/diff_tables.inc ++ ++--echo "===== Clean up=======" ++--connection master ++DROP TABLE t; ++--sync_slave_with_master ++SET GLOBAL innodb_thread_concurrency = @old_innodb_thread_concurrency; ++SET GLOBAL innodb_thread_sleep_delay = @old_innodb_thread_sleep_delay; ++--source include/rpl_end.inc +diff --git a/storage/innobase/handler/ha_innodb.cc b/storage/innobase/handler/ha_innodb.cc +index 081fcbd9c51e..5dfe240631b8 100644 +--- a/storage/innobase/handler/ha_innodb.cc ++++ b/storage/innobase/handler/ha_innodb.cc +@@ -1686,9 +1686,9 @@ innobase_srv_conc_enter_innodb( + && thd_is_replication_slave_thread(trx->mysql_thd)) { + const ulonglong end = my_interval_timer() + + ulonglong(srv_replication_delay) * 1000000; +- while (srv_conc_get_active_threads() +- >= srv_thread_concurrency +- || my_interval_timer() >= end) { ++ while ((srv_conc_get_active_threads() ++ >= srv_thread_concurrency) ++ && my_interval_timer() < end) { + os_thread_sleep(2000 /* 2 ms */); + } + } else { +diff --git a/storage/xtradb/handler/ha_innodb.cc b/storage/xtradb/handler/ha_innodb.cc +index 5e7482ff6bfa..b5002187e3b2 100644 +--- a/storage/xtradb/handler/ha_innodb.cc ++++ b/storage/xtradb/handler/ha_innodb.cc +@@ -1949,9 +1949,9 @@ innobase_srv_conc_enter_innodb( + && thd_is_replication_slave_thread(trx->mysql_thd)) { + const ulonglong end = my_interval_timer() + + ulonglong(srv_replication_delay) * 1000000; +- while (srv_conc_get_active_threads() +- >= srv_thread_concurrency +- || my_interval_timer() >= end) { ++ while ((srv_conc_get_active_threads() ++ >= srv_thread_concurrency) ++ && my_interval_timer() < end) { + os_thread_sleep(2000 /* 2 ms */); + } + } else { diff --git a/dev-db/mariadb/mariadb-10.1.41.ebuild b/dev-db/mariadb/mariadb-10.1.41-r1.ebuild similarity index 99% rename from dev-db/mariadb/mariadb-10.1.41.ebuild rename to dev-db/mariadb/mariadb-10.1.41-r1.ebuild index 40a3c6f6fd6..a94d8c0ce08 100644 --- a/dev-db/mariadb/mariadb-10.1.41.ebuild +++ b/dev-db/mariadb/mariadb-10.1.41-r1.ebuild @@ -64,6 +64,7 @@ PATCHES=( "${MY_PATCH_DIR}"/20025_all_mariadb-10.1.26-gssapi-detect.patch "${MY_PATCH_DIR}"/20029_all_mariadb-10.1.37-enable-numa.patch "${MY_PATCH_DIR}"/20035_all_mariadb-10.1-atomic-detection.patch + "${FILESDIR}/MDEV-20247-replication.patch" ) # Be warned, *DEPEND are version-dependant diff --git a/dev-db/mariadb/mariadb-10.2.26.ebuild b/dev-db/mariadb/mariadb-10.2.26-r1.ebuild similarity index 99% rename from dev-db/mariadb/mariadb-10.2.26.ebuild rename to dev-db/mariadb/mariadb-10.2.26-r1.ebuild index b43d53dfd0b..797d944ec89 100644 --- a/dev-db/mariadb/mariadb-10.2.26.ebuild +++ b/dev-db/mariadb/mariadb-10.2.26-r1.ebuild @@ -64,6 +64,7 @@ PATCHES=( "${MY_PATCH_DIR}"/20024_all_mariadb-10.2.6-mysql_st-regression.patch "${MY_PATCH_DIR}"/20025_all_mariadb-10.2.6-gssapi-detect.patch "${MY_PATCH_DIR}"/20035_all_mariadb-10.2-atomic-detection.patch + "${FILESDIR}/MDEV-20247-replication-10.2.patch" ) # Be warned, *DEPEND are version-dependant diff --git a/dev-db/mariadb/mariadb-10.3.17.ebuild b/dev-db/mariadb/mariadb-10.3.17-r1.ebuild similarity index 99% rename from dev-db/mariadb/mariadb-10.3.17.ebuild rename to dev-db/mariadb/mariadb-10.3.17-r1.ebuild index d960aec7eba..0c288122d44 100644 --- a/dev-db/mariadb/mariadb-10.3.17.ebuild +++ b/dev-db/mariadb/mariadb-10.3.17-r1.ebuild @@ -64,6 +64,7 @@ PATCHES=( "${MY_PATCH_DIR}"/20024_all_mariadb-10.2.6-mysql_st-regression.patch "${MY_PATCH_DIR}"/20025_all_mariadb-10.2.6-gssapi-detect.patch "${MY_PATCH_DIR}"/20035_all_mariadb-10.3-atomic-detection.patch + "${FILESDIR}/MDEV-20247-replication-10.2.patch" ) # Be warned, *DEPEND are version-dependant diff --git a/dev-db/mariadb/mariadb-10.4.7.ebuild b/dev-db/mariadb/mariadb-10.4.7-r1.ebuild similarity index 99% rename from dev-db/mariadb/mariadb-10.4.7.ebuild rename to dev-db/mariadb/mariadb-10.4.7-r1.ebuild index 4ab8c38d372..5e4da733a88 100644 --- a/dev-db/mariadb/mariadb-10.4.7.ebuild +++ b/dev-db/mariadb/mariadb-10.4.7-r1.ebuild @@ -62,6 +62,7 @@ PATCHES=( "${MY_PATCH_DIR}"/20024_all_mariadb-10.2.6-mysql_st-regression.patch "${MY_PATCH_DIR}"/20025_all_mariadb-10.2.6-gssapi-detect.patch "${MY_PATCH_DIR}"/20035_all_mariadb-10.3-atomic-detection.patch + "${FILESDIR}/MDEV-20247-replication-10.2.patch" ) # Be warned, *DEPEND are version-dependant