public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/clementine/files/, media-sound/clementine/
Date: Sat, 13 Jul 2019 08:51:02 +0000 (UTC)	[thread overview]
Message-ID: <1563007845.66e5a91fc96dd9acf01f84b458c7c4b39aa405bf.asturm@gentoo> (raw)

commit:     66e5a91fc96dd9acf01f84b458c7c4b39aa405bf
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Sat Jul 13 08:50:06 2019 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Sat Jul 13 08:50:45 2019 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66e5a91f

media-sound/clementine: Fix restore from systray with >=Qt-5.12.4

See upstream PR: https://github.com/clementine-player/Clementine/pull/6351

Package-Manager: Portage-2.3.69, Repoman-2.3.16
Signed-off-by: Andreas Sturmlechner <asturm <AT> gentoo.org>

 .../clementine/clementine-1.3.1_p20190609.ebuild   |  2 ++
 ...-1.3.1_p20190609-fix-restore-from-systray.patch | 34 ++++++++++++++++++++++
 2 files changed, 36 insertions(+)

diff --git a/media-sound/clementine/clementine-1.3.1_p20190609.ebuild b/media-sound/clementine/clementine-1.3.1_p20190609.ebuild
index 54765a4608b..a4d5f63d5bb 100644
--- a/media-sound/clementine/clementine-1.3.1_p20190609.ebuild
+++ b/media-sound/clementine/clementine-1.3.1_p20190609.ebuild
@@ -104,6 +104,8 @@ RESTRICT="test"
 
 DOCS=( Changelog README.md )
 
+PATCHES=( "${FILESDIR}/${P}-fix-restore-from-systray.patch" )
+
 src_prepare() {
 	l10n_find_plocales_changes "src/translations" "" ".po"
 

diff --git a/media-sound/clementine/files/clementine-1.3.1_p20190609-fix-restore-from-systray.patch b/media-sound/clementine/files/clementine-1.3.1_p20190609-fix-restore-from-systray.patch
new file mode 100644
index 00000000000..9f27e219e89
--- /dev/null
+++ b/media-sound/clementine/files/clementine-1.3.1_p20190609-fix-restore-from-systray.patch
@@ -0,0 +1,34 @@
+From 1bf633e71b7b5d8e5965971036d66e1d18552b49 Mon Sep 17 00:00:00 2001
+From: Michael Niggli <m.niggli@gmail.com>
+Date: Fri, 31 May 2019 17:04:46 +0200
+Subject: [PATCH] Fix blank window when restoring from systray
+
+This applies the fix qBittorrent used for this same issue:
+https://github.com/qbittorrent/qBittorrent/issues/9240,
+so credit goes to those guys
+---
+ src/ui/mainwindow.cpp | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/ui/mainwindow.cpp b/src/ui/mainwindow.cpp
+index 2944d46ec..ad603fd64 100644
+--- a/src/ui/mainwindow.cpp
++++ b/src/ui/mainwindow.cpp
+@@ -1441,7 +1441,7 @@ void MainWindow::closeEvent(QCloseEvent* event) {
+     keep_running = s.value("keeprunning", tray_icon_->IsVisible()).toBool();
+ 
+   if (keep_running && event->spontaneous()) {
+-    event->accept();
++    event->ignore();
+     SetHiddenInTray(true);
+   } else {
+     Exit();
+@@ -1454,7 +1454,7 @@ void MainWindow::SetHiddenInTray(bool hidden) {
+   // Some window managers don't remember maximized state between calls to
+   // hide() and show(), so we have to remember it ourself.
+   if (hidden) {
+-    hide();
++    QTimer::singleShot(0, this, &QWidget::hide);
+   } else {
+     if (was_maximized_)
+       showMaximized();


             reply	other threads:[~2019-07-13  8:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-13  8:51 Andreas Sturmlechner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-11 20:54 [gentoo-commits] repo/gentoo:master commit in: media-sound/clementine/files/, media-sound/clementine/ Andreas Sturmlechner
2025-01-07 23:42 Sam James
2024-01-05 10:36 Sam James
2023-12-23 20:05 Joonas Niilola
2023-10-17  5:24 Yixun Lan
2022-10-16  4:53 Miroslav Šulc
2021-07-02 10:42 Lars Wendler
2019-02-17 16:05 Lars Wendler
2018-11-17 23:10 Andreas Sturmlechner
2018-03-17  0:27 Andreas Sturmlechner
2017-12-19  9:32 Andreas Sturmlechner
2017-11-19 15:09 Andreas Sturmlechner
2016-12-26 23:39 Lars Wendler
2016-04-17 17:52 Lars Wendler
2016-04-17  4:41 Jason Donenfeld
2016-01-13 17:21 Lars Wendler
2015-08-25  8:13 Lars Wendler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1563007845.66e5a91fc96dd9acf01f84b458c7c4b39aa405bf.asturm@gentoo \
    --to=asturm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox