From: "Mike Gilbert" <floppym@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: www-client/chromium/files/
Date: Fri, 28 Jun 2019 15:30:35 +0000 (UTC) [thread overview]
Message-ID: <1561735742.1cc6e650f4b09c32396fb33c6588dd2c09e53945.floppym@gentoo> (raw)
commit: 1cc6e650f4b09c32396fb33c6588dd2c09e53945
Author: Stephan Hartmann <stha09 <AT> googlemail <DOT> com>
AuthorDate: Wed Jun 26 14:25:05 2019 +0000
Commit: Mike Gilbert <floppym <AT> gentoo <DOT> org>
CommitDate: Fri Jun 28 15:29:02 2019 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1cc6e650
www-client/chromium: update angle inline patch
Closes: https://github.com/gentoo/gentoo/pull/12331
Package-Manager: Portage-2.3.66, Repoman-2.3.11
Signed-off-by: Stephan Hartmann <stha09 <AT> googlemail.com>
Signed-off-by: Mike Gilbert <floppym <AT> gentoo.org>
.../chromium/files/chromium-angle-inline.patch | 120 ++++++++++++++++++---
1 file changed, 106 insertions(+), 14 deletions(-)
diff --git a/www-client/chromium/files/chromium-angle-inline.patch b/www-client/chromium/files/chromium-angle-inline.patch
index 8ece410f104..e8975d74817 100644
--- a/www-client/chromium/files/chromium-angle-inline.patch
+++ b/www-client/chromium/files/chromium-angle-inline.patch
@@ -1,26 +1,118 @@
-From 2ee4e7f857514f4c0cbff135a1c5f968d8814d31 Mon Sep 17 00:00:00 2001
-From: Stephan Hartmann <stha09@googlemail.com>
-Date: Sun, 23 Jun 2019 12:14:57 +0000
-Subject: [PATCH] explicit declaration of const GLfloat/const GLint for ValidateSamplerParameterBase
+From 4c0a23611b3906855db7b93da2f34aec57930cdf Mon Sep 17 00:00:00 2001
+From: Geoff Lang <geofflang@chromium.org>
+Date: Tue, 25 Jun 2019 10:56:29 -0400
+Subject: [PATCH] Update ValidateSamplerParameterBase to use const parameters.
+ValidateSamplerParameterBase is called with both const and non-const
+parameter pointers which caused our explicit template instantiations to
+not cover all cases resulting in link errors. Force the parameters to
+always be const so that our instantiations cover everything.
+
+BUG=angleproject:3555
+
+Change-Id: Ibf92572ba80a689c75dcdc70e5153d9941da76f3
+Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1676305
+Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
+Commit-Queue: Geoff Lang <geofflang@chromium.org>
---
- third_party/angle/src/libANGLE/validationES.cpp | 2 ++
- 1 file changed, 2 insertions(+)
diff --git a/third_party/angle/src/libANGLE/validationES.cpp b/third_party/angle/src/libANGLE/validationES.cpp
-index ae353f7..fdc7ac2 100644
+index 041803a..3f402f6 100644
--- a/third_party/angle/src/libANGLE/validationES.cpp
+++ b/third_party/angle/src/libANGLE/validationES.cpp
-@@ -6089,7 +6089,9 @@ bool ValidateSamplerParameterBase(Context *context,
+@@ -189,7 +189,9 @@
+ }
+
+ template <typename ParamType>
+-bool ValidateTextureWrapModeValue(Context *context, ParamType *params, bool restrictedWrapModes)
++bool ValidateTextureWrapModeValue(Context *context,
++ const ParamType *params,
++ bool restrictedWrapModes)
+ {
+ switch (ConvertToGLenum(params[0]))
+ {
+@@ -223,7 +225,9 @@
+ }
+
+ template <typename ParamType>
+-bool ValidateTextureMinFilterValue(Context *context, ParamType *params, bool restrictedMinFilter)
++bool ValidateTextureMinFilterValue(Context *context,
++ const ParamType *params,
++ bool restrictedMinFilter)
+ {
+ switch (ConvertToGLenum(params[0]))
+ {
+@@ -252,7 +256,7 @@
+ }
+
+ template <typename ParamType>
+-bool ValidateTextureMagFilterValue(Context *context, ParamType *params)
++bool ValidateTextureMagFilterValue(Context *context, const ParamType *params)
+ {
+ switch (ConvertToGLenum(params[0]))
+ {
+@@ -269,7 +273,7 @@
}
- template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, GLfloat *);
-+template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, const GLfloat *);
- template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, GLint *);
+ template <typename ParamType>
+-bool ValidateTextureCompareModeValue(Context *context, ParamType *params)
++bool ValidateTextureCompareModeValue(Context *context, const ParamType *params)
+ {
+ // Acceptable mode parameters from GLES 3.0.2 spec, table 3.17
+ switch (ConvertToGLenum(params[0]))
+@@ -287,7 +291,7 @@
+ }
+
+ template <typename ParamType>
+-bool ValidateTextureCompareFuncValue(Context *context, ParamType *params)
++bool ValidateTextureCompareFuncValue(Context *context, const ParamType *params)
+ {
+ // Acceptable function parameters from GLES 3.0.2 spec, table 3.17
+ switch (ConvertToGLenum(params[0]))
+@@ -311,7 +315,7 @@
+ }
+
+ template <typename ParamType>
+-bool ValidateTextureSRGBDecodeValue(Context *context, ParamType *params)
++bool ValidateTextureSRGBDecodeValue(Context *context, const ParamType *params)
+ {
+ if (!context->getExtensions().textureSRGBDecode)
+ {
+@@ -5996,7 +6000,7 @@
+ GLenum pname,
+ GLsizei bufSize,
+ bool vectorParams,
+- ParamType *params)
++ const ParamType *params)
+ {
+ if (context->getClientMajorVersion() < 3)
+ {
+@@ -6099,8 +6103,13 @@
+ return true;
+ }
+
+-template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, GLfloat *);
+-template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, GLint *);
++template bool ValidateSamplerParameterBase(Context *,
++ GLuint,
++ GLenum,
++ GLsizei,
++ bool,
++ const GLfloat *);
+template bool ValidateSamplerParameterBase(Context *, GLuint, GLenum, GLsizei, bool, const GLint *);
template bool ValidateSamplerParameterBase(Context *,
GLuint,
GLenum,
---
-2.21.0
-
+diff --git a/third_party/angle/src/libANGLE/validationES.h b/third_party/angle/src/libANGLE/validationES.h
+index c61bda6..4b06d28 100644
+--- a/third_party/angle/src/libANGLE/validationES.h
++++ b/third_party/angle/src/libANGLE/validationES.h
+@@ -584,7 +584,7 @@
+ GLenum pname,
+ GLsizei bufSize,
+ bool vectorParams,
+- ParamType *params);
++ const ParamType *params);
+
+ bool ValidateGetInternalFormativBase(Context *context,
+ GLenum target,
next reply other threads:[~2019-06-28 15:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 15:30 Mike Gilbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-05 2:53 [gentoo-commits] repo/gentoo:master commit in: www-client/chromium/files/ Matt Jolly
2025-01-20 21:57 Conrad Kostecki
2025-01-04 22:47 Conrad Kostecki
2024-12-06 23:12 Conrad Kostecki
2024-10-15 21:46 Conrad Kostecki
2024-06-27 15:40 Conrad Kostecki
2024-06-22 18:54 Conrad Kostecki
2024-04-18 19:32 Conrad Kostecki
2024-03-27 7:55 Matt Jolly
2024-03-05 9:18 Petr Vaněk
2023-10-04 21:45 Conrad Kostecki
2023-09-13 18:43 Conrad Kostecki
2023-07-02 1:43 Conrad Kostecki
2023-06-30 19:03 Stephan Hartmann
2023-05-07 18:22 Mike Gilbert
2023-05-02 20:05 Mike Gilbert
2023-04-23 14:46 Mike Gilbert
2023-01-01 18:16 Conrad Kostecki
2022-12-22 19:54 Stephan Hartmann
2022-02-03 9:18 Stephan Hartmann
2021-11-20 10:08 Stephan Hartmann
2021-08-28 19:43 Stephan Hartmann
2021-07-03 7:51 Stephan Hartmann
2020-07-14 17:32 Mike Gilbert
2020-02-28 14:39 Mike Gilbert
2020-01-30 16:17 Mike Gilbert
2019-06-20 14:49 Mike Gilbert
2018-12-29 18:50 Mike Gilbert
2018-11-05 3:30 Mike Gilbert
2018-09-30 21:28 Mike Gilbert
2018-08-08 16:00 Mike Gilbert
2018-07-23 20:40 Mike Gilbert
2018-06-20 21:46 Mike Gilbert
2018-03-13 21:20 Mike Gilbert
2018-03-02 15:01 Mike Gilbert
2018-02-18 22:40 Mike Gilbert
2017-12-31 17:09 Mike Gilbert
2017-12-12 18:17 Mike Gilbert
2017-12-09 23:27 Mike Gilbert
2017-11-17 19:38 Mike Gilbert
2017-10-31 17:15 Mike Gilbert
2017-10-02 21:26 Mike Gilbert
2017-08-09 14:30 Mike Gilbert
2017-06-11 16:50 Mike Gilbert
2017-02-17 1:25 Mike Gilbert
2016-12-04 22:43 Mike Gilbert
2016-11-08 5:47 Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561735742.1cc6e650f4b09c32396fb33c6588dd2c09e53945.floppym@gentoo \
--to=floppym@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox