From: "Sergei Trofimovich" <slyfox@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/gcc-patches:master commit in: 4.6.4/gentoo/
Date: Wed, 29 May 2019 06:56:42 +0000 (UTC) [thread overview]
Message-ID: <1559112981.5ea5abd9862ba73faa75e620e1055818fed794c7.slyfox@gentoo> (raw)
commit: 5ea5abd9862ba73faa75e620e1055818fed794c7
Author: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
AuthorDate: Wed May 29 06:56:21 2019 +0000
Commit: Sergei Trofimovich <slyfox <AT> gentoo <DOT> org>
CommitDate: Wed May 29 06:56:21 2019 +0000
URL: https://gitweb.gentoo.org/proj/gcc-patches.git/commit/?id=5ea5abd9
4.6.4: backport gperf-gnu-inline patch
Signed-off-by: Sergei Trofimovich <slyfox <AT> gentoo.org>
4.6.4/gentoo/96_all_gcc-gperf-gnu-inline.patch | 64 ++++++++++++++++++++++++++
4.6.4/gentoo/README.history | 1 +
2 files changed, 65 insertions(+)
diff --git a/4.6.4/gentoo/96_all_gcc-gperf-gnu-inline.patch b/4.6.4/gentoo/96_all_gcc-gperf-gnu-inline.patch
new file mode 100644
index 0000000..b26647a
--- /dev/null
+++ b/4.6.4/gentoo/96_all_gcc-gperf-gnu-inline.patch
@@ -0,0 +1,64 @@
+https://gcc.gnu.org/ml/gcc-patches/2015-08/msg00375.html
+
+From 1de9842cba4749376b545a09ef0b4fc195d319a6 Mon Sep 17 00:00:00 2001
+From: Mike Frysinger <vapier@gentoo.org>
+Date: Thu, 6 Aug 2015 23:32:54 -0400
+Subject: [PATCH] cfns: fix mismatch in gnu_inline attributes
+
+Since the 3.0.3 release of gperf (made in May 2007), the generated func
+has had the gnu_inline attribute applied to it. The gcc source however
+has not been updated to include that which has lead to a mismatch.
+
+In practice, this hasn't been an issue for two reasons:
+(1) Before gcc-5, the default standard was (gnu) C89, and gcc does not
+warn or throw an error in this mode.
+(2) Starting with gcc-4.8, the compiler driver used to build gcc was
+changed to C++, and g++ does not warn or throw an error in this mode.
+
+This error does show up though when using gcc-5 to build gcc-4.7 or
+older as then the default is (gnu) C11 and the C compiler driver is
+used. That failure looks like:
+In file included from .../gcc-4.7.4/gcc/cp/except.c:990:0:
+cfns.gperf: At top level:
+cfns.gperf:101:1: error: 'gnu_inline' attribute present on 'libc_name_p'
+cfns.gperf:26:14: error: but not here
+
+Whether the compiler should always emit this error regardless of the
+active standard or compiler driver is debatable (I think it should be
+consistent -- either always do it or never do it).
+---
+ gcc/cp/cfns.gperf | 3 +++
+ gcc/cp/cfns.h | 3 +++
+ 2 files changed, 6 insertions(+)
+
+diff --git a/gcc/cp/cfns.gperf b/gcc/cp/cfns.gperf
+index 68acd3d..953262f 100644
+--- a/gcc/cp/cfns.gperf
++++ b/gcc/cp/cfns.gperf
+@@ -22,6 +22,9 @@ __inline
+ static unsigned int hash (const char *, unsigned int);
+ #ifdef __GNUC__
+ __inline
++#ifdef __GNUC_STDC_INLINE__
++__attribute__ ((__gnu_inline__)) static
++#endif
+ #endif
+ const char * libc_name_p (const char *, unsigned int);
+ %}
+diff --git a/gcc/cp/cfns.h b/gcc/cp/cfns.h
+index 1c6665d..6d00c0e 100644
+--- a/gcc/cp/cfns.h
++++ b/gcc/cp/cfns.h
+@@ -53,6 +53,9 @@ __inline
+ static unsigned int hash (const char *, unsigned int);
+ #ifdef __GNUC__
+ __inline
++#ifdef __GNUC_STDC_INLINE__
++__attribute__ ((__gnu_inline__)) static
++#endif
+ #endif
+ const char * libc_name_p (const char *, unsigned int);
+ /* maximum key range = 391, duplicates = 0 */
+--
+2.4.4
+
diff --git a/4.6.4/gentoo/README.history b/4.6.4/gentoo/README.history
index 49ed8ec..af8339f 100644
--- a/4.6.4/gentoo/README.history
+++ b/4.6.4/gentoo/README.history
@@ -1,5 +1,6 @@
1.5 TODO
+ 95_all_libjava-ucontext.patch
+ + 96_all_gcc-gperf-gnu-inline.patch
1.4 23 Sep 2018
- 10_all_default-fortify-source.patch
next reply other threads:[~2019-05-29 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 6:56 Sergei Trofimovich [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-09 23:51 [gentoo-commits] proj/gcc-patches:master commit in: 4.6.4/gentoo/ Sergei Trofimovich
2019-06-01 9:09 Sergei Trofimovich
2018-11-19 23:40 Sergei Trofimovich
2018-09-23 21:39 Sergei Trofimovich
2018-09-15 23:26 Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559112981.5ea5abd9862ba73faa75e620e1055818fed794c7.slyfox@gentoo \
--to=slyfox@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox