From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4FB76138334 for ; Mon, 29 Apr 2019 17:35:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 53366E08D1; Mon, 29 Apr 2019 17:35:02 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 07D0FE08D1 for ; Mon, 29 Apr 2019 17:35:01 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E69C03430D0 for ; Mon, 29 Apr 2019 17:35:00 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 19C5F57E for ; Mon, 29 Apr 2019 17:34:59 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1556559171.a0e75219444993d81826f7650bcccad80c968b5d.zmedico@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/cri-o/ X-VCS-Repository: repo/gentoo X-VCS-Files: app-emulation/cri-o/cri-o-1.10.6.ebuild app-emulation/cri-o/cri-o-1.13.5.ebuild X-VCS-Directories: app-emulation/cri-o/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: a0e75219444993d81826f7650bcccad80c968b5d X-VCS-Branch: master Date: Mon, 29 Apr 2019 17:34:59 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 3c567eac-23f8-41c2-957b-cdf571b1c39e X-Archives-Hash: 54926d53563d547143042a95f88ff194 commit: a0e75219444993d81826f7650bcccad80c968b5d Author: Dongsu Park kinvolk io> AuthorDate: Mon Apr 29 05:42:50 2019 +0000 Commit: Zac Medico gentoo org> CommitDate: Mon Apr 29 17:32:51 2019 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0e75219 app-emulation/cri-o: disable go build install flag There has been a corner case where `make bin/crio` failed like that: ``` go build runtime/cgo: open /usr/lib/go1.12/pkg/linux_amd64/runtime/cgo.a: permission denied make: *** [Makefile:99: bin/crio] Error 1 ``` The failure happens only under certain circumstances, for example in Jenkins pipelines, where the standard Go runtime path `/usr/lib/go1.12` is not writable for normal users like `jenkins`. On the other hand, the failure is not reproducible when testing locally, nor when testing with the root user who can write to the Go runtime path. What happens is, the standard Go runtime sometime has incorrect timestamps or checksums of `cgo.a`, which makes `go build -i` think that it has to install its own library to the system directory. That's obviously not what the build process should do. Since Go 1.10, it's unnecessary to run `go build` with an `-i` option, because now `go build` command itself maintains a cache of recently build packages. Build speed will not be better by adding an `-i` option. So let's remove `-i` flag from `go build`. That's actually what upstream Go maintainers recommend to do. See: https://github.com/golang/go/issues/24674 Closes: https://github.com/gentoo/gentoo/pull/11863 Package-Manager: Portage-2.3.65, Repoman-2.3.12 Signed-off-by: Dongsu Park kinvolk.io> Signed-off-by: Zac Medico gentoo.org> app-emulation/cri-o/cri-o-1.10.6.ebuild | 2 +- app-emulation/cri-o/cri-o-1.13.5.ebuild | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app-emulation/cri-o/cri-o-1.10.6.ebuild b/app-emulation/cri-o/cri-o-1.10.6.ebuild index dbb1db95a32..845da94a93b 100644 --- a/app-emulation/cri-o/cri-o-1.10.6.ebuild +++ b/app-emulation/cri-o/cri-o-1.10.6.ebuild @@ -43,7 +43,7 @@ src_prepare() { default sed -e '/^GIT_.*/d' \ - -e 's/$(GO) build/$(GO) build -v -work -x/' \ + -e 's/$(GO) build -i/$(GO) build -v -work -x/' \ -e 's/\${GIT_COMMIT}/'${EGIT_COMMIT}'/' \ -i Makefile || die diff --git a/app-emulation/cri-o/cri-o-1.13.5.ebuild b/app-emulation/cri-o/cri-o-1.13.5.ebuild index bf1e755e142..2478498c2a7 100644 --- a/app-emulation/cri-o/cri-o-1.13.5.ebuild +++ b/app-emulation/cri-o/cri-o-1.13.5.ebuild @@ -44,7 +44,7 @@ src_prepare() { sed -e '/^GIT_.*/d' \ -e '/ git diff --exit-code/d' \ - -e 's/$(GO) build/$(GO) build -v -work -x/' \ + -e 's/$(GO) build -i/$(GO) build -v -work -x/' \ -e 's/\${GIT_COMMIT}/'${EGIT_COMMIT}'/' \ -i Makefile || die