public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ralph Seichter" <gentoo@seichter.de>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/proj/guru:master commit in: dev-lang/fbc/
Date: Mon, 29 Apr 2019 14:11:55 +0000 (UTC)	[thread overview]
Message-ID: <1556506809.632a6d2d292602425035c47bd31f6b76a0857404.ralph-seichter@gentoo> (raw)

commit:     632a6d2d292602425035c47bd31f6b76a0857404
Author:     William Breathitt Gray <vilhelm.gray <AT> gmail <DOT> com>
AuthorDate: Mon Apr 29 02:58:31 2019 +0000
Commit:     Ralph Seichter <gentoo <AT> seichter <DOT> de>
CommitDate: Mon Apr 29 03:00:09 2019 +0000
URL:        https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=632a6d2d

dev-lang/fbc: Simplify definition of xcflags and fblflags

Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: William Breathitt Gray <vilhelm.gray <AT> gmail.com>

 dev-lang/fbc/fbc-1.06.0.ebuild | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/dev-lang/fbc/fbc-1.06.0.ebuild b/dev-lang/fbc/fbc-1.06.0.ebuild
index 8783039..ba5b069 100644
--- a/dev-lang/fbc/fbc-1.06.0.ebuild
+++ b/dev-lang/fbc/fbc-1.06.0.ebuild
@@ -69,10 +69,12 @@ src_compile() {
 		cd "${S}" || die "cd failed"
 	fi
 
-	local xcflags=$(usex gpm "" "-DDISABLE_GPM")
-	xcflags+=$(usex libffi "" " -DDISABLE_FFI")
-	xcflags+=$(usex opengl "" " -DDISABLE_OPENGL")
-	xcflags+=$(usex X "" " -DDISABLE_X11")
+	local xcflags=(
+		$(usex gpm "" "-DDISABLE_GPM")
+		$(usex libffi "" " -DDISABLE_FFI")
+		$(usex opengl "" " -DDISABLE_OPENGL")
+		$(usex X "" " -DDISABLE_X11")
+	)
 
 	# fbc automatically strips the executables it compiles; in order to avoid
 	# creating striped executables, we override the fbc hardcoded linker "-s"
@@ -81,10 +83,10 @@ src_compile() {
 	# "--strip-debug" flag should be a safe option)
 	local fblflags="-Wl --strip-debug "
 	# fbc requires a space after the -Wl option
-	fblflags+=$(echo "${LDFLAGS}" | sed 's/-Wl,/-Wl /g')
+	fblflags+=${LDFLAGS//-Wl,/-Wl }
 
 	# Build fbc
-	emake CFLAGS="${CFLAGS} ${xcflags}" FBC="${fbc}" FBCFLAGS="${fbcflags}" FBLFLAGS="${fblflags}"
+	emake CFLAGS="${CFLAGS} ${xcflags[@]}" FBC="${fbc}" FBCFLAGS="${fbcflags}" FBLFLAGS="${fblflags}"
 }
 
 src_install() {


             reply	other threads:[~2019-04-29 14:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29 14:11 Ralph Seichter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-04-29 14:11 [gentoo-commits] repo/proj/guru:master commit in: dev-lang/fbc/ Ralph Seichter
2019-04-29 14:11 Ralph Seichter
2019-05-14 16:05 Ralph Seichter
2019-05-19 15:42 Ralph Seichter
2020-03-09 17:55 Andrew Ammerlaan
2020-12-27 12:48 Andrew Ammerlaan
2020-12-28 23:22 Andrew Ammerlaan
2021-04-12  5:38 Theo Anderson
2021-04-30  7:45 Andrew Ammerlaan
2021-04-30  7:45 Andrew Ammerlaan
2021-05-05  8:33 Andrew Ammerlaan
2021-09-08 15:20 Arthur Zamarin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556506809.632a6d2d292602425035c47bd31f6b76a0857404.ralph-seichter@gentoo \
    --to=gentoo@seichter.de \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox