From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BAF70138334 for ; Wed, 24 Apr 2019 21:26:12 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B30B5E09D7; Wed, 24 Apr 2019 21:26:10 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 85C15E09D7 for ; Wed, 24 Apr 2019 21:26:10 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 181BF342427 for ; Wed, 24 Apr 2019 21:26:09 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id AD26E567 for ; Wed, 24 Apr 2019 21:26:07 +0000 (UTC) From: "Michael Orlitzky" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Michael Orlitzky" Message-ID: <1556141055.843899b66751006b2b882d6f5741f3d0082c06fd.mjo@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: mail-filter/opendkim/, mail-filter/opendkim/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: mail-filter/opendkim/files/opendkim-2.10.3-openrc.patch mail-filter/opendkim/opendkim-2.10.3-r11.ebuild mail-filter/opendkim/opendkim-2.10.3-r12.ebuild X-VCS-Directories: mail-filter/opendkim/ mail-filter/opendkim/files/ X-VCS-Committer: mjo X-VCS-Committer-Name: Michael Orlitzky X-VCS-Revision: 843899b66751006b2b882d6f5741f3d0082c06fd X-VCS-Branch: master Date: Wed, 24 Apr 2019 21:26:07 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 8ccb2f6a-bc97-43b3-9901-e4d661a25c28 X-Archives-Hash: 86f8d002e18816b2671c6c92272e880e commit: 843899b66751006b2b882d6f5741f3d0082c06fd Author: Michael Orlitzky gentoo org> AuthorDate: Wed Apr 24 21:23:44 2019 +0000 Commit: Michael Orlitzky gentoo org> CommitDate: Wed Apr 24 21:24:15 2019 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=843899b6 mail-filter/opendkim: new revision to set sysconfdir consistently. In the previous revision -r11, we tried to unite the configuration for OpenRC and systemd. But, I made a mistake: the upstream location for e.g. the main configuration file is @sysconfdir /opendkim.conf, but in Gentoo we install it to @sysconfdir /opendkim/opendkim.conf. That path is overridden in the OpenRC service script, but not in the systemd service, which now crashes upon starting. The error, however, is in the OpenRC script (and in our ebuild). The correct way to relocate the configuration files is to pass a different value to --sysconfdir in src_configure(). This new revision does that, and updates the OpenRC service script to use the built-in location, rather than a custom Gentoo-defined one. That's how it should have been all along. This also fixes an unreported bug, wherein all of the installed documentation like opendkim.conf(5) pointed to the wrong path. Thanks to Ralph Seichter who built a systemd virtual machine in order to test everything. Signed-off-by: Michael Orlitzky gentoo.org> Package-Manager: Portage-2.3.62, Repoman-2.3.11 mail-filter/opendkim/files/opendkim-2.10.3-openrc.patch | 12 ++---------- ...opendkim-2.10.3-r11.ebuild => opendkim-2.10.3-r12.ebuild} | 6 ++++++ 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/mail-filter/opendkim/files/opendkim-2.10.3-openrc.patch b/mail-filter/opendkim/files/opendkim-2.10.3-openrc.patch index 9033b84281c..9b645ba0f0c 100644 --- a/mail-filter/opendkim/files/opendkim-2.10.3-openrc.patch +++ b/mail-filter/opendkim/files/opendkim-2.10.3-openrc.patch @@ -119,17 +119,9 @@ index 76df01cd..401130bb 100644 +SUBDIRS = convert docs init ldap lua patches repute spec stats dist_doc_DATA = README -diff --git a/contrib/OpenRC/.gitignore b/contrib/OpenRC/.gitignore -new file mode 100644 -index 00000000..af0aa700 ---- /dev/null -+++ b/contrib/OpenRC/.gitignore -@@ -0,0 +1,2 @@ -+opendkim.openrc -+opendkim.openrc.in diff --git a/contrib/OpenRC/opendkim.openrc.in.in b/contrib/OpenRC/opendkim.openrc.in.in new file mode 100644 -index 00000000..d9631cdf +index 00000000..4b783615 --- /dev/null +++ b/contrib/OpenRC/opendkim.openrc.in.in @@ -0,0 +1,54 @@ @@ -137,7 +129,7 @@ index 00000000..d9631cdf +# Copyright 1999-2019 Gentoo Authors +# Distributed under the terms of the GNU General Public License v2 + -+CONFFILE="@SYSCONFDIR@/opendkim/${RC_SVCNAME}.conf" ++CONFFILE="@SYSCONFDIR@/${RC_SVCNAME}.conf" +required_files="${CONFFILE}" + +command="@SBINDIR@/opendkim" diff --git a/mail-filter/opendkim/opendkim-2.10.3-r11.ebuild b/mail-filter/opendkim/opendkim-2.10.3-r12.ebuild similarity index 96% rename from mail-filter/opendkim/opendkim-2.10.3-r11.ebuild rename to mail-filter/opendkim/opendkim-2.10.3-r12.ebuild index 0db960be3c6..ee5908da59c 100644 --- a/mail-filter/opendkim/opendkim-2.10.3-r11.ebuild +++ b/mail-filter/opendkim/opendkim-2.10.3-r12.ebuild @@ -80,6 +80,12 @@ src_configure() { if use ldap; then myconf+=( $(use_with sasl) ) fi + + # We install the our configuration filed under e.g. /etc/opendkim, + # so the next line is necessary to point the daemon and all of its + # documentation to the right location by default. + myconf+=( --sysconfdir="${EPREFIX}/etc/${PN}" ) + econf \ $(use_with berkdb db) \ $(use_with opendbx odbx) \