public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/netifrc:master commit in: init.d/
Date: Sun, 21 Apr 2019 05:34:02 +0000 (UTC)	[thread overview]
Message-ID: <1555824666.d2d52cd821372c65b92d262da66a30794735204c.robbat2@OpenRC> (raw)

commit:     d2d52cd821372c65b92d262da66a30794735204c
Author:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
AuthorDate: Sun Apr 21 05:21:51 2019 +0000
Commit:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
CommitDate: Sun Apr 21 05:31:06 2019 +0000
URL:        https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=d2d52cd8

init.d/net.lo.in: shellcheck: disable some false positives

Signed-off-by: Robin H. Johnson <robbat2 <AT> gentoo.org>

 init.d/net.lo.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/init.d/net.lo.in b/init.d/net.lo.in
index d9a4d24..1e5de3c 100644
--- a/init.d/net.lo.in
+++ b/init.d/net.lo.in
@@ -83,6 +83,7 @@ _get_array()
 {
 	local _a=
 	if [ -n "${BASH}" ]; then
+		# shellcheck disable=SC2039
 		case "$(declare -p "$1" 2>/dev/null)" in
 			"declare -a "*)
 				ewarn "You are using a bash array for $1."
@@ -104,6 +105,7 @@ _get_array()
 _flatten_array()
 {
 	if [ -n "${BASH}" ]; then
+		# shellcheck disable=SC2039
 		case "$(declare -p "$1" 2>/dev/null)" in
 			"declare -a "*)
 				ewarn "You are using a bash array for $1."
@@ -111,6 +113,7 @@ _flatten_array()
 				ewarn "Please see net.example for the correct format for $1."
 				eval "set -- \"\${$1[@]}\""
 				for x; do
+					# shellcheck disable=SC2059
 					printf "'%s' " "$(printf "$x" | sed "s:':'\\\'':g")"
 				done
 				return 0
@@ -194,6 +197,7 @@ _netmask2cidr()
 			quad=${quad}${quad:+.}0x${hex%${lastbut2}*}
 			hex=${lastbut2}
 		done
+		# shellcheck disable=SC2086
 		set -- ${quad}
 		;;
 	esac
@@ -427,6 +431,7 @@ _load_modules()
 	MODULES=
 	if [ "${IFACE}" != "lo" -a "${IFACE}" != "lo0" ]; then
 		eval mymods=\$modules_${IFVAR}
+		# shellcheck disable=SC2154
 		[ -z "${mymods}" ] && mymods=${modules}
 	fi
 
@@ -627,6 +632,7 @@ start()
 	local IFVAR=$(shell_var "${IFACE}") cmd= our_metric=
 	local metric=0 _up_before_preup
 	eval _up_before_preup="\$up_before_preup_${IFVAR}"
+	# shellcheck disable=SC2154
 	[ -z "${_up_before_preup}" ] && _up_before_preup=$up_before_preup
 
 	einfo "Bringing up interface ${IFACE}"


             reply	other threads:[~2019-04-21  5:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21  5:34 Robin H. Johnson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-01-07  9:42 [gentoo-commits] proj/netifrc:master commit in: init.d/ Sam James
2021-03-31  1:11 Patrick McLean
2020-09-07 13:03 Lars Wendler
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2017-11-14 20:48 Robin H. Johnson
2017-11-14 20:48 Robin H. Johnson
2016-10-24 20:52 Robin H. Johnson
2016-10-24  0:23 Robin H. Johnson
2016-10-24  0:23 Robin H. Johnson
2016-10-23 23:50 Robin H. Johnson
2016-07-05 18:13 Robin H. Johnson
2015-11-08 14:30 Robin H. Johnson
2015-11-08 14:30 Robin H. Johnson
2015-05-25 10:04 Mike Frysinger
2015-05-25 10:01 Mike Frysinger
2015-01-09 17:17 Robin H. Johnson
2014-10-11 19:47 Robin H. Johnson
2014-07-17 17:56 Robin H. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1555824666.d2d52cd821372c65b92d262da66a30794735204c.robbat2@OpenRC \
    --to=robbat2@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox