From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 6C95A138334 for ; Tue, 9 Apr 2019 02:09:03 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 60B46E091B; Tue, 9 Apr 2019 02:09:02 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 23594E091B for ; Tue, 9 Apr 2019 02:09:01 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 6CE4C335C07 for ; Tue, 9 Apr 2019 02:09:00 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 01FAD5C1 for ; Tue, 9 Apr 2019 02:08:58 +0000 (UTC) From: "Göktürk Yüksek" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Göktürk Yüksek" Message-ID: <1554775691.988c0ffb4c868eb82efc0a37169b96c3548dbd5e.gokturk@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/playerctl/files/, media-sound/playerctl/ X-VCS-Repository: repo/gentoo X-VCS-Files: media-sound/playerctl/files/playerctl-gdbus-codegen-fix.patch media-sound/playerctl/playerctl-0.5.0.ebuild media-sound/playerctl/playerctl-0.6.0.ebuild X-VCS-Directories: media-sound/playerctl/files/ media-sound/playerctl/ X-VCS-Committer: gokturk X-VCS-Committer-Name: Göktürk Yüksek X-VCS-Revision: 988c0ffb4c868eb82efc0a37169b96c3548dbd5e X-VCS-Branch: master Date: Tue, 9 Apr 2019 02:08:58 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 3d483e83-9065-4f07-8609-57d71310f404 X-Archives-Hash: cf58ef552785edd42ecccdc8d638f864 commit: 988c0ffb4c868eb82efc0a37169b96c3548dbd5e Author: Göktürk Yüksek gentoo org> AuthorDate: Tue Apr 9 02:08:11 2019 +0000 Commit: Göktürk Yüksek gentoo org> CommitDate: Tue Apr 9 02:08:11 2019 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=988c0ffb media-sound/playerctl: fix gdbus-codegen handling in configure.ac In configure.ac, the **absolute** path of gdbus-codegen (as obtained by pkg-config) is passed to AC_PATH_PROG. The macro then appends this path to the directories in PATH and tests if the result is executable. This internally results in checking for '/usr/bin/usr/bin/gdbus-codegen'. The macro is redundant because the value returned by pkg-config is sufficient. Closes: https://bugs.gentoo.org/682788 Package-Manager: Portage-2.3.62, Repoman-2.3.12 Signed-off-by: Göktürk Yüksek gentoo.org> .../playerctl/files/playerctl-gdbus-codegen-fix.patch | 15 +++++++++++++++ media-sound/playerctl/playerctl-0.5.0.ebuild | 4 +++- media-sound/playerctl/playerctl-0.6.0.ebuild | 4 +++- 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/media-sound/playerctl/files/playerctl-gdbus-codegen-fix.patch b/media-sound/playerctl/files/playerctl-gdbus-codegen-fix.patch new file mode 100644 index 00000000000..06c073aa276 --- /dev/null +++ b/media-sound/playerctl/files/playerctl-gdbus-codegen-fix.patch @@ -0,0 +1,15 @@ +--- a/configure.ac ++++ b/configure.ac +@@ -21,10 +21,11 @@ + PKG_CHECK_MODULES([GOBJECT], [gobject-2.0 >= 2.38]) + PKG_CHECK_MODULES([GIO], [gio-unix-2.0]) + +-AC_PATH_PROG([GDBUS_CODEGEN], [`$PKG_CONFIG --variable=gdbus_codegen gio-2.0`]) ++GDBUS_CODEGEN=`$PKG_CONFIG --variable=gdbus_codegen gio-2.0` + if test -z "$GDBUS_CODEGEN"; then + AC_MSG_ERROR([*** gdbus-codegen is required to build playerctl]) + fi ++AC_SUBST(GDBUS_CODEGEN) + + # Checks for typedefs, structures, and compiler characteristics + AC_PROG_CC_STDC diff --git a/media-sound/playerctl/playerctl-0.5.0.ebuild b/media-sound/playerctl/playerctl-0.5.0.ebuild index a06816f38bd..0a05e650f20 100644 --- a/media-sound/playerctl/playerctl-0.5.0.ebuild +++ b/media-sound/playerctl/playerctl-0.5.0.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2017 Gentoo Foundation +# Copyright 1999-2019 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 EAPI=6 @@ -29,6 +29,8 @@ src_prepare() { echo 'EXTRA_DIST = ' > gtk-doc.make || die fi + eapply "${FILESDIR}"/"${PN}"-gdbus-codegen-fix.patch + default eautoreconf } diff --git a/media-sound/playerctl/playerctl-0.6.0.ebuild b/media-sound/playerctl/playerctl-0.6.0.ebuild index 8741ea6e29e..4effb5f74a6 100644 --- a/media-sound/playerctl/playerctl-0.6.0.ebuild +++ b/media-sound/playerctl/playerctl-0.6.0.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2018 Gentoo Foundation +# Copyright 1999-2019 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 EAPI=6 @@ -29,6 +29,8 @@ src_prepare() { echo 'EXTRA_DIST = ' > gtk-doc.make || die fi + eapply "${FILESDIR}"/"${PN}"-gdbus-codegen-fix.patch + default eautoreconf }