From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E67A7138335 for ; Sat, 9 Feb 2019 09:52:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 68E67E09B5; Sat, 9 Feb 2019 09:52:24 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 25A30E09B1 for ; Sat, 9 Feb 2019 09:52:22 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1C1C4335D76 for ; Sat, 9 Feb 2019 09:52:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 7363853D for ; Sat, 9 Feb 2019 09:52:19 +0000 (UTC) From: "Andreas Sturmlechner" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Andreas Sturmlechner" Message-ID: <1549705920.f1b70227b021d0f56aeb6b477dffafe00baaa588.asturm@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: kde-frameworks/kio/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: kde-frameworks/kio/files/kio-5.52.0-sendfile.patch X-VCS-Directories: kde-frameworks/kio/files/ X-VCS-Committer: asturm X-VCS-Committer-Name: Andreas Sturmlechner X-VCS-Revision: f1b70227b021d0f56aeb6b477dffafe00baaa588 X-VCS-Branch: master Date: Sat, 9 Feb 2019 09:52:19 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Archives-Salt: 142d9298-bf2f-41ed-9ec1-1b4b2f979b65 X-Archives-Hash: 74a85c1f35a4e8fdbf42dc7a35cdeedb commit: f1b70227b021d0f56aeb6b477dffafe00baaa588 Author: Michael Mair-Keimberger gmail com> AuthorDate: Fri Feb 8 16:00:49 2019 +0000 Commit: Andreas Sturmlechner gentoo org> CommitDate: Sat Feb 9 09:52:00 2019 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f1b70227 kde-frameworks/kio: remove unused patch(es) Signed-off-by: Michael Mair-Keimberger gmail.com> Signed-off-by: Andreas Sturmlechner gentoo.org> kde-frameworks/kio/files/kio-5.52.0-sendfile.patch | 109 --------------------- 1 file changed, 109 deletions(-) diff --git a/kde-frameworks/kio/files/kio-5.52.0-sendfile.patch b/kde-frameworks/kio/files/kio-5.52.0-sendfile.patch deleted file mode 100644 index d02b8f50b19..00000000000 --- a/kde-frameworks/kio/files/kio-5.52.0-sendfile.patch +++ /dev/null @@ -1,109 +0,0 @@ -From 31980ecd1cacac9bd75ce35e3048946e1c27e1a0 Mon Sep 17 00:00:00 2001 -From: David Edmundson -Date: Wed, 21 Nov 2018 15:30:48 +0000 -Subject: Restore sendfile support - -Summary: -Somehow in the kdelibs -> framework port the cmake checks for -HAVE_SENDFILE got lost. - -That re-enables a massive optimisation in the file kioslave that has all the code existing and used in kdelibs4 that we're currently missing. - -Test Plan: -Put a compilation fail inside the #ifdef, before it wasn't triggered, now it is. - -Ran unit tests -Moved a file in dolphin - -Reviewers: dfaure - -Reviewed By: dfaure - -Subscribers: ngraham, apol, kde-frameworks-devel - -Tags: #frameworks - -Differential Revision: https://phabricator.kde.org/D17048 ---- - src/ioslaves/file/ConfigureChecks.cmake | 1 + - src/ioslaves/file/config-kioslave-file.h.cmake | 2 ++ - src/ioslaves/file/file_unix.cpp | 2 +- - 3 files changed, 4 insertions(+), 1 deletion(-) - -diff --git a/src/ioslaves/file/ConfigureChecks.cmake b/src/ioslaves/file/ConfigureChecks.cmake -index 5a83d1b..39fcd6f 100644 ---- a/src/ioslaves/file/ConfigureChecks.cmake -+++ b/src/ioslaves/file/ConfigureChecks.cmake -@@ -7,6 +7,7 @@ include(CheckStructHasMember) - check_include_files(sys/time.h HAVE_SYS_TIME_H) - check_include_files(string.h HAVE_STRING_H) - check_include_files(limits.h HAVE_LIMITS_H) -+check_function_exists(sendfile HAVE_SENDFILE) - - check_function_exists(posix_fadvise HAVE_FADVISE) # kioslave - -diff --git a/src/ioslaves/file/config-kioslave-file.h.cmake b/src/ioslaves/file/config-kioslave-file.h.cmake -index e47fdb2..3df7ebd 100644 ---- a/src/ioslaves/file/config-kioslave-file.h.cmake -+++ b/src/ioslaves/file/config-kioslave-file.h.cmake -@@ -13,3 +13,5 @@ - /* Defined if system has extended file attributes support. */ - #cmakedefine01 HAVE_SYS_XATTR_H - -+/* Defined if system has the sendfile function. */ -+#cmakedefine01 HAVE_SENDFILE -diff --git a/src/ioslaves/file/file_unix.cpp b/src/ioslaves/file/file_unix.cpp -index 817cce8..34422e5 100644 ---- a/src/ioslaves/file/file_unix.cpp -+++ b/src/ioslaves/file/file_unix.cpp -@@ -49,7 +49,7 @@ - #include "fdreceiver.h" - - //sendfile has different semantics in different platforms --#if defined HAVE_SENDFILE && defined Q_OS_LINUX -+#if HAVE_SENDFILE && defined Q_OS_LINUX - #define USE_SENDFILE 1 - #endif - --- -cgit v0.11.2 -From 8f926e4596221b11e62c7ac80bb5864d3d8cf4f6 Mon Sep 17 00:00:00 2001 -From: David Edmundson -Date: Wed, 21 Nov 2018 15:30:53 +0000 -Subject: Use correct variable type for returned value from read/sendfile - -Summary: -n stores the read/transferred bytes. This returns a ssize_t. -We were casting to an int, which theoretically is a loss of data. - -In practice it isn't an issue as we only read a max of MAX_IPC_SIZE at a -time, which would fit in an int. - -Reviewers: apol - -Reviewed By: apol - -Subscribers: kde-frameworks-devel - -Tags: #frameworks - -Differential Revision: https://phabricator.kde.org/D17051 ---- - src/ioslaves/file/file_unix.cpp | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/src/ioslaves/file/file_unix.cpp b/src/ioslaves/file/file_unix.cpp -index 34422e5..7ed0ae8 100644 ---- a/src/ioslaves/file/file_unix.cpp -+++ b/src/ioslaves/file/file_unix.cpp -@@ -251,7 +251,7 @@ void FileProtocol::copy(const QUrl &srcUrl, const QUrl &destUrl, - - KIO::filesize_t processed_size = 0; - char buffer[ MAX_IPC_SIZE ]; -- int n; -+ ssize_t n = 0; - #ifdef USE_SENDFILE - bool use_sendfile = buff_src.st_size < 0x7FFFFFFF; - #endif --- -cgit v0.11.2