From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/package/ebuild/
Date: Mon, 19 Nov 2018 06:43:21 +0000 (UTC) [thread overview]
Message-ID: <1542609726.58eb01022e604b0a538b9d67bd64daa44da9f94a.zmedico@gentoo> (raw)
commit: 58eb01022e604b0a538b9d67bd64daa44da9f94a
Author: Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Mon Nov 19 06:38:21 2018 +0000
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Mon Nov 19 06:42:06 2018 +0000
URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=58eb0102
Revert "fetch: check DISTDIR write access as fetch user (bug 601252)"
This reverts commit 4264ac4b07c4555eb5db2ab21288dba05a7f4b6d.
Dropping privileges for the access call is not useful by itself,
since lock and unlink calls do not drop privileges yet. We might
decide to drop privileges for the entire fetch function call.
Bug: https://bugs.gentoo.org/601252
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>
lib/portage/package/ebuild/fetch.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/portage/package/ebuild/fetch.py b/lib/portage/package/ebuild/fetch.py
index 7ec7fe05e..0431e11ea 100644
--- a/lib/portage/package/ebuild/fetch.py
+++ b/lib/portage/package/ebuild/fetch.py
@@ -543,7 +543,7 @@ def fetch(myuris, mysettings, listonly=0, fetchonly=0,
if can_fetch and \
not fetch_to_ro and \
- _spawn_fetch(mysettings, ['test', '-w', mysettings["DISTDIR"]]) != os.EX_OK:
+ not os.access(mysettings["DISTDIR"], os.W_OK):
writemsg(_("!!! No write access to '%s'\n") % mysettings["DISTDIR"],
noiselevel=-1)
can_fetch = False
next reply other threads:[~2018-11-19 6:43 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 6:43 Zac Medico [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-06-24 1:09 [gentoo-commits] proj/portage:master commit in: lib/portage/package/ebuild/ Sam James
2025-01-11 23:10 Zac Medico
2024-08-07 14:39 Zac Medico
2024-07-19 5:41 Sam James
2024-06-17 0:25 Sam James
2024-06-17 0:20 Sam James
2024-03-24 22:20 Zac Medico
2023-12-20 14:04 Sam James
2023-12-20 14:04 Sam James
2023-12-20 14:04 Sam James
2023-12-10 22:01 Sam James
2023-10-22 22:46 Zac Medico
2023-10-16 5:15 Zac Medico
2023-10-13 10:33 Sam James
2023-10-13 10:19 Sam James
2023-10-13 10:19 Sam James
2023-08-19 15:05 Sam James
2023-06-14 19:23 Mike Gilbert
2023-06-14 19:23 Mike Gilbert
2023-02-17 0:53 Sam James
2023-01-27 8:38 Ulrich Müller
2023-01-02 20:45 Mike Gilbert
2022-07-12 23:33 Sam James
2022-06-12 18:25 Sam James
2021-12-11 2:54 Sam James
2021-12-11 2:54 Sam James
2021-11-15 8:34 Michał Górny
2021-11-08 22:37 Zac Medico
2021-10-28 5:00 Sam James
2021-10-28 4:52 Sam James
2021-10-03 19:31 Zac Medico
2021-09-28 11:25 Michał Górny
2021-09-28 11:19 Michał Górny
2021-09-28 7:21 Zac Medico
2021-09-27 20:51 Michał Górny
2021-09-08 10:17 Michał Górny
2021-08-05 8:47 Michał Górny
2021-06-20 18:54 Zac Medico
2021-06-05 18:08 Zac Medico
2021-06-05 18:08 Zac Medico
2021-05-31 19:54 Michał Górny
2021-05-24 5:25 Zac Medico
2021-02-25 9:33 Zac Medico
2021-02-24 15:14 Zac Medico
2021-02-22 5:32 Zac Medico
2021-01-17 13:15 Zac Medico
2021-01-10 3:24 Zac Medico
2020-11-02 1:34 Zac Medico
2020-09-14 7:23 Zac Medico
2020-08-03 21:42 Zac Medico
2020-08-03 21:42 Zac Medico
2020-08-03 19:30 Zac Medico
2020-08-03 19:30 Zac Medico
2020-08-03 19:30 Zac Medico
2020-05-31 23:58 Mike Gilbert
2020-05-31 21:17 Mike Gilbert
2020-05-31 20:34 Mike Gilbert
2020-05-18 19:23 Michał Górny
2020-05-06 6:37 Michał Górny
2020-03-23 1:49 Zac Medico
2020-03-23 1:40 Zac Medico
2020-03-15 1:24 Zac Medico
2020-03-02 16:53 Zac Medico
2020-03-02 4:48 Zac Medico
2020-02-15 20:44 Zac Medico
2020-02-15 20:28 Zac Medico
2019-12-09 7:03 Zac Medico
2019-10-29 1:17 Zac Medico
2019-10-24 19:31 Zac Medico
2019-10-21 17:49 Zac Medico
2019-10-20 9:26 Michał Górny
2019-10-19 23:52 Zac Medico
2019-10-14 20:45 Zac Medico
2019-10-14 20:35 Zac Medico
2019-10-14 20:13 Zac Medico
2019-10-13 19:50 Michał Górny
2019-09-03 15:36 Zac Medico
2019-09-02 20:13 Zac Medico
2019-08-20 23:43 Zac Medico
2019-08-14 1:40 Zac Medico
2019-07-30 7:09 Ulrich Müller
2019-06-18 17:14 Zac Medico
2019-06-10 19:01 Zac Medico
2019-01-21 22:20 Zac Medico
2019-01-01 20:58 Zac Medico
2018-12-20 4:29 Zac Medico
2018-12-07 0:41 Zac Medico
2018-11-09 3:22 Zac Medico
2018-10-10 7:58 Zac Medico
2018-10-08 21:41 Zac Medico
2018-08-20 23:11 Zac Medico
2018-08-17 22:35 Zac Medico
2018-08-12 2:31 Zac Medico
2018-08-11 21:06 Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542609726.58eb01022e604b0a538b9d67bd64daa44da9f94a.zmedico@gentoo \
--to=zmedico@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox