From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5B606138335 for ; Sat, 28 Jul 2018 06:13:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 2C1AEE085A; Sat, 28 Jul 2018 06:13:03 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 6FE9DE0864 for ; Sat, 28 Jul 2018 06:13:02 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 1F8CE335CC7 for ; Sat, 28 Jul 2018 06:13:00 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id EA5F4380 for ; Sat, 28 Jul 2018 06:12:57 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1532707706.ef01e3d9373cb64320df290494c13e3f2cf6a0c0.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/emerge-webrsync X-VCS-Directories: bin/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: ef01e3d9373cb64320df290494c13e3f2cf6a0c0 X-VCS-Branch: master Date: Sat, 28 Jul 2018 06:12:57 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 36f7bf90-9488-459a-bff8-51d08b221df7 X-Archives-Hash: 9f8220e57deea03d23134ceb57e98cff commit: ef01e3d9373cb64320df290494c13e3f2cf6a0c0 Author: Zac Medico gentoo org> AuthorDate: Mon Jul 23 04:26:25 2018 +0000 Commit: Zac Medico gentoo org> CommitDate: Fri Jul 27 16:08:26 2018 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=ef01e3d9 emerge-webrsync: exit early for signature problem (bug 661838) Exit early after signature verification failure, since it's typically inappropriate to try other mirrors in this case (it may indicate a keyring problem). Bug: https://bugs.gentoo.org/661838 Reviewed-by: Brian Dolbec gentoo.org> bin/emerge-webrsync | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/bin/emerge-webrsync b/bin/emerge-webrsync index 560dd0236..b135567b7 100755 --- a/bin/emerge-webrsync +++ b/bin/emerge-webrsync @@ -191,6 +191,13 @@ check_file_signature() { fi done <<< "${gnupg_status}" fi + if [[ ${r} -ne 0 ]]; then + # Exit early since it's typically inappropriate to + # try other mirrors in this case (it may indicate + # a keyring problem). + eecho "signature verification failed" + exit 1 + fi else eecho "cannot check signature: gpg binary not found" exit 1