public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: lib/portage/sync/modules/git/
Date: Mon, 23 Jul 2018 18:52:42 +0000 (UTC)	[thread overview]
Message-ID: <1532371862.dc1ba7729c42cbe738ae7ec34e2f13f79c48d41c.zmedico@gentoo> (raw)

commit:     dc1ba7729c42cbe738ae7ec34e2f13f79c48d41c
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Mon Jul 23 18:46:08 2018 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Mon Jul 23 18:51:02 2018 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=dc1ba772

git: fix key refresh failure to trigger abort (bug 661906)

Fix the verify_head method to appropriately return a bool
value instead of a tuple.

Fixes: d30191b887bb ("git: Support running the verification against sync-openpgp-key-path")
Bug: https://bugs.gentoo.org/661906

 lib/portage/sync/modules/git/git.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/portage/sync/modules/git/git.py b/lib/portage/sync/modules/git/git.py
index 2fb82c600..33f71b510 100644
--- a/lib/portage/sync/modules/git/git.py
+++ b/lib/portage/sync/modules/git/git.py
@@ -227,7 +227,7 @@ class GitSync(NewBase):
 					writemsg_level("!!! Verification impossible due to keyring problem:\n%s\n"
 							% (e,),
 							level=logging.ERROR, noiselevel=-1)
-					return (1, False)
+					False
 
 				env = os.environ.copy()
 				env['GNUPGHOME'] = openpgp_env.home


             reply	other threads:[~2018-07-23 18:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 18:52 Zac Medico [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-07-23 19:58 [gentoo-commits] proj/portage:master commit in: lib/portage/sync/modules/git/ Zac Medico
2020-07-02 22:08 Zac Medico
2022-07-03  0:56 Mike Gilbert
2022-11-20  3:12 Sam James
2022-12-21  1:28 Sam James
2022-12-21  1:28 Sam James
2022-12-21  1:28 Sam James
2023-02-24  9:22 Sam James
2023-02-24  9:22 Sam James
2023-02-24  9:22 Sam James
2023-02-25 23:22 Sam James
2023-02-27  6:15 Sam James
2023-08-17  6:53 Sam James
2023-08-17  6:59 Sam James
2023-10-22 19:03 Sam James
2023-10-22 19:03 Sam James
2023-10-22 19:03 Sam James
2023-10-31  0:35 Sam James
2023-12-14  4:30 Sam James
2024-05-12 16:20 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1532371862.dc1ba7729c42cbe738ae7ec34e2f13f79c48d41c.zmedico@gentoo \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox