From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id ED042138331 for ; Sun, 22 Apr 2018 12:00:49 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8DF1AE0905; Sun, 22 Apr 2018 12:00:48 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 69420E0901 for ; Sun, 22 Apr 2018 12:00:48 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 2F186335C7B for ; Sun, 22 Apr 2018 12:00:47 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 40680299 for ; Sun, 22 Apr 2018 12:00:44 +0000 (UTC) From: "Jason Zaman" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Jason Zaman" Message-ID: <1524397983.22db9ffa981508adc52f3751fb285cce44f98c29.perfinion@gentoo> Subject: [gentoo-commits] proj/hardened-refpolicy:master commit in: policy/modules/contrib/ X-VCS-Repository: proj/hardened-refpolicy X-VCS-Files: policy/modules/contrib/shorewall.if X-VCS-Directories: policy/modules/contrib/ X-VCS-Committer: perfinion X-VCS-Committer-Name: Jason Zaman X-VCS-Revision: 22db9ffa981508adc52f3751fb285cce44f98c29 X-VCS-Branch: master Date: Sun, 22 Apr 2018 12:00:44 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 35a6b1d7-7ffb-436d-9673-7ddf134f95c7 X-Archives-Hash: 4d255952c95f8c86457487f9d3f72cb1 commit: 22db9ffa981508adc52f3751fb285cce44f98c29 Author: James Carter tycho nsa gov> AuthorDate: Wed Apr 11 18:56:38 2018 +0000 Commit: Jason Zaman gentoo org> CommitDate: Sun Apr 22 11:53:03 2018 +0000 URL: https://gitweb.gentoo.org/proj/hardened-refpolicy.git/commit/?id=22db9ffa Remove undeclared identifiers from shorewall interfaces Both shorewall_read_pid_files() and shorewall_rw_pid_files() use the undeclared type shorewall_var_run_t. Removed statements referring to this type and marked the interfaces as deprecated because they no longer do anything useful. Neither interface is called in the policy. Signed-off-by: James Carter tycho.nsa.gov> policy/modules/contrib/shorewall.if | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/policy/modules/contrib/shorewall.if b/policy/modules/contrib/shorewall.if index 108ce759..119ba279 100644 --- a/policy/modules/contrib/shorewall.if +++ b/policy/modules/contrib/shorewall.if @@ -62,38 +62,28 @@ interface(`shorewall_read_config',` ## ## Read shorewall pid files. ## -## +## ## ## Domain allowed access. ## ## # interface(`shorewall_read_pid_files',` - gen_require(` - type shorewall_var_run_t; - ') - - files_search_pids($1) - read_files_pattern($1, shorewall_var_run_t, shorewall_var_run_t) + refpolicywarn(`$0($*) has been deprecated') ') ####################################### ## ## Read and write shorewall pid files. ## -## +## ## ## Domain allowed access. ## ## # interface(`shorewall_rw_pid_files',` - gen_require(` - type shorewall_var_run_t; - ') - - files_search_pids($1) - rw_files_pattern($1, shorewall_var_run_t, shorewall_var_run_t) + refpolicywarn(`$0($*) has been deprecated') ') ######################################