public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "David Seifert" <soap@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-cdr/isomaster/
Date: Fri, 20 Apr 2018 19:48:05 +0000 (UTC)	[thread overview]
Message-ID: <1524253624.c2b3809431f35e909af36a0cf5791fdab744b06c.soap@gentoo> (raw)

commit:     c2b3809431f35e909af36a0cf5791fdab744b06c
Author:     Marty E. Plummer <hanetzer <AT> startmail <DOT> com>
AuthorDate: Sun Apr  8 11:30:34 2018 +0000
Commit:     David Seifert <soap <AT> gentoo <DOT> org>
CommitDate: Fri Apr 20 19:47:04 2018 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c2b38094

app-cdr/isomaster: just rm dummy configure script

Purely stylistic, but having a no-op src_configure defined when you can
just rm the offending configure 'script' in src_prepare just looks ugly.

Package-Manager: Portage-2.3.28, Repoman-2.3.9

 app-cdr/isomaster/isomaster-1.3.13.ebuild | 3 +--
 app-cdr/isomaster/isomaster-1.3.14.ebuild | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/app-cdr/isomaster/isomaster-1.3.13.ebuild b/app-cdr/isomaster/isomaster-1.3.13.ebuild
index e2f7f7daa10..5497413a82d 100644
--- a/app-cdr/isomaster/isomaster-1.3.13.ebuild
+++ b/app-cdr/isomaster/isomaster-1.3.13.ebuild
@@ -37,11 +37,10 @@ pkg_setup() {
 
 src_prepare() {
 	default
+	rm -f configure || die #274361
 	rm -R iniparser-2.17 || die
 }
 
-src_configure() { :; } #274361
-
 src_compile() {
 	tc-export CC
 	emake "${myisoconf[@]}"

diff --git a/app-cdr/isomaster/isomaster-1.3.14.ebuild b/app-cdr/isomaster/isomaster-1.3.14.ebuild
index 6a00360b44f..8dd88dcd9ad 100644
--- a/app-cdr/isomaster/isomaster-1.3.14.ebuild
+++ b/app-cdr/isomaster/isomaster-1.3.14.ebuild
@@ -34,11 +34,10 @@ pkg_setup() {
 
 src_prepare() {
 	default
+	rm -f configure || die #274361
 	rm -R iniparser-4.1 || die
 }
 
-src_configure() { :; } #274361
-
 src_compile() {
 	tc-export CC
 	emake "${myisoconf[@]}"


             reply	other threads:[~2018-04-20 19:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 19:48 David Seifert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-10-09  2:53 [gentoo-commits] repo/gentoo:master commit in: app-cdr/isomaster/ Jakov Smolić
2024-10-09  2:53 Jakov Smolić
2024-06-08 22:18 Sebastian Pipping
2022-01-17  8:31 Jakov Smolić
2022-01-16 17:26 Jakov Smolić
2021-02-16 17:32 Sebastian Pipping
2020-09-05  1:18 Sam James
2020-08-31 20:44 Thomas Deutschmann
2020-03-25 19:44 Sebastian Pipping
2018-04-20 19:48 David Seifert
2018-04-20 19:48 David Seifert
2018-04-20 19:48 David Seifert
2018-03-28 14:44 Sebastian Pipping
2018-03-04 10:19 Jason Zaman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524253624.c2b3809431f35e909af36a0cf5791fdab744b06c.soap@gentoo \
    --to=soap@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox