public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-commits] proj/portage-utils:master commit in: tests/atom_compare/
@ 2018-04-05 13:31 Fabian Groffen
  0 siblings, 0 replies; 3+ messages in thread
From: Fabian Groffen @ 2018-04-05 13:31 UTC (permalink / raw
  To: gentoo-commits

commit:     5fc7da2079b2e04b5a0dd66e57ff9545ab54069d
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Thu Apr  5 13:27:30 2018 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Thu Apr  5 13:27:30 2018 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=5fc7da20

tests/atom_compare/Makefile: fail when there are differences

The static tests fell off the radar because actual differences did not
result in failure (e.g. Travis being green and all), also the sed magic
was too loose, causing a wrong input file to be computed

 tests/atom_compare/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/atom_compare/Makefile b/tests/atom_compare/Makefile
index 71a980f..ead9d75 100644
--- a/tests/atom_compare/Makefile
+++ b/tests/atom_compare/Makefile
@@ -8,7 +8,7 @@ test check: static static.q portage
 t = \
 	@set -f && \
 	$(call mkdir,$(b)) && \
-	good=`echo $< | sed 's:.tests:.good:'`; \
+	good=`echo $< | sed 's:.tests$$:.good:'`; \
 	out=$(@:.tests=); \
 	ret=0; \
 	$(realpath $(lastword $^)) $(1) `sed 's:\#.*::' $<` > $$out || ret=$$?; \
@@ -18,6 +18,7 @@ t = \
 			echo "PASS atom_compare $$out"; \
 		else \
 			echo "FAIL atom_compare $$out"; \
+			ret=1; \
 		fi;; \
 	77) echo "SKIP atom_compare $$out"; ret=0;; \
 	*) echo "FAIL atom_compare $$out";; \


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [gentoo-commits] proj/portage-utils:master commit in: tests/atom_compare/
@ 2021-02-27 11:32 Fabian Groffen
  0 siblings, 0 replies; 3+ messages in thread
From: Fabian Groffen @ 2021-02-27 11:32 UTC (permalink / raw
  To: gentoo-commits

commit:     f34b76d4ad4097f249cd160c8fd15647e7c1e2fc
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Sat Feb 27 11:31:17 2021 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Sat Feb 27 11:31:17 2021 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=f34b76d4

tests/atom_compare: drop portage test

We have no real need to test what Portage's doing here, and dropping the
test means we're Python and Portage free.

Bug: https://bugs.gentoo.org/772983
Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 tests/atom_compare/Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/atom_compare/Makefile.am b/tests/atom_compare/Makefile.am
index 388fd19..cd27e36 100644
--- a/tests/atom_compare/Makefile.am
+++ b/tests/atom_compare/Makefile.am
@@ -4,7 +4,7 @@ s = $(abs_top_srcdir)/$(this_subdir)
 atb = $(abs_top_builddir)
 mkdir = $(if $(wildcard $(dir $(1))),:,mkdir -p "$(dir $(1))")
 
-check-local: static static.q portage
+check-local: static static.q
 
 t = \
 	@set -f && \


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [gentoo-commits] proj/portage-utils:master commit in: tests/atom_compare/
@ 2021-03-13 12:44 Fabian Groffen
  0 siblings, 0 replies; 3+ messages in thread
From: Fabian Groffen @ 2021-03-13 12:44 UTC (permalink / raw
  To: gentoo-commits

commit:     d3975af1ff58208d45feb0ef040fcf04dbbceba9
Author:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
AuthorDate: Sat Mar 13 12:42:29 2021 +0000
Commit:     Fabian Groffen <grobian <AT> gentoo <DOT> org>
CommitDate: Sat Mar 13 12:42:29 2021 +0000
URL:        https://gitweb.gentoo.org/proj/portage-utils.git/commit/?id=d3975af1

buildsys: regen

Signed-off-by: Fabian Groffen <grobian <AT> gentoo.org>

 tests/atom_compare/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/atom_compare/Makefile.in b/tests/atom_compare/Makefile.in
index 9b0a4c8..9b031fd 100644
--- a/tests/atom_compare/Makefile.in
+++ b/tests/atom_compare/Makefile.in
@@ -1617,7 +1617,7 @@ uninstall-am:
 .PRECIOUS: Makefile
 
 
-check-local: static static.q portage
+check-local: static static.q
 
 static: $(s)/static.tests $(atb)/q
 	$(call t,atom -c)


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-13 12:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-05 13:31 [gentoo-commits] proj/portage-utils:master commit in: tests/atom_compare/ Fabian Groffen
  -- strict thread matches above, loose matches on Subject: below --
2021-02-27 11:32 Fabian Groffen
2021-03-13 12:44 Fabian Groffen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox