From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 25C7D1382C5 for ; Thu, 29 Mar 2018 21:35:09 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 71A2EE09A4; Thu, 29 Mar 2018 21:35:05 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 381CDE09A4 for ; Thu, 29 Mar 2018 21:35:05 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E86F5335D25 for ; Thu, 29 Mar 2018 21:35:03 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 16EB4276 for ; Thu, 29 Mar 2018 21:35:01 +0000 (UTC) From: "Brian Dolbec" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" Message-ID: <1522356219.588d47fd91ed5637d6a641d1e2ef39b80b5780f8.dolsen@gentoo> Subject: [gentoo-commits] proj/portage:repoman commit in: repoman/pym/repoman/modules/linechecks/useless/ X-VCS-Repository: proj/portage X-VCS-Files: repoman/pym/repoman/modules/linechecks/useless/__init__.py repoman/pym/repoman/modules/linechecks/useless/cd.py repoman/pym/repoman/modules/linechecks/useless/dodoc.py X-VCS-Directories: repoman/pym/repoman/modules/linechecks/useless/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: 588d47fd91ed5637d6a641d1e2ef39b80b5780f8 X-VCS-Branch: repoman Date: Thu, 29 Mar 2018 21:35:01 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 86e69525-8465-4ced-bdce-6f68f51b5967 X-Archives-Hash: 85b22f7b001ddbb78288fe00c8ae1b4d commit: 588d47fd91ed5637d6a641d1e2ef39b80b5780f8 Author: Brian Dolbec gentoo org> AuthorDate: Sat Jul 15 01:06:38 2017 +0000 Commit: Brian Dolbec gentoo org> CommitDate: Thu Mar 29 20:43:39 2018 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=588d47fd repoman: New linechecks module, useless .../repoman/modules/linechecks/useless/__init__.py | 27 ++++++++++++++++++++++ .../pym/repoman/modules/linechecks/useless/cd.py | 24 +++++++++++++++++++ .../repoman/modules/linechecks/useless/dodoc.py | 16 +++++++++++++ 3 files changed, 67 insertions(+) diff --git a/repoman/pym/repoman/modules/linechecks/useless/__init__.py b/repoman/pym/repoman/modules/linechecks/useless/__init__.py new file mode 100644 index 000000000..acc4479f5 --- /dev/null +++ b/repoman/pym/repoman/modules/linechecks/useless/__init__.py @@ -0,0 +1,27 @@ +# Copyright 2015-2016 Gentoo Foundation +# Distributed under the terms of the GNU General Public License v2 + +doc = """Useless plug-in module for repoman LineChecks. +Performs checks for useless operations on ebuilds.""" +__doc__ = doc[:] + + +module_spec = { + 'name': 'do', + 'description': doc, + 'provides':{ + 'uselesscds-check': { + 'name': "uselesscds", + 'sourcefile': "cd", + 'class': "EbuildUselessCdS", + 'description': doc, + }, + 'uselessdodoc-check': { + 'name': "uselessdodoc", + 'sourcefile': "dodoc", + 'class': "EbuildUselessDodoc", + 'description': doc, + }, + } +} + diff --git a/repoman/pym/repoman/modules/linechecks/useless/cd.py b/repoman/pym/repoman/modules/linechecks/useless/cd.py new file mode 100644 index 000000000..3daa04451 --- /dev/null +++ b/repoman/pym/repoman/modules/linechecks/useless/cd.py @@ -0,0 +1,24 @@ + +import re + +from repoman.modules.linechecks.base import LineCheck + + +class EbuildUselessCdS(LineCheck): + """Check for redundant cd ${S} statements""" + repoman_check_name = 'ebuild.minorsyn' + _src_phases = r'^\s*src_(prepare|configure|compile|install|test)\s*\(\)' + method_re = re.compile(_src_phases) + cds_re = re.compile(r'^\s*cd\s+("\$(\{S\}|S)"|\$(\{S\}|S))\s') + + def __init__(self, errors): + self.errors = errors + self.check_next_line = False + + def check(self, num, line): + if self.check_next_line: + self.check_next_line = False + if self.cds_re.match(line): + return self.errors['REDUNDANT_CD_S_ERROR'] + elif self.method_re.match(line): + self.check_next_line = True diff --git a/repoman/pym/repoman/modules/linechecks/useless/dodoc.py b/repoman/pym/repoman/modules/linechecks/useless/dodoc.py new file mode 100644 index 000000000..502bfbea8 --- /dev/null +++ b/repoman/pym/repoman/modules/linechecks/useless/dodoc.py @@ -0,0 +1,16 @@ + +import re + +from repoman.modules.linechecks.base import LineCheck + + +class EbuildUselessDodoc(LineCheck): + """Check ebuild for useless files in dodoc arguments.""" + repoman_check_name = 'ebuild.minorsyn' + uselessdodoc_re = re.compile( + r'^\s*dodoc(\s+|\s+.*\s+)(ABOUT-NLS|COPYING|LICENCE|LICENSE)($|\s)') + + def check(self, num, line): + match = self.uselessdodoc_re.match(line) + if match: + return "Useless dodoc '%s'" % (match.group(2), ) + " on line: %d"