From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 808551382C5 for ; Wed, 14 Mar 2018 21:08:12 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 7DCF5E0802; Wed, 14 Mar 2018 21:08:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4F97AE0802 for ; Wed, 14 Mar 2018 21:08:09 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 65830335C8F for ; Wed, 14 Mar 2018 21:08:07 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 8B51F1F1 for ; Wed, 14 Mar 2018 21:08:05 +0000 (UTC) From: "Mike Gilbert" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Mike Gilbert" Message-ID: <1521061682.80ed7e534b05809a0ab3dc4a6d69bec4b98f02d0.floppym@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-misc/freerdp/, net-misc/freerdp/files/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-misc/freerdp/files/2.0.0-rc1-CredSSP-protocol-version.patch net-misc/freerdp/freerdp-2.0.0_rc1-r1.ebuild net-misc/freerdp/freerdp-2.0.0_rc1.ebuild X-VCS-Directories: net-misc/freerdp/ net-misc/freerdp/files/ X-VCS-Committer: floppym X-VCS-Committer-Name: Mike Gilbert X-VCS-Revision: 80ed7e534b05809a0ab3dc4a6d69bec4b98f02d0 X-VCS-Branch: master Date: Wed, 14 Mar 2018 21:08:05 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 9f45ce82-6c1d-48e2-b337-1b2d4a864587 X-Archives-Hash: 6e8da57a3f71e06fb00866f19ae9e840 commit: 80ed7e534b05809a0ab3dc4a6d69bec4b98f02d0 Author: Mike Gilbert gentoo org> AuthorDate: Wed Mar 14 21:06:52 2018 +0000 Commit: Mike Gilbert gentoo org> CommitDate: Wed Mar 14 21:08:02 2018 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=80ed7e53 net-misc/freerdp: backport CredSSP protocol version fix Package-Manager: Portage-2.3.24, Repoman-2.3.6_p81 .../files/2.0.0-rc1-CredSSP-protocol-version.patch | 49 ++++++++++++++++++++++ ....0.0_rc1.ebuild => freerdp-2.0.0_rc1-r1.ebuild} | 3 +- 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/net-misc/freerdp/files/2.0.0-rc1-CredSSP-protocol-version.patch b/net-misc/freerdp/files/2.0.0-rc1-CredSSP-protocol-version.patch new file mode 100644 index 00000000000..59887f698ec --- /dev/null +++ b/net-misc/freerdp/files/2.0.0-rc1-CredSSP-protocol-version.patch @@ -0,0 +1,49 @@ +From 088c3940d9b488e8a83b9cefaa7271f955d1971c Mon Sep 17 00:00:00 2001 +From: Bernhard Miklautz +Date: Wed, 14 Mar 2018 13:39:23 +0100 +Subject: [PATCH] fix nla: don't use server version + +FreeRDP currently only supports CredSSP protocol version 3. However the +current implementation always sent back the version received by the +server indicating that this version was supported. +With recent windows updates applied the protocol changed and this approach +doesn't work anymore (see +https://msdn.microsoft.com/en-us/library/mt752485.aspx for protocol changes). + +With this fix FreeRDP always sends version 3 as supported version. + +Credit goes to @mfleisz. + +Fixes #4449 +--- + libfreerdp/core/nla.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/libfreerdp/core/nla.c b/libfreerdp/core/nla.c +index 47e087062..8a69f2f6e 100644 +--- a/libfreerdp/core/nla.c ++++ b/libfreerdp/core/nla.c +@@ -1663,15 +1663,19 @@ BOOL nla_send(rdpNla* nla) + static int nla_decode_ts_request(rdpNla* nla, wStream* s) + { + int length; ++ UINT32 version = 0; + + /* TSRequest */ + if (!ber_read_sequence_tag(s, &length) || + !ber_read_contextual_tag(s, 0, &length, TRUE) || +- !ber_read_integer(s, &nla->version)) ++ !ber_read_integer(s, &version)) + { + return -1; + } + ++ if (version < nla->version) ++ nla->version = version; ++ + /* [1] negoTokens (NegoData) */ + if (ber_read_contextual_tag(s, 1, &length, TRUE) != FALSE) + { +-- +2.16.2 + diff --git a/net-misc/freerdp/freerdp-2.0.0_rc1.ebuild b/net-misc/freerdp/freerdp-2.0.0_rc1-r1.ebuild similarity index 96% rename from net-misc/freerdp/freerdp-2.0.0_rc1.ebuild rename to net-misc/freerdp/freerdp-2.0.0_rc1-r1.ebuild index c8a6ae3b610..6a24709e340 100644 --- a/net-misc/freerdp/freerdp-2.0.0_rc1.ebuild +++ b/net-misc/freerdp/freerdp-2.0.0_rc1-r1.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2017 Gentoo Foundation +# Copyright 1999-2018 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 EAPI="6" @@ -90,6 +90,7 @@ DEPEND="${RDEPEND} PATCHES=( "${FILESDIR}/2.0.0-rc1-libressl.patch" + "${FILESDIR}/2.0.0-rc1-CredSSP-protocol-version.patch" ) src_configure() {