From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 041621382C5 for ; Wed, 7 Feb 2018 05:24:51 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1F9BBE0AFF; Wed, 7 Feb 2018 05:24:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id EDF60E0AFF for ; Wed, 7 Feb 2018 05:24:50 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 97306335C2C for ; Wed, 7 Feb 2018 05:24:48 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id B4FE91DB for ; Wed, 7 Feb 2018 05:24:46 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1517981064.4a0a949d601969c672d9cf70ef8cf8682553f787.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/ X-VCS-Repository: proj/portage X-VCS-Files: bin/phase-functions.sh X-VCS-Directories: bin/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 4a0a949d601969c672d9cf70ef8cf8682553f787 X-VCS-Branch: master Date: Wed, 7 Feb 2018 05:24:46 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 2a145402-46e9-4ab0-aede-a36b9a69c2c1 X-Archives-Hash: 5af9fd6d3e65a63ab34a2b27ddeccd7d commit: 4a0a949d601969c672d9cf70ef8cf8682553f787 Author: Zac Medico gentoo org> AuthorDate: Wed Feb 7 05:22:29 2018 +0000 Commit: Zac Medico gentoo org> CommitDate: Wed Feb 7 05:24:24 2018 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=4a0a949d phase-functions.sh: suppress shellcheck SC1087 Adding braces to ${x} suppresses the following shellcheck error: SC1087: Braces are required when expanding arrays, as in ${array[idx]}. Reported-by: R0b0t1 gmail.com> bin/phase-functions.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/phase-functions.sh b/bin/phase-functions.sh index 10d54ca74..0ffabd99e 100644 --- a/bin/phase-functions.sh +++ b/bin/phase-functions.sh @@ -541,9 +541,9 @@ __dyn_install() { # fnmatch patterns to regular expressions for x in QA_DT_NEEDED QA_FLAGS_IGNORED QA_PRESTRIPPED QA_SONAME ; do if [[ $(declare -p $x 2>/dev/null) = declare\ -a* ]] ; then - eval "$x=(\"\${$x[@]}\" ${QA_PREBUILT//\*/.*})" + eval "${x}=(\"\${${x}[@]}\" ${QA_PREBUILT//\*/.*})" else - eval "$x+=\" ${QA_PREBUILT//\*/.*}\"" + eval "${x}+=\" ${QA_PREBUILT//\*/.*}\"" fi done