From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DE896139083 for ; Tue, 5 Dec 2017 18:32:14 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id EE34CE1070; Tue, 5 Dec 2017 18:32:11 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id BD1E8E1050 for ; Tue, 5 Dec 2017 18:32:11 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 9B1AB33BF0B for ; Tue, 5 Dec 2017 18:32:09 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id F07C3AE79 for ; Tue, 5 Dec 2017 18:32:06 +0000 (UTC) From: "Brian Dolbec" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Brian Dolbec" Message-ID: <1512498288.9d15953ea3e4d59dd17d286066df5f9945c0af19.dolsen@gentoo> Subject: [gentoo-commits] proj/portage:repoman commit in: repoman/pym/repoman/modules/linechecks/phases/ X-VCS-Repository: proj/portage X-VCS-Files: repoman/pym/repoman/modules/linechecks/phases/__init__.py repoman/pym/repoman/modules/linechecks/phases/phase.py X-VCS-Directories: repoman/pym/repoman/modules/linechecks/phases/ X-VCS-Committer: dolsen X-VCS-Committer-Name: Brian Dolbec X-VCS-Revision: 9d15953ea3e4d59dd17d286066df5f9945c0af19 X-VCS-Branch: repoman Date: Tue, 5 Dec 2017 18:32:06 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 533369a7-6090-4b83-b24f-085f6e31a0e4 X-Archives-Hash: 56f242ab3aed4b6ac5da4a6257944ee8 commit: 9d15953ea3e4d59dd17d286066df5f9945c0af19 Author: Brian Dolbec gentoo org> AuthorDate: Sat Jul 15 01:03:33 2017 +0000 Commit: Brian Dolbec gentoo org> CommitDate: Tue Dec 5 18:24:48 2017 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=9d15953e repoman: New linechecks module, phases .../repoman/modules/linechecks/phases/__init__.py | 34 +++++++++++ .../pym/repoman/modules/linechecks/phases/phase.py | 71 ++++++++++++++++++++++ 2 files changed, 105 insertions(+) diff --git a/repoman/pym/repoman/modules/linechecks/phases/__init__.py b/repoman/pym/repoman/modules/linechecks/phases/__init__.py new file mode 100644 index 000000000..476443b25 --- /dev/null +++ b/repoman/pym/repoman/modules/linechecks/phases/__init__.py @@ -0,0 +1,34 @@ +# Copyright 2015-2016 Gentoo Foundation +# Distributed under the terms of the GNU General Public License v2 + +doc = """Phases plug-in module for repoman LineChecks. +Performs phase dependant checks on ebuilds using a PhaseCheck base class. +""" +__doc__ = doc[:] + + +module_spec = { + 'name': 'do', + 'description': doc, + 'provides':{ + 'emakeparallel-check': { + 'name': "emakeparallel", + 'sourcefile': "phase", + 'class': "EMakeParallelDisabled", + 'description': doc, + }, + 'srccompileeconf-check': { + 'name': "srccompileeconf", + 'sourcefile': "phase", + 'class': "SrcCompileEconf", + 'description': doc, + }, + 'srcunpackpatches-check': { + 'name': "srcunpackpatches", + 'sourcefile': "phase", + 'class': "SrcUnpackPatches", + 'description': doc, + }, + } +} + diff --git a/repoman/pym/repoman/modules/linechecks/phases/phase.py b/repoman/pym/repoman/modules/linechecks/phases/phase.py new file mode 100644 index 000000000..acc3a1e1d --- /dev/null +++ b/repoman/pym/repoman/modules/linechecks/phases/phase.py @@ -0,0 +1,71 @@ + +import re + +from portage.eapi import eapi_has_src_prepare_and_src_configure +from repoman.modules.linechecks.base import LineCheck + + +class PhaseCheck(LineCheck): + """ basic class for function detection """ + + func_end_re = re.compile(r'^\}$') + phases_re = re.compile('(%s)' % '|'.join(( + 'pkg_pretend', 'pkg_setup', 'src_unpack', 'src_prepare', + 'src_configure', 'src_compile', 'src_test', 'src_install', + 'pkg_preinst', 'pkg_postinst', 'pkg_prerm', 'pkg_postrm', + 'pkg_config'))) + in_phase = '' + + def check(self, num, line): + m = self.phases_re.match(line) + if m is not None: + self.in_phase = m.group(1) + if self.in_phase != '' and self.func_end_re.match(line) is not None: + self.in_phase = '' + + return self.phase_check(num, line) + + def phase_check(self, num, line): + """ override this function for your checks """ + pass + + +class EMakeParallelDisabled(PhaseCheck): + """Check for emake -j1 calls which disable parallelization.""" + repoman_check_name = 'upstream.workaround' + re = re.compile(r'^\s*emake\s+.*-j\s*1\b') + + def phase_check(self, num, line): + if self.in_phase == 'src_compile' or self.in_phase == 'src_install': + if self.re.match(line): + return self.errors['EMAKE_PARALLEL_DISABLED'] + + +class SrcCompileEconf(PhaseCheck): + repoman_check_name = 'ebuild.minorsyn' + configure_re = re.compile(r'\s(econf|./configure)') + + def check_eapi(self, eapi): + return eapi_has_src_prepare_and_src_configure(eapi) + + def phase_check(self, num, line): + if self.in_phase == 'src_compile': + m = self.configure_re.match(line) + if m is not None: + return ("'%s'" % m.group(1)) + \ + " call should be moved to src_configure from line: %d" + + +class SrcUnpackPatches(PhaseCheck): + repoman_check_name = 'ebuild.minorsyn' + src_prepare_tools_re = re.compile(r'\s(e?patch|sed)\s') + + def check_eapi(self, eapi): + return eapi_has_src_prepare_and_src_configure(eapi) + + def phase_check(self, num, line): + if self.in_phase == 'src_unpack': + m = self.src_prepare_tools_re.search(line) + if m is not None: + return ("'%s'" % m.group(1)) + \ + " call should be moved to src_prepare from line: %d"