From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id AF0B51396D0 for ; Wed, 20 Sep 2017 18:14:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D7A531FC107; Wed, 20 Sep 2017 18:14:41 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A28E91FC107 for ; Wed, 20 Sep 2017 18:14:41 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 8EF2433BEA7 for ; Wed, 20 Sep 2017 18:14:40 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 5A78A9078 for ; Wed, 20 Sep 2017 18:14:39 +0000 (UTC) From: "Zac Medico" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Zac Medico" Message-ID: <1505931224.5fc7281657e2a5a4b22e969853364b142a37d05f.zmedico@gentoo> Subject: [gentoo-commits] proj/portage:master commit in: bin/postinst-qa-check.d/ X-VCS-Repository: proj/portage X-VCS-Files: bin/postinst-qa-check.d/50gnome2-utils bin/postinst-qa-check.d/50xdg-utils X-VCS-Directories: bin/postinst-qa-check.d/ X-VCS-Committer: zmedico X-VCS-Committer-Name: Zac Medico X-VCS-Revision: 5fc7281657e2a5a4b22e969853364b142a37d05f X-VCS-Branch: master Date: Wed, 20 Sep 2017 18:14:39 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 7113f36e-5cc7-4d82-a436-db141221ebe5 X-Archives-Hash: 243e3e119028d4b74d59a67723ddac84 commit: 5fc7281657e2a5a4b22e969853364b142a37d05f Author: Zac Medico gentoo org> AuthorDate: Wed Sep 20 18:11:53 2017 +0000 Commit: Zac Medico gentoo org> CommitDate: Wed Sep 20 18:13:44 2017 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=5fc72816 postinst-qa-check.d: remove redundant local vars and obsolete comments Fixes: c4edb9ca3a6c ("postinst-qa-check.d: fix [[ ${files[@]} ]] logic in for loops") Reported-by: Michał Górny gentoo.org> bin/postinst-qa-check.d/50gnome2-utils | 4 +--- bin/postinst-qa-check.d/50xdg-utils | 8 ++------ 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/bin/postinst-qa-check.d/50gnome2-utils b/bin/postinst-qa-check.d/50gnome2-utils index 7ee8f2528..569633fe3 100644 --- a/bin/postinst-qa-check.d/50gnome2-utils +++ b/bin/postinst-qa-check.d/50gnome2-utils @@ -1,7 +1,7 @@ # check for missing calls to gnome2-utils regen functions gnome2_icon_cache_check() { - local d f all_files=() find_args missing + local d f all_files=() missing for d in usr/share/icons/*/; do # gnome2_icon_cache_update updates only themes with an index [[ -f ${d}/index.theme ]] || continue @@ -24,8 +24,6 @@ gnome2_icon_cache_check() { # if any files were found, update the db to avoid repeating # the warning for subsequent packages - # (note: yes, it will eagerly repeat the update for next dirs - # but that's a minor issue) if [[ ${files[@]} ]]; then all_files+=("${files[@]}") addwrite "${d}" diff --git a/bin/postinst-qa-check.d/50xdg-utils b/bin/postinst-qa-check.d/50xdg-utils index ca4b49fe4..9164f8dc1 100644 --- a/bin/postinst-qa-check.d/50xdg-utils +++ b/bin/postinst-qa-check.d/50xdg-utils @@ -1,7 +1,7 @@ # check for missing calls to xdg-utils regen functions xdg_desktop_database_check() { - local d f files=() missing + local d f missing for d in usr/share/applications; do [[ -d ${d} ]] || continue @@ -20,8 +20,6 @@ xdg_desktop_database_check() { # if any files were found, update the db to avoid repeating # the warning for subsequent packages - # (note: yes, it will eagerly repeat the update for next dirs - # but it's a minor issue and we have only one dir anyway) if [[ ${files[@]} ]]; then all_files+=("${files[@]}") addwrite "${d}" @@ -41,7 +39,7 @@ xdg_desktop_database_check() { } xdg_mimeinfo_database_check() { - local d f files=() missing + local d f missing for d in usr/share/mime; do [[ -d ${d} ]] || continue @@ -57,8 +55,6 @@ xdg_mimeinfo_database_check() { # if any files were found, update the db to avoid repeating # the warning for subsequent packages - # (note: yes, it will eagerly repeat the update for next dirs - # but it's a minor issue and we have only one dir anyway) if [[ ${files[@]} ]]; then all_files+=("${files[@]}") addwrite "${d}"