From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D8EC41396D0 for ; Sun, 17 Sep 2017 00:52:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B703A1FC0C1; Sun, 17 Sep 2017 00:52:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 95C2D1FC0C0 for ; Sun, 17 Sep 2017 00:52:01 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id E27BE33BE4E for ; Sun, 17 Sep 2017 00:52:00 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 777429090 for ; Sun, 17 Sep 2017 00:51:57 +0000 (UTC) From: "Kent Fredric" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Kent Fredric" Message-ID: <1505608774.8d9b2b281577717bb223f50b24f57ed4eaebd56c.kentnl@gentoo> Subject: [gentoo-commits] proj/perl-overlay:master commit in: eclass/ X-VCS-Repository: proj/perl-overlay X-VCS-Files: eclass/perl-functions.eclass X-VCS-Directories: eclass/ X-VCS-Committer: kentnl X-VCS-Committer-Name: Kent Fredric X-VCS-Revision: 8d9b2b281577717bb223f50b24f57ed4eaebd56c X-VCS-Branch: master Date: Sun, 17 Sep 2017 00:51:57 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: a382c388-8fe3-410c-8d1e-d5cb07926f65 X-Archives-Hash: 1d3f75c127bba4f1d1600a78dad21db3 commit: 8d9b2b281577717bb223f50b24f57ed4eaebd56c Author: Kent Fredric gmail com> AuthorDate: Mon Apr 11 09:58:36 2016 +0000 Commit: Kent Fredric gentoo org> CommitDate: Sun Sep 17 00:39:34 2017 +0000 URL: https://gitweb.gentoo.org/proj/perl-overlay.git/commit/?id=8d9b2b28 perl-functions.eclass: Add a new (not in ::gentoo) perl_check_eapi function eclass/perl-functions.eclass | 54 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+) diff --git a/eclass/perl-functions.eclass b/eclass/perl-functions.eclass index b189ff32c..21fe60592 100644 --- a/eclass/perl-functions.eclass +++ b/eclass/perl-functions.eclass @@ -686,3 +686,57 @@ perl_domodule() { insinto "/${target#/}" doins "${doins_opts[@]}" "${files[@]}" } + +# @FUNCTION: perl_check_eapi +# @DESCRIPTION: +# Checks a blacklist of known-suspect eclass variables which can be accidentally set +# by maintainers, or may be accidentally left residual after an EAPI change. +# +# Dies if any of the suspect fields are found, and tell the user that the ebuild in question +# is broken and needs a fix. +# +# There's a workaround, but you'll have to read the code for it. +perl_check_eapi() { + local errored value; + local suspect_vars=(); + + # Secret sauce to inhibit this check + [[ -n "${_EAPI_PERL_MODULE_PERMISSIVE}" ]] && return; + + if [[ ${EAPI:-0} == 5 ]]; then + suspect_vars=( DIST_TEST DIST_VERSION DIST_NAME DIST_AUTHOR DIST_A_EXT DIST_A DIST_SECTION DIST_EXAMPLES ); + else + suspect_vars=( MY_PN MY_PV MODULE_VERSION MY_P MODULE_A MODULE_A_EXT MODULE_AUTHOR MODULE_NAME SRC_TEST MODULE_SECTION ); + fi + for i in "${suspect_vars[@]}"; do + [[ -v $i ]] || continue; + + # Add heading once and only once + if [[ ${errored:-0} == 0 ]]; then + if [[ -n "${I_KNOW_WHAT_I_AM_DOING}" ]]; then + elog "perl-module.eclass: Suspicious EAPI${EAPI:-0} eclass variables found."; + else + eerror "perl-module.eclass: Suspicious EAPI${EAPI:-0} eclass variables found."; + fi + fi + + errored=1 + # Print ENV name/value pair + if [[ -n "${I_KNOW_WHAT_I_AM_DOING}" ]]; then + elog " ${i}=\"${!i}\""; + else + eerror " ${i}=\"${!i}\""; + fi + done + # Return if there were no failures + [[ ${errored:-0} == 0 ]] && return; + + # Return if user knows what they're doing + if [[ -n "${I_KNOW_WHAT_I_AM_DOING}" ]]; then + elog "Continuing anyway, seems you know what you're doing." + return + fi + + eerror "Your ebuild/env contains eclass variables that are known invalid/legacy and indicate author oversight." + die "Please file a bug for this ebuild as per above details." +}