From: "Patrick McLean" <chutzpah@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-cluster/ceph/, sys-cluster/ceph/files/
Date: Wed, 2 Aug 2017 22:11:40 +0000 (UTC) [thread overview]
Message-ID: <1501711887.3bb809e1da954b79678beed5d6e06dd7907b880a.chutzpah@gentoo> (raw)
commit: 3bb809e1da954b79678beed5d6e06dd7907b880a
Author: Patrick McLean <chutzpah <AT> gentoo <DOT> org>
AuthorDate: Wed Aug 2 22:11:27 2017 +0000
Commit: Patrick McLean <chutzpah <AT> gentoo <DOT> org>
CommitDate: Wed Aug 2 22:11:27 2017 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3bb809e1
sys-cluster/ceph: Pull one of the patches from 10.2.9-r3
Package-Manager: Portage-2.3.6, Repoman-2.3.3
sys-cluster/ceph/ceph-10.2.9-r3.ebuild | 1 -
....2.9-librados_Fix_deadlock_in_watch_flush.patch | 61 ----------------------
2 files changed, 62 deletions(-)
diff --git a/sys-cluster/ceph/ceph-10.2.9-r3.ebuild b/sys-cluster/ceph/ceph-10.2.9-r3.ebuild
index d74301f3760..edd9ac4bbd6 100644
--- a/sys-cluster/ceph/ceph-10.2.9-r3.ebuild
+++ b/sys-cluster/ceph/ceph-10.2.9-r3.ebuild
@@ -118,7 +118,6 @@ PATCHES=(
"${FILESDIR}/${PN}-10.2.9-libradosstriper_fix_format_injection_vulnerability.patch"
"${FILESDIR}/${PN}-10.2.9-rbd-nbd_relax_size_check_for_newer_kernel_versions.patch"
"${FILESDIR}/${PN}-10.2.9-filestore_fix_infinit_loops_in_fiemap.patch"
- "${FILESDIR}/${PN}-10.2.9-librados_Fix_deadlock_in_watch_flush.patch"
"${FILESDIR}/${PN}-10.2.9-librbd_filter_expected_error_codes_from_is_exclusive_lock_owner.patch"
"${FILESDIR}/${PN}-10.2.9-osd-scrub_to_specifies_clone_ver_but_transaction_include.patch"
"${FILESDIR}/${PN}-10.2.9-rbd-do_not_attempt_to_load_key_if_auth_is_disabled.patch"
diff --git a/sys-cluster/ceph/files/ceph-10.2.9-librados_Fix_deadlock_in_watch_flush.patch b/sys-cluster/ceph/files/ceph-10.2.9-librados_Fix_deadlock_in_watch_flush.patch
deleted file mode 100644
index 77ab14b4295..00000000000
--- a/sys-cluster/ceph/files/ceph-10.2.9-librados_Fix_deadlock_in_watch_flush.patch
+++ /dev/null
@@ -1,61 +0,0 @@
-From 2fb04c40804f646b4cdd3a55ec8a9e9df95b9360 Mon Sep 17 00:00:00 2001
-From: Xiaoxi Chen <xiaoxchen@ebay.com>
-Date: Sat, 10 Sep 2016 00:23:55 +0800
-Subject: [PATCH] Librados: Fix deadlock in watch_flush
-
-In previous code, in the watch_flush, it is waiting on conditon
-with holding the "lock". The condition will only be signal by
-finisher thread, but sadly, in some cases,when finisher queue
-is not empty, some context need to take the "lock", thus deadlock.
-
-To avoid concurrent call to shutdown cause race condition, add
-a shutdown_lock to ensure only one concurrent in shutdown function.
-
-Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
----
- src/librados/RadosClient.cc | 4 ++++
- src/librados/RadosClient.h | 1 +
- 2 files changed, 5 insertions(+)
-
-diff --git a/src/librados/RadosClient.cc b/src/librados/RadosClient.cc
-index 8c5e8ed803fa..230e8b53ecd9 100644
---- a/src/librados/RadosClient.cc
-+++ b/src/librados/RadosClient.cc
-@@ -72,6 +72,7 @@ librados::RadosClient::RadosClient(CephContext *cct_)
- instance_id(0),
- objecter(NULL),
- lock("librados::RadosClient::lock"),
-+ shutdown_lock("librados::RadosClient::shutdown_lock"),
- timer(cct, lock),
- refcnt(1),
- log_last_version(0), log_cb(NULL), log_cb_arg(NULL),
-@@ -324,6 +325,7 @@ int librados::RadosClient::connect()
-
- void librados::RadosClient::shutdown()
- {
-+ Mutex::Locker l(shutdown_lock);
- lock.Lock();
- if (state == DISCONNECTED) {
- lock.Unlock();
-@@ -338,7 +340,9 @@ void librados::RadosClient::shutdown()
- if (state == CONNECTED) {
- if (need_objecter) {
- // make sure watch callbacks are flushed
-+ lock.Unlock();
- watch_flush();
-+ lock.Lock();
- }
- finisher.wait_for_empty();
- finisher.stop();
-diff --git a/src/librados/RadosClient.h b/src/librados/RadosClient.h
-index f495ba5966c2..a8ef2070ddcb 100644
---- a/src/librados/RadosClient.h
-+++ b/src/librados/RadosClient.h
-@@ -62,6 +62,7 @@ class librados::RadosClient : public Dispatcher
- Objecter *objecter;
-
- Mutex lock;
-+ Mutex shutdown_lock;
- Cond cond;
- SafeTimer timer;
- int refcnt;
next reply other threads:[~2017-08-02 22:11 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 22:11 Patrick McLean [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-10-14 0:50 [gentoo-commits] repo/gentoo:master commit in: sys-cluster/ceph/, sys-cluster/ceph/files/ Sam James
2024-10-01 9:32 Patrick Lauer
2024-07-30 9:05 Patrick Lauer
2024-07-30 9:05 Patrick Lauer
2023-11-08 2:51 Patrick McLean
2023-09-12 2:24 Patrick McLean
2023-06-04 5:06 Sam James
2023-06-03 1:54 Sam James
2023-04-11 23:28 Patrick McLean
2023-03-17 18:07 Patrick McLean
2022-10-28 15:57 Sam James
2022-10-04 23:42 Patrick McLean
2022-08-24 17:07 Patrick McLean
2022-08-22 20:29 Patrick McLean
2022-07-07 18:32 Patrick McLean
2022-06-28 0:27 Patrick McLean
2022-05-17 18:03 Patrick McLean
2022-05-13 10:59 Michał Górny
2022-05-05 22:51 Patrick McLean
2022-05-04 23:17 Patrick McLean
2022-04-29 0:31 Patrick McLean
2021-10-29 20:49 Patrick McLean
2021-10-25 17:02 Patrick McLean
2021-10-25 17:02 Patrick McLean
2021-07-01 0:47 Patrick McLean
2020-12-01 2:35 Patrick McLean
2020-11-25 5:38 Patrick McLean
2020-11-19 7:29 Patrick McLean
2020-09-25 0:53 Patrick McLean
2020-09-16 23:52 Patrick McLean
2020-08-05 0:16 Patrick McLean
2020-06-24 0:51 Patrick McLean
2020-04-03 1:41 Patrick McLean
2019-12-11 22:40 Patrick McLean
2019-11-08 23:26 Patrick McLean
2019-09-17 22:56 Patrick McLean
2019-09-05 0:26 Patrick McLean
2019-07-19 3:20 Patrick McLean
2019-06-13 1:48 Patrick McLean
2019-04-29 22:57 Patrick McLean
2019-04-12 2:05 Patrick McLean
2019-03-29 2:23 Patrick McLean
2019-03-20 21:54 Patrick McLean
2019-03-20 1:12 Patrick McLean
2019-01-08 0:13 Patrick McLean
2018-11-29 23:57 Patrick McLean
2018-11-09 2:51 Patrick McLean
2018-03-10 19:16 Patrick McLean
2018-03-06 19:39 Patrick McLean
2018-02-06 17:43 Patrick Lauer
2017-12-05 20:10 Patrick McLean
2017-10-06 21:07 Patrick McLean
2017-09-27 21:19 Patrick McLean
2017-09-07 23:40 Patrick McLean
2017-08-02 21:04 Patrick McLean
2017-07-31 19:04 Patrick McLean
2017-07-27 21:33 Patrick McLean
2017-07-27 21:27 Patrick McLean
2017-04-12 20:44 Patrick McLean
2017-02-10 1:18 Patrick McLean
2016-10-11 21:57 Patrick McLean
2016-07-11 1:23 Yixun Lan
2016-06-30 23:53 Patrick McLean
2016-06-07 6:45 Yixun Lan
2016-05-12 21:05 Patrick McLean
2016-05-12 18:56 Patrick McLean
2015-12-21 7:47 Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501711887.3bb809e1da954b79678beed5d6e06dd7907b880a.chutzpah@gentoo \
--to=chutzpah@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox