From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-plasma/plasma-workspace/files/, kde-plasma/plasma-workspace/
Date: Fri, 9 Jun 2017 19:24:45 +0000 (UTC) [thread overview]
Message-ID: <1497036252.e523ec3c5738860936173e5d006b42481a7cb8d0.asturm@gentoo> (raw)
commit: e523ec3c5738860936173e5d006b42481a7cb8d0
Author: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Fri Jun 9 18:42:20 2017 +0000
Commit: Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Fri Jun 9 19:24:12 2017 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e523ec3c
kde-plasma/plasma-workspace: Add Plasma/5.9 branch fixes
Both fixes are also in Plasma 5.8.7.
See also:
https://bugs.kde.org/show_bug.cgi?id=377280
https://bugs.kde.org/show_bug.cgi?id=379414
Package-Manager: Portage-2.3.5, Repoman-2.3.1
...plasma-workspace-5.9.5.1-pinned-launchers.patch | 56 +++++++
.../plasma-workspace-5.9.5.1-startup-crash.patch | 47 ++++++
.../plasma-workspace-5.9.5.1-r2.ebuild | 173 +++++++++++++++++++++
3 files changed, 276 insertions(+)
diff --git a/kde-plasma/plasma-workspace/files/plasma-workspace-5.9.5.1-pinned-launchers.patch b/kde-plasma/plasma-workspace/files/plasma-workspace-5.9.5.1-pinned-launchers.patch
new file mode 100644
index 00000000000..ea1084d417d
--- /dev/null
+++ b/kde-plasma/plasma-workspace/files/plasma-workspace-5.9.5.1-pinned-launchers.patch
@@ -0,0 +1,56 @@
+From 89b244a1ff72925805da6e5f44979ad4cb647468 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Ivan=20=C4=8Cuki=C4=87?= <ivan.cukic@kde.org>
+Date: Mon, 22 May 2017 10:08:16 +0200
+Subject: We should not forget the launchers that are not currently shown
+
+Summary:
+The pinned launchers that are assigned to other activities
+will have a -1 as the order. We should not forget them
+when saving to the configuration file.
+
+Reviewers: hein, mart
+
+Reviewed By: hein
+
+Subscribers: plasma-devel
+
+Tags: #plasma
+
+Differential Revision: https://phabricator.kde.org/D5933
+---
+ libtaskmanager/tasksmodel.cpp | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/libtaskmanager/tasksmodel.cpp b/libtaskmanager/tasksmodel.cpp
+index 19f1bca..0150761 100644
+--- a/libtaskmanager/tasksmodel.cpp
++++ b/libtaskmanager/tasksmodel.cpp
+@@ -1545,6 +1545,7 @@ void TasksModel::syncLaunchers()
+ }
+
+ QMap<int, QString> sortedShownLaunchers;
++ QStringList sortedHiddenLaunchers;
+
+ foreach(const QString &launcherUrlStr, launcherList()) {
+ int row = -1;
+@@ -1564,6 +1565,8 @@ void TasksModel::syncLaunchers()
+
+ if (row != -1) {
+ sortedShownLaunchers.insert(row, launcherUrlStr);
++ } else {
++ sortedHiddenLaunchers << launcherUrlStr;
+ }
+ }
+
+@@ -1588,7 +1591,8 @@ void TasksModel::syncLaunchers()
+ d->sortedPreFilterRows.replace(sortMapIndices.at(i), preFilterRows.at(i));
+ }
+ }
+- setLauncherList(sortedShownLaunchers.values());
++
++ setLauncherList(sortedShownLaunchers.values() + sortedHiddenLaunchers);
+ d->launcherSortingDirty = false;
+ }
+
+--
+cgit v0.11.2
diff --git a/kde-plasma/plasma-workspace/files/plasma-workspace-5.9.5.1-startup-crash.patch b/kde-plasma/plasma-workspace/files/plasma-workspace-5.9.5.1-startup-crash.patch
new file mode 100644
index 00000000000..0c2e27c67ce
--- /dev/null
+++ b/kde-plasma/plasma-workspace/files/plasma-workspace-5.9.5.1-startup-crash.patch
@@ -0,0 +1,47 @@
+From d602198f6807bbfa175b6aaaa1bdf1708fce703e Mon Sep 17 00:00:00 2001
+From: Marco Martin <notmart@gmail.com>
+Date: Mon, 22 May 2017 17:37:56 +0200
+Subject: don't check for panel visible during startup
+
+if any kscreen related activities occurred
+during startup, the panel wouldn't be visible
+yet, and this would assert. This often happens
+when a screen gets disabled at startup
+
+CCBUG:377280
+---
+ shell/panelview.cpp | 1 +
+ shell/shellcorona.cpp | 6 +++++-
+ 2 files changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/shell/panelview.cpp b/shell/panelview.cpp
+index 70d74cb..cacf0c0 100644
+--- a/shell/panelview.cpp
++++ b/shell/panelview.cpp
+@@ -117,6 +117,7 @@ PanelView::~PanelView()
+
+ KConfigGroup PanelView::panelConfig(ShellCorona *corona, Plasma::Containment *containment, QScreen *screen)
+ {
++ qWarning()<<"AAAA"<<containment<<screen;
+ if (!containment || !screen) {
+ return KConfigGroup();
+ }
+diff --git a/shell/shellcorona.cpp b/shell/shellcorona.cpp
+index e40da45..b6b5ed8 100644
+--- a/shell/shellcorona.cpp
++++ b/shell/shellcorona.cpp
+@@ -778,7 +778,11 @@ void ShellCorona::screenInvariants() const
+ foreach (const PanelView *panel, panelsForScreen(screen)) {
+ Q_ASSERT(panel->containment());
+ Q_ASSERT(panel->containment()->screen() == id || panel->containment()->screen() == -1);
+- Q_ASSERT(panel->isVisible());
++ //If any kscreen related activities occurred
++ //during startup, the panel wouldn't be visible yet, and this would assert
++ if (panel->containment()->isUiReady()) {
++ Q_ASSERT(panel->isVisible());
++ }
+ }
+
+ screens.insert(screen);
+--
+cgit v0.11.2
diff --git a/kde-plasma/plasma-workspace/plasma-workspace-5.9.5.1-r2.ebuild b/kde-plasma/plasma-workspace/plasma-workspace-5.9.5.1-r2.ebuild
new file mode 100644
index 00000000000..3f8d7d47535
--- /dev/null
+++ b/kde-plasma/plasma-workspace/plasma-workspace-5.9.5.1-r2.ebuild
@@ -0,0 +1,173 @@
+# Copyright 1999-2017 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6
+
+KDE_HANDBOOK="forceoptional"
+KDE_TEST="forceoptional"
+VIRTUALX_REQUIRED="test"
+inherit kde5 qmake-utils
+
+DESCRIPTION="KDE Plasma workspace"
+KEYWORDS="~amd64 ~arm ~x86"
+IUSE="+calendar geolocation gps prison qalculate +semantic-desktop"
+
+COMMON_DEPEND="
+ $(add_frameworks_dep kactivities)
+ $(add_frameworks_dep kauth)
+ $(add_frameworks_dep kbookmarks)
+ $(add_frameworks_dep kcmutils)
+ $(add_frameworks_dep kcompletion)
+ $(add_frameworks_dep kconfig)
+ $(add_frameworks_dep kconfigwidgets)
+ $(add_frameworks_dep kcoreaddons)
+ $(add_frameworks_dep kcrash)
+ $(add_frameworks_dep kdbusaddons)
+ $(add_frameworks_dep kdeclarative)
+ $(add_frameworks_dep kdelibs4support)
+ $(add_frameworks_dep kdesu)
+ $(add_frameworks_dep kglobalaccel)
+ $(add_frameworks_dep kguiaddons)
+ $(add_frameworks_dep ki18n)
+ $(add_frameworks_dep kiconthemes)
+ $(add_frameworks_dep kidletime)
+ $(add_frameworks_dep kio)
+ $(add_frameworks_dep kitemmodels)
+ $(add_frameworks_dep kitemviews)
+ $(add_frameworks_dep kjobwidgets)
+ $(add_frameworks_dep kjs)
+ $(add_frameworks_dep kjsembed)
+ $(add_frameworks_dep knewstuff)
+ $(add_frameworks_dep knotifications)
+ $(add_frameworks_dep knotifyconfig)
+ $(add_frameworks_dep kpackage)
+ $(add_frameworks_dep krunner)
+ $(add_frameworks_dep kservice)
+ $(add_frameworks_dep ktexteditor)
+ $(add_frameworks_dep ktextwidgets)
+ $(add_frameworks_dep kwallet)
+ $(add_frameworks_dep kwayland)
+ $(add_frameworks_dep kwidgetsaddons)
+ $(add_frameworks_dep kwindowsystem)
+ $(add_frameworks_dep kxmlgui)
+ $(add_frameworks_dep kxmlrpcclient)
+ $(add_frameworks_dep plasma)
+ $(add_frameworks_dep solid)
+ $(add_plasma_dep kscreenlocker)
+ $(add_plasma_dep kwin)
+ $(add_plasma_dep libksysguard)
+ $(add_qt_dep qtconcurrent)
+ $(add_qt_dep qtdbus)
+ $(add_qt_dep qtdeclarative 'widgets')
+ $(add_qt_dep qtgui 'jpeg')
+ $(add_qt_dep qtnetwork)
+ $(add_qt_dep qtscript)
+ $(add_qt_dep qtsql)
+ $(add_qt_dep qtwidgets)
+ $(add_qt_dep qtx11extras)
+ $(add_qt_dep qtxml)
+ media-libs/phonon[qt5]
+ sys-libs/zlib
+ x11-libs/libICE
+ x11-libs/libSM
+ x11-libs/libX11
+ x11-libs/libXau
+ x11-libs/libxcb
+ x11-libs/libXfixes
+ x11-libs/libXrender
+ x11-libs/xcb-util
+ x11-libs/xcb-util-image
+ calendar? ( $(add_kdeapps_dep kholidays) )
+ geolocation? ( $(add_frameworks_dep networkmanager-qt) )
+ gps? ( sci-geosciences/gpsd )
+ prison? ( $(add_frameworks_dep prison) )
+ qalculate? ( sci-libs/libqalculate:= )
+ semantic-desktop? ( $(add_frameworks_dep baloo) )
+"
+RDEPEND="${COMMON_DEPEND}
+ $(add_frameworks_dep kded)
+ $(add_kdeapps_dep kio-extras)
+ $(add_plasma_dep kde-cli-tools)
+ $(add_plasma_dep ksysguard)
+ $(add_plasma_dep milou)
+ $(add_plasma_dep plasma-integration)
+ $(add_qt_dep qdbus)
+ $(add_qt_dep qtgraphicaleffects)
+ $(add_qt_dep qtpaths)
+ $(add_qt_dep qtquickcontrols 'widgets')
+ app-text/iso-codes
+ x11-apps/mkfontdir
+ x11-apps/xmessage
+ x11-apps/xprop
+ x11-apps/xrdb
+ x11-apps/xset
+ x11-apps/xsetroot
+ !dev-libs/xembed-sni-proxy
+ !kde-plasma/freespacenotifier:4
+ !kde-plasma/libtaskmanager:4
+ !kde-plasma/kcminit:4
+ !kde-plasma/kdebase-startkde:4
+ !kde-plasma/klipper:4
+ !kde-plasma/krunner:4
+ !kde-plasma/ksmserver:4
+ !kde-plasma/ksplash:4
+ !kde-plasma/plasma-workspace:4
+"
+DEPEND="${COMMON_DEPEND}
+ x11-proto/xproto
+"
+
+PATCHES=(
+ "${FILESDIR}/${PN}-5.4-startkde-script.patch"
+ # Plasma/5.9 branch
+ "${FILESDIR}/${P}-startup-crash.patch" # KDE bug #377280
+ "${FILESDIR}/${P}-pinned-launchers.patch" # KDE bug #379414
+)
+
+RESTRICT+=" test"
+
+src_prepare() {
+ kde5_src_prepare
+
+ sed -e "s|\`qtpaths|\`$(qt5_get_bindir)/qtpaths|" \
+ -i startkde/startkde.cmake startkde/startplasmacompositor.cmake || die
+
+ # https://phabricator.kde.org/D4690
+ sed -e "/add_subdirectory(remote)/ s/^/#DONT/" -i kioslave/CMakeLists.txt || die
+ rm -r kioslave/remote || die
+ find po -name "kio_remote.po" -delete || die
+}
+
+src_configure() {
+ local mycmakeargs=(
+ $(cmake-utils_use_find_package calendar KF5Holidays)
+ $(cmake-utils_use_find_package geolocation KF5NetworkManagerQt)
+ $(cmake-utils_use_find_package gps libgps)
+ $(cmake-utils_use_find_package prison KF5Prison)
+ $(cmake-utils_use_find_package qalculate Qalculate)
+ $(cmake-utils_use_find_package semantic-desktop KF5Baloo)
+ )
+
+ kde5_src_configure
+}
+
+src_install() {
+ kde5_src_install
+
+ # startup and shutdown scripts
+ insinto /etc/plasma/startup
+ doins "${FILESDIR}/10-agent-startup.sh"
+
+ insinto /etc/plasma/shutdown
+ doins "${FILESDIR}/10-agent-shutdown.sh"
+}
+
+pkg_postinst () {
+ kde5_pkg_postinst
+
+ echo
+ elog "To enable gpg-agent and/or ssh-agent in Plasma sessions,"
+ elog "edit ${EPREFIX}/etc/plasma/startup/10-agent-startup.sh and"
+ elog "${EPREFIX}/etc/plasma/shutdown/10-agent-shutdown.sh"
+ echo
+}
next reply other threads:[~2017-06-09 19:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 19:24 Andreas Sturmlechner [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-01 21:05 [gentoo-commits] repo/gentoo:master commit in: kde-plasma/plasma-workspace/files/, kde-plasma/plasma-workspace/ Andreas Sturmlechner
2024-12-10 23:46 Andreas Sturmlechner
2024-09-20 17:11 Andreas Sturmlechner
2024-09-14 21:37 Andreas Sturmlechner
2024-09-10 17:58 Andreas Sturmlechner
2024-09-02 20:13 Andreas Sturmlechner
2023-11-11 1:03 Andreas Sturmlechner
2023-08-16 16:31 Andreas Sturmlechner
2023-03-22 23:01 Andreas Sturmlechner
2022-10-10 9:54 Andreas Sturmlechner
2022-09-23 20:07 Andreas Sturmlechner
2022-09-23 20:07 Andreas Sturmlechner
2022-08-07 15:51 Andreas Sturmlechner
2022-01-25 9:49 Andreas Sturmlechner
2021-11-23 14:59 Andreas Sturmlechner
2021-09-30 17:24 Andreas Sturmlechner
2021-09-14 13:39 Andreas Sturmlechner
2021-01-24 19:44 Andreas Sturmlechner
2021-01-23 0:25 Andreas Sturmlechner
2021-01-23 0:25 Andreas Sturmlechner
2020-09-17 20:15 Andreas Sturmlechner
2020-09-17 20:15 Andreas Sturmlechner
2019-12-17 23:49 Andreas Sturmlechner
2019-10-29 22:22 Andreas Sturmlechner
2017-08-02 23:22 Andreas Sturmlechner
2017-06-17 18:30 Andreas Sturmlechner
2016-11-17 11:35 Michael Palimaka
2016-11-12 8:22 Michael Palimaka
2016-06-26 20:36 Michael Palimaka
2016-06-26 17:19 Michael Palimaka
2015-11-19 16:42 Michael Palimaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497036252.e523ec3c5738860936173e5d006b42481a7cb8d0.asturm@gentoo \
--to=asturm@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox