public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Andreas Sturmlechner" <asturm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: kde-plasma/kwin/, kde-plasma/kwin/files/
Date: Sat, 15 Apr 2017 15:11:35 +0000 (UTC)	[thread overview]
Message-ID: <1492269082.301c2e6d2d322f3f38377fe20f94d55c849a5f37.asturm@gentoo> (raw)

commit:     301c2e6d2d322f3f38377fe20f94d55c849a5f37
Author:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
AuthorDate: Sat Apr 15 12:11:35 2017 +0000
Commit:     Andreas Sturmlechner <asturm <AT> gentoo <DOT> org>
CommitDate: Sat Apr 15 15:11:22 2017 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=301c2e6d

kde-plasma/kwin: Do not write GLPlatformInterface config

Changing compositor settings in Wayland shall not break X11 sessions.

Package-Manager: Portage-2.3.3, Repoman-2.3.1

 kde-plasma/kwin/files/kwin-5.9.4-glconfig.patch | 37 +++++++++++++++++++++++++
 kde-plasma/kwin/kwin-5.9.4-r1.ebuild            |  5 +++-
 2 files changed, 41 insertions(+), 1 deletion(-)

diff --git a/kde-plasma/kwin/files/kwin-5.9.4-glconfig.patch b/kde-plasma/kwin/files/kwin-5.9.4-glconfig.patch
new file mode 100644
index 00000000000..90a746e8f28
--- /dev/null
+++ b/kde-plasma/kwin/files/kwin-5.9.4-glconfig.patch
@@ -0,0 +1,37 @@
+commit a936516107579df13362f6d2d6f91f26a447d6dd
+Author: Martin Gräßlin <mgraesslin@kde.org>
+Date:   Mon Apr 3 06:53:05 2017 +0200
+
+    [kcmkwin/compositing] Do not write GLPlatformInterface config
+    
+    Summary:
+    The gui element to select the platform interface is dropped. Thus we
+    should not store the config for it. This is rather important as changing
+    compositor settings on Wayland would result in egl being written into the
+    config which potentially breaks an X11 session.
+    
+    BUG: 378114
+    
+    Reviewers: #kwin, #plasma
+    
+    Subscribers: plasma-devel, kwin
+    
+    Tags: #kwin
+    
+    Differential Revision: https://phabricator.kde.org/D5285
+
+diff --git a/kcmkwin/kwincompositing/compositing.cpp b/kcmkwin/kwincompositing/compositing.cpp
+index c1cddb89d..102dfd18c 100644
+--- a/kcmkwin/kwincompositing/compositing.cpp
++++ b/kcmkwin/kwincompositing/compositing.cpp
+@@ -309,10 +309,6 @@ void Compositing::save()
+     }
+     kwinConfig.writeEntry("Backend", backend);
+     kwinConfig.writeEntry("GLCore", glCore);
+-    const QModelIndex glIndex = m_openGLPlatformInterfaceModel->index(m_openGLPlatformInterface);
+-    if (glIndex.isValid()) {
+-        kwinConfig.writeEntry("GLPlatformInterface", glIndex.data(Qt::UserRole).toString());
+-    }
+     if (!compositingRequired()) {
+         kwinConfig.writeEntry("WindowsBlockCompositing", windowsBlockCompositing());
+     }

diff --git a/kde-plasma/kwin/kwin-5.9.4-r1.ebuild b/kde-plasma/kwin/kwin-5.9.4-r1.ebuild
index dad7f6668cc..545e43d5dfe 100644
--- a/kde-plasma/kwin/kwin-5.9.4-r1.ebuild
+++ b/kde-plasma/kwin/kwin-5.9.4-r1.ebuild
@@ -88,7 +88,10 @@ DEPEND="${COMMON_DEPEND}
 
 RESTRICT+=" test"
 
-PATCHES=( "${FILESDIR}/${PN}-5.8.6-libdrm-2.4.78.patch" )
+PATCHES=(
+	"${FILESDIR}/${PN}-5.8.6-libdrm-2.4.78.patch"
+	"${FILESDIR}/${P}-glconfig.patch"
+)
 
 src_prepare() {
 	kde5_src_prepare


             reply	other threads:[~2017-04-15 15:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-15 15:11 Andreas Sturmlechner [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-02-25 22:51 [gentoo-commits] repo/gentoo:master commit in: kde-plasma/kwin/, kde-plasma/kwin/files/ Sam James
2025-02-18 18:58 Sam James
2025-02-12 19:29 Andreas Sturmlechner
2024-12-02 19:39 Andreas Sturmlechner
2024-06-13  0:46 Sam James
2024-03-13 21:17 Andreas Sturmlechner
2023-12-16  9:10 Andreas Sturmlechner
2023-09-30 10:00 Andreas Sturmlechner
2023-09-20 13:15 Andreas Sturmlechner
2023-05-12 20:42 Andreas Sturmlechner
2022-08-07 20:58 Andreas Sturmlechner
2022-07-26 12:08 Andreas Sturmlechner
2021-12-10 14:58 Andreas Sturmlechner
2021-11-23 14:59 Andreas Sturmlechner
2021-09-21 18:44 Andreas Sturmlechner
2021-09-14  9:04 Andreas Sturmlechner
2021-01-23  0:25 Andreas Sturmlechner
2020-06-07 21:00 Andreas Sturmlechner
2020-06-01 10:13 Andreas Sturmlechner
2019-12-17 23:49 Andreas Sturmlechner
2018-11-18  0:17 Andreas Sturmlechner
2017-07-27 17:46 Andreas Sturmlechner
2017-04-15 15:11 Andreas Sturmlechner
2016-06-26 20:36 Michael Palimaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492269082.301c2e6d2d322f3f38377fe20f94d55c849a5f37.asturm@gentoo \
    --to=asturm@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox