public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "NP Hardass" <np-hardass@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/wine-d3d9/
Date: Tue, 11 Apr 2017 11:46:34 +0000 (UTC)	[thread overview]
Message-ID: <1491911186.892e88daf934e116fb9e9b1ee13c1b9bf750a123.np-hardass@gentoo> (raw)

commit:     892e88daf934e116fb9e9b1ee13c1b9bf750a123
Author:     NP-Hardass <NP-Hardass <AT> gentoo <DOT> org>
AuthorDate: Tue Apr 11 11:39:21 2017 +0000
Commit:     NP Hardass <np-hardass <AT> gentoo <DOT> org>
CommitDate: Tue Apr 11 11:46:26 2017 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=892e88da

app-emulation/wine-d3d9: QA, use failglob

Addresses some of the issues in #615218

Package-Manager: Portage-2.3.3, Repoman-2.3.1

 app-emulation/wine-d3d9/wine-d3d9-2.0.ebuild  | 18 +++++++++++++-----
 app-emulation/wine-d3d9/wine-d3d9-2.1.ebuild  | 18 +++++++++++++-----
 app-emulation/wine-d3d9/wine-d3d9-2.2.ebuild  | 18 +++++++++++++-----
 app-emulation/wine-d3d9/wine-d3d9-2.3.ebuild  | 18 +++++++++++++-----
 app-emulation/wine-d3d9/wine-d3d9-2.4.ebuild  | 18 +++++++++++++-----
 app-emulation/wine-d3d9/wine-d3d9-2.5.ebuild  | 18 +++++++++++++-----
 app-emulation/wine-d3d9/wine-d3d9-9999.ebuild | 18 +++++++++++++-----
 7 files changed, 91 insertions(+), 35 deletions(-)

diff --git a/app-emulation/wine-d3d9/wine-d3d9-2.0.ebuild b/app-emulation/wine-d3d9/wine-d3d9-2.0.ebuild
index 2d32ef35e24..bdb69354a6c 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-2.0.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-2.0.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-d3d9/wine-d3d9-2.1.ebuild b/app-emulation/wine-d3d9/wine-d3d9-2.1.ebuild
index 2b6973341d3..5b66aee363e 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-2.1.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-2.1.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-d3d9/wine-d3d9-2.2.ebuild b/app-emulation/wine-d3d9/wine-d3d9-2.2.ebuild
index 2b6973341d3..5b66aee363e 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-2.2.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-2.2.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-d3d9/wine-d3d9-2.3.ebuild b/app-emulation/wine-d3d9/wine-d3d9-2.3.ebuild
index 2b6973341d3..5b66aee363e 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-2.3.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-2.3.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-d3d9/wine-d3d9-2.4.ebuild b/app-emulation/wine-d3d9/wine-d3d9-2.4.ebuild
index badba49da22..ba768c01725 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-2.4.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-2.4.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-d3d9/wine-d3d9-2.5.ebuild b/app-emulation/wine-d3d9/wine-d3d9-2.5.ebuild
index badba49da22..ba768c01725 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-2.5.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-2.5.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {

diff --git a/app-emulation/wine-d3d9/wine-d3d9-9999.ebuild b/app-emulation/wine-d3d9/wine-d3d9-9999.ebuild
index badba49da22..ba768c01725 100644
--- a/app-emulation/wine-d3d9/wine-d3d9-9999.ebuild
+++ b/app-emulation/wine-d3d9/wine-d3d9-9999.ebuild
@@ -452,7 +452,6 @@ multilib_src_test() {
 
 multilib_src_install_all() {
 	local DOCS=( ANNOUNCE AUTHORS README )
-	local l
 	add_locale_docs() {
 		local locale_doc="documentation/README.$1"
 		[[ ! -e ${locale_doc} ]] || DOCS+=( ${locale_doc} )
@@ -485,22 +484,31 @@ multilib_src_install_all() {
 		dosym "${MY_PREFIX}"/bin/wine{64,}-preloader
 	fi
 
+	# Failglob for bin and man loops
+	local glob_state=$(shopt -p failglob)
+	shopt -s failglob
+
 	# Make wrappers for binaries for handling multiple variants
 	# Note: wrappers instead of symlinks because some are shell which use basename
+	local b
 	for b in "${D%/}${MY_PREFIX}"/bin/*; do
-		make_wrapper ${b##*/}-${WINE_VARIANT} "${MY_PREFIX}"/bin/${b##*/}
+		make_wrapper "${b##*/}-${WINE_VARIANT}" "${MY_PREFIX}/bin/${b##*/}"
 	done
 
 	# respect LINGUAS when installing man pages, #469418
+	local l
 	for l in de fr pl; do
 		use linguas_${l} || rm -r "${D%/}${MY_MANDIR}"/${l}*
 	done
 
+	local m
 	for m in "${D%/}${MY_MANDIR}"/*/*; do
-		new_man=${m##*/}
-		new_man=${new_man%%.1}
-		newman "${m}" ${new_man##*/}-${WINE_VARIANT}.1
+		new_man="${m##*/}"
+		new_man="${new_man%%.1}"
+		newman "${m}" "${new_man##*/}-${WINE_VARIANT}.1"
 	done
+
+	eval "${glob_state}"
 }
 
 pkg_postinst() {


             reply	other threads:[~2017-04-11 11:46 UTC|newest]

Thread overview: 79+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 11:46 NP Hardass [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-12-22 20:25 [gentoo-commits] repo/gentoo:master commit in: app-emulation/wine-d3d9/ Nick Sarnie
2019-08-18 12:37 David Seifert
2019-05-12 14:13 Nick Sarnie
2019-02-18 15:44 Nick Sarnie
2019-02-18 15:44 Nick Sarnie
2019-01-27 17:14 Nick Sarnie
2019-01-24  2:44 Nick Sarnie
2019-01-24  2:44 Nick Sarnie
2018-12-29 21:17 Nick Sarnie
2018-11-25 16:58 Nick Sarnie
2018-11-25 16:58 Nick Sarnie
2018-11-11 17:37 Nick Sarnie
2018-11-11 17:37 Nick Sarnie
2018-11-04 21:06 Nick Sarnie
2018-11-04 21:06 Nick Sarnie
2018-10-13 15:59 Nick Sarnie
2018-10-13 15:59 Nick Sarnie
2018-09-30 19:59 Nick Sarnie
2018-09-30 19:59 Nick Sarnie
2018-09-17  1:16 Nick Sarnie
2018-09-17  1:16 Nick Sarnie
2018-09-02 14:41 Nick Sarnie
2018-09-02 14:41 Nick Sarnie
2018-09-02  1:10 Nick Sarnie
2018-09-01 16:45 Nick Sarnie
2018-08-02  2:44 Nick Sarnie
2018-07-21 17:08 Nick Sarnie
2018-07-21 17:08 Nick Sarnie
2018-07-14  2:47 Nick Sarnie
2018-07-14  2:47 Nick Sarnie
2018-06-24 18:15 Nick Sarnie
2018-06-24 18:15 Nick Sarnie
2018-06-17 19:15 Nick Sarnie
2018-06-17 19:15 Nick Sarnie
2018-05-28 16:02 Nick Sarnie
2018-05-27 16:56 Nick Sarnie
2018-05-27 16:56 Nick Sarnie
2018-05-13 14:47 Nick Sarnie
2018-05-13 14:47 Nick Sarnie
2018-05-02  1:33 Nick Sarnie
2018-05-02  1:33 Nick Sarnie
2018-04-22 19:26 Nick Sarnie
2018-03-02  2:14 NP Hardass
2018-01-22 22:51 NP Hardass
2018-01-22 22:51 NP Hardass
2018-01-20  8:00 NP Hardass
2018-01-20  8:00 NP Hardass
2018-01-05 18:10 Ulrich Müller
2018-01-05 17:02 Ulrich Müller
2017-12-04  6:27 NP Hardass
2017-11-29  2:30 NP Hardass
2017-11-28 16:24 NP Hardass
2017-11-10 19:02 NP Hardass
2017-11-05  5:53 NP Hardass
2017-11-05  5:53 NP Hardass
2017-11-05  5:53 NP Hardass
2017-09-30 20:32 NP Hardass
2017-09-29  3:07 NP Hardass
2017-09-24 16:10 NP Hardass
2017-09-24 16:10 NP Hardass
2017-09-13 21:09 NP Hardass
2017-09-13 19:48 NP Hardass
2017-09-13 19:48 NP Hardass
2017-09-13 19:48 NP Hardass
2017-09-13 19:48 NP Hardass
2017-09-13 19:48 NP Hardass
2017-08-23 18:08 Michał Górny
2017-07-17 21:09 NP Hardass
2017-07-10  1:22 NP Hardass
2017-07-10  1:22 NP Hardass
2017-06-01  1:19 NP Hardass
2017-06-01  1:19 NP Hardass
2017-05-13  1:03 NP Hardass
2017-05-04  5:40 NP Hardass
2017-04-21  6:03 NP Hardass
2017-04-21  6:03 NP Hardass
2017-04-12  1:37 NP Hardass
2017-04-10 19:44 NP Hardass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491911186.892e88daf934e116fb9e9b1ee13c1b9bf750a123.np-hardass@gentoo \
    --to=np-hardass@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox