From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 1086E139694 for ; Mon, 10 Apr 2017 18:13:18 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D91CB21C1C9; Mon, 10 Apr 2017 18:12:22 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id B7F1E21C1C9 for ; Mon, 10 Apr 2017 18:12:22 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 4C250340AC7 for ; Mon, 10 Apr 2017 18:12:21 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 73CA8744C for ; Mon, 10 Apr 2017 18:12:18 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1489824913.b18166a8482c01a365b11efa12d72282b88e4d86.ulm@gentoo> Subject: [gentoo-commits] proj/pms:eapi-7 commit in: / X-VCS-Repository: proj/pms X-VCS-Files: ebuild-env-vars.tex X-VCS-Directories: / X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: b18166a8482c01a365b11efa12d72282b88e4d86 X-VCS-Branch: eapi-7 Date: Mon, 10 Apr 2017 18:12:18 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 74395508-7dd5-4e50-8e82-78b6717d7c67 X-Archives-Hash: 74cf8e77fe9aa5369854a4a1da8097d8 commit: b18166a8482c01a365b11efa12d72282b88e4d86 Author: Michał Górny gentoo org> AuthorDate: Sat Mar 18 07:30:40 2017 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Sat Mar 18 08:15:13 2017 +0000 URL: https://gitweb.gentoo.org/proj/pms.git/commit/?id=b18166a8 ebuild-env-vars: Require DISTDIR & FILESDIR to be consistent Require both DISTDIR and FILESDIR variables to have consistent value across phases. We need to guarantee that the value used in global scope to propagate PATCHES array will be still valid in src_prepare(). Furthermore, as Ulrich Müller points out that PMS requires ebuilds to recalculate any value derived from inconsistent variables, therefore colliding with the global-scope assignment. ebuild-env-vars.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ebuild-env-vars.tex b/ebuild-env-vars.tex index 6b74d90..262bcf9 100644 --- a/ebuild-env-vars.tex +++ b/ebuild-env-vars.tex @@ -86,14 +86,14 @@ variable. \t{FILESDIR} & \t{src\_*}, global~scope\footnote{Not necessarily present when installing from a binary package. Ebuilds must not access the directory in global scope.} & - No & + Yes & The full path to a directory where the files from the package's files directory (used for small support files or patches) are available. See section~\ref{sec:package-dirs}. May or may not exist; if a repository provides no support files for the package in question then an ebuild must be prepared for the situation where \t{FILESDIR} points to a non-existent directory. \\ \t{DISTDIR} & Ditto & - No & + Yes & The full path to the directory in which the files in the \t{A} variable are stored. \\ \t{PORTDIR} & \t{src\_*} & From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D6534139695 for ; Mon, 20 Mar 2017 19:28:26 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1B96521C236; Mon, 20 Mar 2017 19:28:26 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id E6DB021C236 for ; Mon, 20 Mar 2017 19:28:25 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 0C2F934112A for ; Mon, 20 Mar 2017 19:28:25 +0000 (UTC) Received: from localhost.localdomain (localhost [IPv6:::1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 339D36F13 for ; Mon, 20 Mar 2017 19:28:23 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1489824913.b18166a8482c01a365b11efa12d72282b88e4d86.ulm@gentoo> Subject: [gentoo-commits] proj/pms:master commit in: / X-VCS-Repository: proj/pms X-VCS-Files: ebuild-env-vars.tex X-VCS-Directories: / X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: b18166a8482c01a365b11efa12d72282b88e4d86 X-VCS-Branch: master Date: Mon, 20 Mar 2017 19:28:23 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: da45df02-84e9-4d0f-a2f1-bd01bd53b79c X-Archives-Hash: 8eeec3ef4731f64ffeda88d3620cdda2 Message-ID: <20170320192823.26APoFWFijUIAcGLQ0a4lhGSNMBmsmA_oijtPfV_ipU@z> commit: b18166a8482c01a365b11efa12d72282b88e4d86 Author: Michał Górny gentoo org> AuthorDate: Sat Mar 18 07:30:40 2017 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Sat Mar 18 08:15:13 2017 +0000 URL: https://gitweb.gentoo.org/proj/pms.git/commit/?id=b18166a8 ebuild-env-vars: Require DISTDIR & FILESDIR to be consistent Require both DISTDIR and FILESDIR variables to have consistent value across phases. We need to guarantee that the value used in global scope to propagate PATCHES array will be still valid in src_prepare(). Furthermore, as Ulrich Müller points out that PMS requires ebuilds to recalculate any value derived from inconsistent variables, therefore colliding with the global-scope assignment. ebuild-env-vars.tex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ebuild-env-vars.tex b/ebuild-env-vars.tex index 6b74d90..262bcf9 100644 --- a/ebuild-env-vars.tex +++ b/ebuild-env-vars.tex @@ -86,14 +86,14 @@ variable. \t{FILESDIR} & \t{src\_*}, global~scope\footnote{Not necessarily present when installing from a binary package. Ebuilds must not access the directory in global scope.} & - No & + Yes & The full path to a directory where the files from the package's files directory (used for small support files or patches) are available. See section~\ref{sec:package-dirs}. May or may not exist; if a repository provides no support files for the package in question then an ebuild must be prepared for the situation where \t{FILESDIR} points to a non-existent directory. \\ \t{DISTDIR} & Ditto & - No & + Yes & The full path to the directory in which the files in the \t{A} variable are stored. \\ \t{PORTDIR} & \t{src\_*} &