* [gentoo-commits] repo/gentoo:master commit in: xfce-base/xfce4-session/files/
@ 2017-02-14 21:37 David Seifert
0 siblings, 0 replies; 4+ messages in thread
From: David Seifert @ 2017-02-14 21:37 UTC (permalink / raw
To: gentoo-commits
commit: 9d7a6656b5ebd4511aa9f9f277908999d0c56dfa
Author: Michael Mair-Keimberger (asterix) <m.mairkeimberger <AT> gmail <DOT> com>
AuthorDate: Sun Feb 12 17:27:19 2017 +0000
Commit: David Seifert <soap <AT> gentoo <DOT> org>
CommitDate: Tue Feb 14 21:34:55 2017 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9d7a6656
xfce-base/xfce4-session: remove unused patch
Closes: https://github.com/gentoo/gentoo/pull/3931
.../files/xfce4-session-4.11.0-upower-0.99.0.patch | 448 ---------------------
1 file changed, 448 deletions(-)
diff --git a/xfce-base/xfce4-session/files/xfce4-session-4.11.0-upower-0.99.0.patch b/xfce-base/xfce4-session/files/xfce4-session-4.11.0-upower-0.99.0.patch
deleted file mode 100644
index a5e59f47f1..0000000000
--- a/xfce-base/xfce4-session/files/xfce4-session-4.11.0-upower-0.99.0.patch
+++ /dev/null
@@ -1,448 +0,0 @@
-Patch from http://bugzilla.xfce.org/show_bug.cgi?id=9952 with modification
-to edit configure.ac (release tarball) instead of configure.ac.in (git)
-
-From 38afe446cdc889266f1e553952397cc4a876ecf8 Mon Sep 17 00:00:00 2001
-From: Eric Koegel <eric.koegel@gmail.com>
-Date: Mon, 7 Jul 2014 11:30:06 +0300
-Subject: [PATCH] Add suspend/hibernate to shutdown-helper
-
-Upower 0.99 dropped support for suspend/hibernate as an obsolete
-feature in this commit:
-http://cgit.freedesktop.org/upower/commit/?id=1ee642e705a63f5ad56a6b55e4bf5c4a64c959b8
-Add that functionality into the shutdown-helper so these features
-will work again. Additionally Upower is an optional build dependency
-and the minimum required is 0.9.7 to support FreeBSD 9 and 10.
----
- configure.ac.in | 30 ++++++++
- xfce4-session/Makefile.am | 4 +-
- xfce4-session/xfsm-shutdown.c | 167 +++++++++++++++++++++++++++++++++++++++++-
- xfce4-session/xfsm-upower.c | 8 +-
- xfce4-session/xfsm-upower.h | 4 +
- xfsm-shutdown-helper/main.c | 26 +++++++
- 6 files changed, 234 insertions(+), 5 deletions(-)
-
-diff --git a/configure.ac b/configure.ac
-index 910fd35..b9c9a90 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -96,6 +96,10 @@ XDT_CHECK_PACKAGE([DBUS], [dbus-1], [1.1.0])
- XDT_CHECK_PACKAGE([DBUS_GLIB], [dbus-glib-1], [0.84])
- XDT_CHECK_PACKAGE([XFCONF], [libxfconf-0], [4.9.0])
-
-+dnl Check for Upower
-+XDT_CHECK_OPTIONAL_PACKAGE([UPOWER],[upower-glib], [0.9.7],
-+ [upower],[Upower support])
-+
- dnl Check for polkit / systemd integration
- XDT_CHECK_OPTIONAL_PACKAGE([SYSTEMD], [polkit-gobject-1], [0.100],
- [systemd], [Systemd support (through polit)])
-@@ -157,6 +161,31 @@ if test "x$linux_ioprio_works" = "xyes"; then
- [Defined if linux/ioprio.h not only exists, but works properly])
- fi
-
-+dnl Compile time default choice of backend
-+AC_ARG_WITH([backend],
-+ AS_HELP_STRING([--with-backend=<option>],
-+ [Default backend to use linux, freebsd, openbsd]))
-+# default to a sane option
-+AC_CANONICAL_HOST
-+if test x$with_backend = x; then
-+ AS_CASE([$host],
-+ [*-linux*], [with_backend=linux],
-+ [*-*freebsd*], [with_backend=freebsd],
-+ [*-openbsd*], [with_backend=openbsd])
-+fi
-+AC_DEFINE_UNQUOTED(BACKEND, "$with_backend", [backend])
-+AC_SUBST(BACKEND, "$with_backend")
-+
-+if test x$with_backend = xlinux; then
-+ AC_DEFINE(BACKEND_TYPE_LINUX, 1, [Linux suspend/hibernate backend])
-+fi
-+if test x$with_backend = xfreebsd; then
-+ AC_DEFINE(BACKEND_TYPE_FREEBSD, 1, [FreeBSD suspend/hibernate backend])
-+fi
-+if test x$with_backend = xopenbsd; then
-+ AC_DEFINE(BACKEND_TYPE_OPENBSD, 1, [OpenBSD suspend/hibernate backend])
-+fi
-+
- dnl check for location Xfce glade files were installed to
- XFCE_GLADE_CATALOG_PATH="`pkg-config --variable glade_catalogdir libxfce4ui-1`"
- XFCE_GLADE_PIXMAP_PATH="`pkg-config --variable glade_pixmapdir libxfce4ui-1`"
-@@ -207,5 +236,6 @@ echo " * Gnome Keyring support: yes"
- else
- echo " * Gnome Keyring support: no"
- fi
-+echo " * Backend: ${with_backend}"
-
- echo
-diff --git a/xfce4-session/Makefile.am b/xfce4-session/Makefile.am
-index 5472b33..6b5968e 100644
---- a/xfce4-session/Makefile.am
-+++ b/xfce4-session/Makefile.am
-@@ -83,7 +83,8 @@ xfce4_session_CFLAGS = \
- $(SYSTEMD_CFLAGS) \
- $(XFCONF_CFLAGS) \
- $(GMODULE_CFLAGS) \
-- $(PLATFORM_CFLAGS)
-+ $(PLATFORM_CFLAGS) \
-+ $(UPOWER_CFLAGS)
-
- xfce4_session_LDFLAGS = \
- -no-undefined \
-@@ -102,6 +103,7 @@ xfce4_session_LDADD = \
- $(LIBWNCK_LIBS) \
- $(SYSTEMD_LIBS) \
- $(XFCONF_LIBS) \
-+ $(UPOWER_LIBS) \
- -lm
-
- xfce4_session_DEPENDENCIES = \
-diff --git a/xfce4-session/xfsm-shutdown.c b/xfce4-session/xfsm-shutdown.c
-index 4c483a7..24b548e 100644
---- a/xfce4-session/xfsm-shutdown.c
-+++ b/xfce4-session/xfsm-shutdown.c
-@@ -57,6 +57,9 @@
- #include <dbus/dbus-glib-lowlevel.h>
- #include <libxfce4util/libxfce4util.h>
- #include <gtk/gtk.h>
-+#ifdef HAVE_UPOWER
-+#include <upower.h>
-+#endif
-
- #include <libxfsm/xfsm-util.h>
-
-@@ -76,6 +79,8 @@
-
- static void xfsm_shutdown_finalize (GObject *object);
- static void xfsm_shutdown_sudo_free (XfsmShutdown *shutdown);
-+static gboolean xfsm_shutdown_fallback_can_hibernate (void);
-+static gboolean xfsm_shutdown_fallback_can_suspend (void);
-
-
-
-@@ -403,14 +408,16 @@ xfsm_shutdown_sudo_try_action (XfsmShutdown *shutdown,
- g_return_val_if_fail (shutdown->helper_state == SUDO_AVAILABLE, FALSE);
- g_return_val_if_fail (shutdown->helper_outfile != NULL, FALSE);
- g_return_val_if_fail (shutdown->helper_infile != NULL, FALSE);
-- g_return_val_if_fail (type == XFSM_SHUTDOWN_SHUTDOWN
-- || type == XFSM_SHUTDOWN_RESTART, FALSE);
-
- /* the command we send to sudo */
- if (type == XFSM_SHUTDOWN_SHUTDOWN)
- action = "POWEROFF";
- else if (type == XFSM_SHUTDOWN_RESTART)
- action = "REBOOT";
-+ else if (type == XFSM_SHUTDOWN_SUSPEND)
-+ action = "SUSPEND";
-+ else if (type == XFSM_SHUTDOWN_HIBERNATE)
-+ action = "HIBERNATE";
- else
- return FALSE;
-
-@@ -692,7 +699,19 @@ xfsm_shutdown_try_suspend (XfsmShutdown *shutdown,
- {
- g_return_val_if_fail (XFSM_IS_SHUTDOWN (shutdown), FALSE);
-
-+#ifdef HAVE_UPOWER
-+#if !UP_CHECK_VERSION(0, 99, 0)
- return xfsm_upower_try_suspend (shutdown->upower, error);
-+#endif /* UP_CHECK_VERSION */
-+#endif /* HAVE_UPOWER */
-+
-+ if (shutdown->helper_state == SUDO_AVAILABLE)
-+ {
-+ xfsm_upower_lock_screen (shutdown->upower, "Suspend", error);
-+ return xfsm_shutdown_sudo_try_action (shutdown, XFSM_SHUTDOWN_SUSPEND, error);
-+ }
-+ else
-+ return FALSE;
- }
-
-
-@@ -703,7 +722,19 @@ xfsm_shutdown_try_hibernate (XfsmShutdown *shutdown,
- {
- g_return_val_if_fail (XFSM_IS_SHUTDOWN (shutdown), FALSE);
-
-+#ifdef HAVE_UPOWER
-+#if !UP_CHECK_VERSION(0, 99, 0)
- return xfsm_upower_try_hibernate (shutdown->upower, error);
-+#endif /* UP_CHECK_VERSION */
-+#endif /* HAVE_UPOWER */
-+
-+ if (shutdown->helper_state == SUDO_AVAILABLE)
-+ {
-+ xfsm_upower_lock_screen (shutdown->upower, "Hibernate", error);
-+ return xfsm_shutdown_sudo_try_action (shutdown, XFSM_SHUTDOWN_HIBERNATE, error);
-+ }
-+ else
-+ return FALSE;
- }
-
-
-@@ -784,8 +815,15 @@ xfsm_shutdown_can_suspend (XfsmShutdown *shutdown,
- return TRUE;
- }
-
-+#ifdef HAVE_UPOWER
-+#if !UP_CHECK_VERSION(0, 99, 0)
- return xfsm_upower_can_suspend (shutdown->upower, can_suspend,
- auth_suspend, error);
-+#endif /* UP_CHECK_VERSION */
-+#endif /* HAVE_UPOWER */
-+
-+ *can_suspend = xfsm_shutdown_fallback_can_suspend ();
-+ return TRUE;
- }
-
-
-@@ -804,8 +842,15 @@ xfsm_shutdown_can_hibernate (XfsmShutdown *shutdown,
- return TRUE;
- }
-
-+#ifdef HAVE_UPOWER
-+#if !UP_CHECK_VERSION(0, 99, 0)
- return xfsm_upower_can_hibernate (shutdown->upower, can_hibernate,
- auth_hibernate, error);
-+#endif /* UP_CHECK_VERSION */
-+#endif /* HAVE_UPOWER */
-+
-+ *can_hibernate = xfsm_shutdown_fallback_can_hibernate ();
-+ return TRUE;
- }
-
-
-@@ -816,3 +861,121 @@ xfsm_shutdown_can_save_session (XfsmShutdown *shutdown)
- g_return_val_if_fail (XFSM_IS_SHUTDOWN (shutdown), FALSE);
- return shutdown->kiosk_can_save_session;
- }
-+
-+
-+
-+#ifdef BACKEND_TYPE_FREEBSD
-+static gchar *
-+get_string_sysctl (GError **err, const gchar *format, ...)
-+{
-+ va_list args;
-+ gchar *name;
-+ size_t value_len;
-+ gchar *str = NULL;
-+
-+ g_return_val_if_fail(format != NULL, FALSE);
-+
-+ va_start (args, format);
-+ name = g_strdup_vprintf (format, args);
-+ va_end (args);
-+
-+ if (sysctlbyname (name, NULL, &value_len, NULL, 0) == 0) {
-+ str = g_new (char, value_len + 1);
-+ if (sysctlbyname (name, str, &value_len, NULL, 0) == 0)
-+ str[value_len] = 0;
-+ else {
-+ g_free (str);
-+ str = NULL;
-+ }
-+ }
-+
-+ if (!str)
-+ g_set_error (err, 0, 0, "%s", g_strerror(errno));
-+
-+ g_free(name);
-+ return str;
-+}
-+
-+
-+
-+static gboolean
-+freebsd_supports_sleep_state (const gchar *state)
-+{
-+ gboolean ret = FALSE;
-+ gchar *sleep_states;
-+
-+ sleep_states = get_string_sysctl (NULL, "hw.acpi.supported_sleep_state");
-+ if (sleep_states != NULL)
-+ {
-+ if (strstr (sleep_states, state) != NULL)
-+ ret = TRUE;
-+ }
-+
-+ g_free (sleep_states);
-+
-+ return ret;
-+}
-+#endif /* BACKEND_TYPE_FREEBSD */
-+
-+
-+
-+#ifdef BACKEND_TYPE_LINUX
-+static gboolean
-+linux_supports_sleep_state (const gchar *state)
-+{
-+ gboolean ret = FALSE;
-+ gchar *command;
-+ GError *error = NULL;
-+ gint exit_status;
-+
-+ /* run script from pm-utils */
-+ command = g_strdup_printf ("/usr/bin/pm-is-supported --%s", state);
-+
-+ ret = g_spawn_command_line_sync (command, NULL, NULL, &exit_status, &error);
-+ if (!ret)
-+ {
-+ g_warning ("failed to run script: %s", error->message);
-+ g_error_free (error);
-+ goto out;
-+ }
-+ ret = (WIFEXITED(exit_status) && (WEXITSTATUS(exit_status) == EXIT_SUCCESS));
-+
-+out:
-+ g_free (command);
-+
-+ return ret;
-+}
-+#endif /* BACKEND_TYPE_LINUX */
-+
-+
-+static gboolean
-+xfsm_shutdown_fallback_can_suspend (void)
-+{
-+#ifdef BACKEND_TYPE_FREEBSD
-+ return freebsd_supports_sleep_state ("S3");
-+#endif
-+#ifdef BACKEND_TYPE_LINUX
-+ return linux_supports_sleep_state ("suspend");
-+#endif
-+#ifdef BACKEND_TYPE_OPENBSD
-+ return TRUE;
-+#endif
-+
-+ return FALSE;
-+}
-+
-+static gboolean
-+xfsm_shutdown_fallback_can_hibernate (void)
-+{
-+#ifdef BACKEND_TYPE_FREEBSD
-+ return freebsd_supports_sleep_state ("S4");
-+#endif
-+#ifdef BACKEND_TYPE_LINUX
-+ return linux_supports_sleep_state ("hibernate");
-+#endif
-+#ifdef BACKEND_TYPE_OPENBSD
-+ return FALSE;
-+#endif
-+
-+ return FALSE;
-+}
-diff --git a/xfce4-session/xfsm-upower.c b/xfce4-session/xfsm-upower.c
-index 57402ec..2960943 100644
---- a/xfce4-session/xfsm-upower.c
-+++ b/xfce4-session/xfsm-upower.c
-@@ -21,6 +21,7 @@
-
- #include <dbus/dbus-glib.h>
- #include <dbus/dbus-glib-lowlevel.h>
-+#include <upower.h>
-
- #include <libxfsm/xfsm-util.h>
- #include <xfce4-session/xfsm-upower.h>
-@@ -283,14 +284,13 @@ xfsm_upower_try_method (XfsmUPower *upower,
-
-
-
--static gboolean
-+gboolean
- xfsm_upower_lock_screen (XfsmUPower *upower,
- const gchar *sleep_kind,
- GError **error)
- {
- XfconfChannel *channel;
- gboolean ret = TRUE;
-- GError *err = NULL;
-
- g_return_val_if_fail (sleep_kind != NULL, FALSE);
-
-@@ -299,6 +299,9 @@ xfsm_upower_lock_screen (XfsmUPower *upower,
- {
- if (xfsm_upower_proxy_ensure (upower, error))
- {
-+#if !UP_CHECK_VERSION(0, 99, 0)
-+ GError *err = NULL;
-+
- /* tell upower we're going to sleep, this saves some
- * time while we sleep 1 second if xflock4 is spawned */
- ret = dbus_g_proxy_call (upower->upower_proxy,
-@@ -312,6 +315,7 @@ xfsm_upower_lock_screen (XfsmUPower *upower,
- g_warning ("Couldn't sent that we were about to sleep: %s", err->message);
- g_error_free (err);
- }
-+#endif
- }
- else
- {
-diff --git a/xfce4-session/xfsm-upower.h b/xfce4-session/xfsm-upower.h
-index a492f7d..4e6a53b 100644
---- a/xfce4-session/xfsm-upower.h
-+++ b/xfce4-session/xfsm-upower.h
-@@ -51,4 +51,8 @@ gboolean xfsm_upower_can_hibernate (XfsmUPower *upower,
- gboolean *auth_hibernate,
- GError **error);
-
-+gboolean xfsm_upower_lock_screen (XfsmUPower *upower,
-+ const gchar *sleep_kind,
-+ GError **error);
-+
- #endif /* !__XFSM_UPOWER_HELPER_H__ */
-diff --git a/xfsm-shutdown-helper/main.c b/xfsm-shutdown-helper/main.c
-index 667f288..60c621b 100644
---- a/xfsm-shutdown-helper/main.c
-+++ b/xfsm-shutdown-helper/main.c
-@@ -57,6 +57,12 @@
- #ifdef REBOOT_CMD
- #undef REBOOT_CMD
- #endif
-+#ifdef UP_BACKEND_SUSPEND_COMMAND
-+#undef UP_BACKEND_SUSPEND_COMMAND
-+#endif
-+#ifdef UP_BACKEND_HIBERNATE_COMMAND
-+#undef UP_BACKEND_HIBERNATE_COMMAND
-+#endif
-
- #if defined(__DragonFly__) || defined(__FreeBSD__) || defined(__NetBSD__) || defined(__OpenBSD__)
- #define POWEROFF_CMD "/sbin/shutdown -p now"
-@@ -68,6 +74,18 @@
- #define POWEROFF_CMD "/sbin/shutdown -h now"
- #define REBOOT_CMD "/sbin/shutdown -r now"
- #endif
-+#ifdef BACKEND_TYPE_FREEBSD
-+#define UP_BACKEND_SUSPEND_COMMAND "/usr/sbin/zzz"
-+#define UP_BACKEND_HIBERNATE_COMMAND "/usr/sbin/acpiconf -s 4"
-+#endif
-+#if BACKEND_TYPE_LINUX
-+#define UP_BACKEND_SUSPEND_COMMAND "/usr/sbin/pm-suspend"
-+#define UP_BACKEND_HIBERNATE_COMMAND "/usr/sbin/pm-hibernate"
-+#endif
-+#ifdef BACKEND_TYPE_OPENBSD
-+#define UP_BACKEND_SUSPEND_COMMAND "/usr/sbin/zzz"
-+#define UP_BACKEND_HIBERNATE_COMMAND "/dev/null"
-+#endif
-
-
- static gboolean
-@@ -143,6 +161,14 @@ main (int argc, char **argv)
- {
- succeed = run (REBOOT_CMD);
- }
-+ else if (strncasecmp (action, "SUSPEND", 7) == 0)
-+ {
-+ succeed = run (UP_BACKEND_SUSPEND_COMMAND);
-+ }
-+ else if (strncasecmp (action, "HIBERNATE", 9) == 0)
-+ {
-+ succeed = run (UP_BACKEND_HIBERNATE_COMMAND);
-+ }
-
- if (succeed)
- {
---
-2.0.0
-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: xfce-base/xfce4-session/files/
@ 2017-04-16 22:25 Michał Górny
0 siblings, 0 replies; 4+ messages in thread
From: Michał Górny @ 2017-04-16 22:25 UTC (permalink / raw
To: gentoo-commits
commit: 1c8846cbd7b136395ac5193e84b3cacf23ccb951
Author: Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Sun Apr 16 22:13:37 2017 +0000
Commit: Michał Górny <mgorny <AT> gentoo <DOT> org>
CommitDate: Sun Apr 16 22:25:35 2017 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1c8846cb
xfce-base/xfce4-session: Convert patches to -p1
.../files/xfce4-session-4.10.1-alock_support_to_xflock4.patch | 4 ++--
.../files/xfce4-session-4.12.1-light-locker_support_to_xflock4.patch | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/xfce-base/xfce4-session/files/xfce4-session-4.10.1-alock_support_to_xflock4.patch b/xfce-base/xfce4-session/files/xfce4-session-4.10.1-alock_support_to_xflock4.patch
index feb020aaff0..0582ecd020a 100644
--- a/xfce-base/xfce4-session/files/xfce4-session-4.10.1-alock_support_to_xflock4.patch
+++ b/xfce-base/xfce4-session/files/xfce4-session-4.10.1-alock_support_to_xflock4.patch
@@ -1,8 +1,8 @@
http://bugs.gentoo.org/501370
http://bugzilla.xfce.org/show_bug.cgi?id=10679
---- scripts/xflock4
-+++ scripts/xflock4
+--- a/scripts/xflock4
++++ b/scripts/xflock4
@@ -35,7 +35,8 @@
# else run another access locking utility, if installed
for lock_cmd in \
diff --git a/xfce-base/xfce4-session/files/xfce4-session-4.12.1-light-locker_support_to_xflock4.patch b/xfce-base/xfce4-session/files/xfce4-session-4.12.1-light-locker_support_to_xflock4.patch
index cb472edfe5d..aac01cfbe9b 100644
--- a/xfce-base/xfce4-session/files/xfce4-session-4.12.1-light-locker_support_to_xflock4.patch
+++ b/xfce-base/xfce4-session/files/xfce4-session-4.12.1-light-locker_support_to_xflock4.patch
@@ -1,5 +1,5 @@
---- scripts/xflock4.orig 2016-02-02 10:40:15.726495183 -0700
-+++ scripts/xflock4 2016-02-02 10:43:17.548061336 -0700
+--- a/scripts/xflock4 2016-02-02 10:40:15.726495183 -0700
++++ b/scripts/xflock4 2016-02-02 10:43:17.548061336 -0700
@@ -24,10 +24,12 @@
PATH=/bin:/usr/bin
export PATH
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: xfce-base/xfce4-session/files/
@ 2019-03-04 3:14 Aaron Bauman
0 siblings, 0 replies; 4+ messages in thread
From: Aaron Bauman @ 2019-03-04 3:14 UTC (permalink / raw
To: gentoo-commits
commit: 54c3c73a922eb66b13e44ea2aac4251065b51dc2
Author: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail <DOT> com>
AuthorDate: Fri Mar 1 17:36:40 2019 +0000
Commit: Aaron Bauman <bman <AT> gentoo <DOT> org>
CommitDate: Mon Mar 4 03:12:46 2019 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=54c3c73a
xfce-base/xfce4-session: remove unused patch
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/11196
Signed-off-by: Aaron Bauman <bman <AT> gentoo.org>
...e4-session-4.13.0-add-edit-autostart-segv.patch | 57 ----------------------
1 file changed, 57 deletions(-)
diff --git a/xfce-base/xfce4-session/files/xfce4-session-4.13.0-add-edit-autostart-segv.patch b/xfce-base/xfce4-session/files/xfce4-session-4.13.0-add-edit-autostart-segv.patch
deleted file mode 100644
index ff5b805d322..00000000000
--- a/xfce-base/xfce4-session/files/xfce4-session-4.13.0-add-edit-autostart-segv.patch
+++ /dev/null
@@ -1,57 +0,0 @@
-From 193b09a9c159d1d16ad69e4298f48c2b531e9392 Mon Sep 17 00:00:00 2001
-From: Eric Koegel <eric.koegel@gmail.com>
-Date: Mon, 1 May 2017 06:55:05 +0300
-Subject: Add/Edit Application Autostart Entries (Bug #13271)
-
-With xfce4-session built from git (after the gtk3
-migration work), trying to add or edit an application
-autostart entry results in a segmentation fault after a
-"(xfce4-session-settings:9094): Gtk-CRITICAL **:
-gtk_entry_get_text: assertion 'GTK_IS_ENTRY (entry)'
-failed" message.
-
-It appears that when the "notify::text" signal callbacks
-for the "command_entry" and "name_entry" GtkEntry objects
-are created, they are called immediately, before the second
-GtkEntry object is created resulting in a failure in the
-xfae_dialog_update() function to properly process the objects.
-Thanks to ToZ for reporting and providing the fix.
----
- settings/xfae-dialog.c | 11 +++++++----
- 1 file changed, 7 insertions(+), 4 deletions(-)
-
-diff --git a/settings/xfae-dialog.c b/settings/xfae-dialog.c
-index af860b9..7442634 100644
---- a/settings/xfae-dialog.c
-+++ b/settings/xfae-dialog.c
-@@ -98,8 +98,7 @@ xfae_dialog_init (XfaeDialog *dialog)
- dialog->name_entry = g_object_new (GTK_TYPE_ENTRY,
- "activates-default", TRUE,
- NULL);
-- g_signal_connect_swapped (G_OBJECT (dialog->name_entry), "notify::text",
-- G_CALLBACK (xfae_dialog_update), dialog);
-+
- gtk_grid_attach (GTK_GRID (grid), dialog->name_entry, 1, 0, 1, 1);
- gtk_widget_show (dialog->name_entry);
-
-@@ -132,11 +131,15 @@ xfae_dialog_init (XfaeDialog *dialog)
- dialog->command_entry = g_object_new (GTK_TYPE_ENTRY,
- "activates-default", TRUE,
- NULL);
-- g_signal_connect_swapped (G_OBJECT (dialog->command_entry), "notify::text",
-- G_CALLBACK (xfae_dialog_update), dialog);
-+
- gtk_box_pack_start (GTK_BOX (hbox), dialog->command_entry, TRUE, TRUE, 0);
- gtk_widget_show (dialog->command_entry);
-
-+ g_signal_connect_swapped (G_OBJECT (dialog->name_entry), "notify::text",
-+ G_CALLBACK (xfae_dialog_update), dialog);
-+ g_signal_connect_swapped (G_OBJECT (dialog->command_entry), "notify::text",
-+ G_CALLBACK (xfae_dialog_update), dialog);
-+
- button = g_object_new (GTK_TYPE_BUTTON,
- "can-default", FALSE,
- NULL);
---
-cgit v1.1
-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [gentoo-commits] repo/gentoo:master commit in: xfce-base/xfce4-session/files/
@ 2019-06-18 0:35 Aaron Bauman
0 siblings, 0 replies; 4+ messages in thread
From: Aaron Bauman @ 2019-06-18 0:35 UTC (permalink / raw
To: gentoo-commits
commit: c90faff75f9c20b4710e8c6cbe206d88c5ed654f
Author: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail <DOT> com>
AuthorDate: Mon Jun 3 17:52:48 2019 +0000
Commit: Aaron Bauman <bman <AT> gentoo <DOT> org>
CommitDate: Tue Jun 18 00:34:57 2019 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c90faff7
xfce-base/xfce4-session: remove unused patch
Signed-off-by: Michael Mair-Keimberger <m.mairkeimberger <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/12183
Signed-off-by: Aaron Bauman <bman <AT> gentoo.org>
.../xfce4-session-4.13.1-kill-dbus-includes.patch | 43 ----------------------
1 file changed, 43 deletions(-)
diff --git a/xfce-base/xfce4-session/files/xfce4-session-4.13.1-kill-dbus-includes.patch b/xfce-base/xfce4-session/files/xfce4-session-4.13.1-kill-dbus-includes.patch
deleted file mode 100644
index cc5bb9d653e..00000000000
--- a/xfce-base/xfce4-session/files/xfce4-session-4.13.1-kill-dbus-includes.patch
+++ /dev/null
@@ -1,43 +0,0 @@
-From 3bddf152b902d8a1e0f674b792577b2cca635c4b Mon Sep 17 00:00:00 2001
-From: Brandon Bergren <xfce@bdragon.rtk0.net>
-Date: Sun, 26 Aug 2018 10:28:05 -0400
-Subject: [PATCH] fix build failure when dbus is not in the system include path
- (Bug #14386)
-
-The d-bus direct depenencies were taken out in 91860af3a38080,
-but the #include <dbus/dbus.h> in xfce4-session/xfsm-global.h
-and the #include <dbus/dbus-glib.h> line in xfsm-error.c got left
-in accidentally.
----
- xfce4-session/xfsm-error.c | 2 --
- xfce4-session/xfsm-global.h | 1 -
- 2 files changed, 3 deletions(-)
-
-diff --git a/xfce4-session/xfsm-error.c b/xfce4-session/xfsm-error.c
-index 2b7f6c04..f0766f5f 100644
---- a/xfce4-session/xfsm-error.c
-+++ b/xfce4-session/xfsm-error.c
-@@ -20,8 +20,6 @@
- #include <config.h>
- #endif
-
--#include <dbus/dbus-glib.h>
--
- #include <xfce4-session/xfsm-error.h>
-
- #define XFSM_DBUS_NAME "org.xfce.SessionManager"
-diff --git a/xfce4-session/xfsm-global.h b/xfce4-session/xfsm-global.h
-index d4587123..610d5bf7 100644
---- a/xfce4-session/xfsm-global.h
-+++ b/xfce4-session/xfsm-global.h
-@@ -27,7 +27,6 @@
- #include <X11/SM/SMlib.h>
-
- #include <xfce4-session/xfsm-splash-screen.h>
--#include <dbus/dbus.h>
-
- typedef struct _FailsafeClient FailsafeClient;
- struct _FailsafeClient
---
-2.19.0
-
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-18 0:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 21:37 [gentoo-commits] repo/gentoo:master commit in: xfce-base/xfce4-session/files/ David Seifert
-- strict thread matches above, loose matches on Subject: below --
2017-04-16 22:25 Michał Górny
2019-03-04 3:14 Aaron Bauman
2019-06-18 0:35 Aaron Bauman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox