[gentoo-commits] proj/pax-utils:master commit in: /

["Mike Frysinger" <vapier@gentoo.org>]

commit:     277b33961e9e794ad039d22e1b9186d38d9e0aea
Author:     Mike Frysinger <vapier <AT> gentoo <DOT> org>
AuthorDate: Tue Jan 24 20:24:53 2017 +0000
Commit:     Mike Frysinger <vapier <AT> gentoo <DOT> org>
CommitDate: Tue Jan 24 20:24:53 2017 +0000
URL:        https://gitweb.gentoo.org/proj/pax-utils.git/commit/?id=277b3396

TODO: drop fixed issues and add some new ones

 TODO | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/TODO b/TODO
index ded1158..3c9968c 100644
--- a/TODO
+++ b/TODO
@@ -9,17 +9,10 @@ care though ?  this would be an issue if:
  - object being analyzed is 64bit
  - object has symbols which is larger than 32bits
 
-scanelf does not check offsets of DT's when scanning PT_DYNAMIC ... if a bogus
-ELF had a PHDR of type PT_DYNAMIC which claimed to be of size say 1 and had an
-offset just shy of the end of the file, we'll probably crash ...
-
 dumpelf does not do string checking in very very verbose mode.  it assumes the
 strings are sane when dumping the sections.  only way around this is to check
 everything single byte and print it out a character at a time ... sucks ...
 
-we look at the section named ".text" for TEXTRELs when we should look at the
-PT_LOAD program headers which are marked Executable.
-
 we don't handle versioned symbols well.  take an ELF with debugging and do:
 	scanelf -s '' elf
 notice that glibc symbols generally have version info.  then search for that:
@@ -34,3 +27,7 @@ allow digging into ARM_ATTRIBUTES (.ARM.attributes) sections
 scanelf should look at the dynamic table for rpath/needed/soname entries instead
 of requiring section headers and looking up by section names.  need to implement
 support for GNU_HASH first though so we can get the string table sizes.
+
+rewrite elf->e_shnum handling.  if it's 0 (SH_UNDEF), then the size is
+contained in the sh_size of the first section header at index 0.  add a
+source code check too.