public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Mart Raudsepp" <leio@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/grumpy:master commit in: backend/lib/
Date: Sun, 22 Jan 2017 11:59:16 +0000 (UTC)	[thread overview]
Message-ID: <1485086244.fab9c6f0ce09830aa95fc3bdfe09c03663094660.leio@gentoo> (raw)

commit:     fab9c6f0ce09830aa95fc3bdfe09c03663094660
Author:     Mart Raudsepp <leio <AT> gentoo <DOT> org>
AuthorDate: Sun Jan 22 11:57:24 2017 +0000
Commit:     Mart Raudsepp <leio <AT> gentoo <DOT> org>
CommitDate: Sun Jan 22 11:57:24 2017 +0000
URL:        https://gitweb.gentoo.org/proj/grumpy.git/commit/?id=fab9c6f0

sync: Fix pkg sync for packages that have a same named pkg in another category

Also fixes an InstrumentedList issue due to change from the categories.packages
relationship from dynamic loading to select in commit 8d90fa1009 having broken
that earlier

 backend/lib/sync.py | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/backend/lib/sync.py b/backend/lib/sync.py
index d292291..7c499b5 100644
--- a/backend/lib/sync.py
+++ b/backend/lib/sync.py
@@ -131,12 +131,6 @@ def sync_categories():
 
 def sync_packages():
     for category in Category.query.all():
-        if not category.packages:
-            print('Category %s has no packages' % category.name)
-            existing_packages = []
-        else:
-            existing_packages = category.packages.all()
-
         data = http_session.get(pkg_url_base + "categories/" + category.name + ".json")
         if not data:
             print("No JSON data for category %s" % category.name) # FIXME: Better handling; mark category as inactive/gone?
@@ -144,7 +138,7 @@ def sync_packages():
         packages = data.json()['packages']
         # TODO: Use UPSERT instead (on_conflict_do_update)
 
-        existing_packages = {pkg.name: pkg for pkg in Package.query.all()}
+        existing_packages = {pkg.name: pkg for pkg in category.packages}
 
         for package in packages:
             if package['name'] in existing_packages:


             reply	other threads:[~2017-01-22 11:59 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-22 11:59 Mart Raudsepp [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-01-23  0:06 [gentoo-commits] proj/grumpy:master commit in: backend/lib/ Gilles Dartiguelongue
2017-01-22 17:46 Gilles Dartiguelongue
2017-01-22 17:13 Gilles Dartiguelongue
2017-01-22 12:36 Gilles Dartiguelongue
2017-01-22 12:36 Gilles Dartiguelongue
2017-01-22 12:36 Gilles Dartiguelongue
2017-01-22 12:24 Gilles Dartiguelongue
2017-01-22 12:24 Gilles Dartiguelongue
2017-01-22 12:24 Gilles Dartiguelongue
2017-01-22 12:08 Mart Raudsepp
2017-01-22 12:00 Gilles Dartiguelongue
2017-01-22 12:00 Gilles Dartiguelongue
2017-01-22 11:04 Gilles Dartiguelongue
2017-01-22 11:04 Gilles Dartiguelongue
2016-12-07  7:10 Mart Raudsepp
2016-12-07  4:42 Mart Raudsepp
2016-12-07  2:53 Mart Raudsepp
2016-12-07  2:40 Mart Raudsepp
2016-12-07  2:10 Mart Raudsepp
2016-12-07  1:58 Mart Raudsepp
2016-12-07  1:58 Mart Raudsepp
2016-12-07  0:34 Mart Raudsepp
2016-12-05 17:46 Mart Raudsepp
2016-12-04  8:04 Mart Raudsepp
2016-12-04  8:04 Mart Raudsepp
2016-12-04  7:44 Mart Raudsepp
2016-12-04  6:27 Mart Raudsepp
2016-12-04  6:27 Mart Raudsepp
2016-12-04  5:26 Mart Raudsepp
2016-12-04  5:26 Mart Raudsepp
2016-12-04  4:56 Mart Raudsepp
2016-11-11  1:22 Mart Raudsepp
2016-11-10 15:50 Mart Raudsepp
2016-09-24  7:02 Mart Raudsepp
2016-09-07 20:21 Mart Raudsepp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485086244.fab9c6f0ce09830aa95fc3bdfe09c03663094660.leio@gentoo \
    --to=leio@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox