From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 17394139085 for ; Tue, 20 Dec 2016 22:21:40 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 73556E0E98; Tue, 20 Dec 2016 22:21:38 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 53C87E0E98 for ; Tue, 20 Dec 2016 22:21:38 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 70319340FA4 for ; Tue, 20 Dec 2016 22:21:36 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 1122B24DF for ; Tue, 20 Dec 2016 22:21:35 +0000 (UTC) From: "Mike Frysinger" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Mike Frysinger" Message-ID: <1482272467.59211623564fe3e7636eeab5255cd732d9f1aee8.vapier@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: net-misc/openssh/ X-VCS-Repository: repo/gentoo X-VCS-Files: net-misc/openssh/openssh-7.3_p1-r8.ebuild X-VCS-Directories: net-misc/openssh/ X-VCS-Committer: vapier X-VCS-Committer-Name: Mike Frysinger X-VCS-Revision: 59211623564fe3e7636eeab5255cd732d9f1aee8 X-VCS-Branch: master Date: Tue, 20 Dec 2016 22:21:35 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: b8e4bb4d-2c95-4254-83bf-8880e9953f43 X-Archives-Hash: 86433e333e730a9b8875a4e70b4a2219 commit: 59211623564fe3e7636eeab5255cd732d9f1aee8 Author: Mike Frysinger gentoo org> AuthorDate: Tue Dec 20 20:08:07 2016 +0000 Commit: Mike Frysinger gentoo org> CommitDate: Tue Dec 20 22:21:07 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59211623 net-misc/openssh: clean up test code a bit Use arrays instead of a flat scalar, and clean up the warning/error output. net-misc/openssh/openssh-7.3_p1-r8.ebuild | 37 +++++++++++++------------------ 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/net-misc/openssh/openssh-7.3_p1-r8.ebuild b/net-misc/openssh/openssh-7.3_p1-r8.ebuild index a03905c..f886839 100644 --- a/net-misc/openssh/openssh-7.3_p1-r8.ebuild +++ b/net-misc/openssh/openssh-7.3_p1-r8.ebuild @@ -272,37 +272,32 @@ src_install() { } src_test() { - local t tests skipped failed passed shell - tests="interop-tests compat-tests" - skipped="" - shell=$(egetshell ${UID}) + local t skipped=() failed=() passed=() + local tests=( interop-tests compat-tests ) + + local shell=$(egetshell "${UID}") if [[ ${shell} == */nologin ]] || [[ ${shell} == */false ]] ; then - elog "Running the full OpenSSH testsuite" - elog "requires a usable shell for the 'portage'" + elog "Running the full OpenSSH testsuite requires a usable shell for the 'portage'" elog "user, so we will run a subset only." - skipped="${skipped} tests" + skipped+=( tests ) else - tests="${tests} tests" + tests+=( tests ) fi - # It will also attempt to write to the homedir .ssh + + # It will also attempt to write to the homedir .ssh. local sshhome=${T}/homedir mkdir -p "${sshhome}"/.ssh - for t in ${tests} ; do + for t in "${tests[@]}" ; do # Some tests read from stdin ... HOMEDIR="${sshhome}" HOME="${sshhome}" \ emake -k -j1 ${t}