public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Austin English" <wizardedit@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/eselect-java:master commit in: src/scripts/
Date: Mon, 28 Nov 2016 22:19:50 +0000 (UTC)	[thread overview]
Message-ID: <1480361242.3c3ba13a37b10d693a622ff974223401df5698da.wizardedit@gentoo> (raw)

commit:     3c3ba13a37b10d693a622ff974223401df5698da
Author:     Austin English <wizardedit <AT> gentoo <DOT> org>
AuthorDate: Mon Nov 28 19:26:49 2016 +0000
Commit:     Austin English <wizardedit <AT> gentoo <DOT> org>
CommitDate: Mon Nov 28 19:27:22 2016 +0000
URL:        https://gitweb.gentoo.org/proj/eselect-java.git/commit/?id=3c3ba13a

src/scripts/run-java-tool.bash.in: fix shellcheck issues

 src/scripts/run-java-tool.bash.in | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/scripts/run-java-tool.bash.in b/src/scripts/run-java-tool.bash.in
index 67e4dba..9c57fe8 100644
--- a/src/scripts/run-java-tool.bash.in
+++ b/src/scripts/run-java-tool.bash.in
@@ -24,6 +24,7 @@ vm_handle=${vmpath##*/}
 
 toolpath=$(
 	export PATH=
+        # shellcheck disable=SC1090
 	. "@GENTOO_PORTAGE_EPREFIX@/usr/share/java-config-2/vm/${vm_handle}" 2> /dev/null
 	: ${PATH:=${vmpath}/bin:${vmpath}/jre/bin}
 	command -v "${tool}" 2> /dev/null
@@ -48,7 +49,7 @@ else
 		else
 			echo "* ${tool} is not available for ${vm_handle} on $(uname -m)" >&2
 			echo "* IMPORTANT: some Java tools are not available on some VMs on some architectures" >&2
-			if [ "$(id -u)" != 0 ] && [ -n "${DISPLAY}" ] && type notify-send > /dev/null; then
+			if [ "$(id -u)" != 0 ] && [ -n "${DISPLAY}" ] && command -v notify-send > /dev/null; then
 				notify-send -i java-icon48 "Gentoo Java Launcher" "<b>${tool}</b> is not available for ${vm_handle}
 <a href=\"https://wiki.gentoo.org/wiki/Java\">Gentoo Java User Guide</a>"
 			fi


             reply	other threads:[~2016-11-28 22:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 22:19 Austin English [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-09-17  8:26 [gentoo-commits] proj/eselect-java:master commit in: src/scripts/ Georgy Yakovlev
2016-11-28 22:19 Austin English
2016-01-01  0:03 James Le Cuirot
2016-01-01  0:03 James Le Cuirot
2016-01-01  0:03 James Le Cuirot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480361242.3c3ba13a37b10d693a622ff974223401df5698da.wizardedit@gentoo \
    --to=wizardedit@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox