From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 0CA051395E1 for ; Tue, 1 Nov 2016 06:44:06 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5F72621C012; Tue, 1 Nov 2016 06:44:04 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4879621C012 for ; Tue, 1 Nov 2016 06:44:04 +0000 (UTC) Received: from oystercatcher.gentoo.org (oystercatcher.gentoo.org [148.251.78.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 175B6340FA4 for ; Tue, 1 Nov 2016 06:44:01 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 25A27248D for ; Tue, 1 Nov 2016 06:43:59 +0000 (UTC) From: "Ulrich Müller" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Ulrich Müller" Message-ID: <1477902655.6e078f8a6e665f473bbf96668f13871e6119e0d8.ulm@gentoo> Subject: [gentoo-commits] proj/eselect:master commit in: libs/, / X-VCS-Repository: proj/eselect X-VCS-Files: ChangeLog README libs/core.bash.in X-VCS-Directories: / libs/ X-VCS-Committer: ulm X-VCS-Committer-Name: Ulrich Müller X-VCS-Revision: 6e078f8a6e665f473bbf96668f13871e6119e0d8 X-VCS-Branch: master Date: Tue, 1 Nov 2016 06:43:59 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 9d8b9263-9066-44ac-9e56-a7100576e75c X-Archives-Hash: 8918ee447b209093fe3678f7ec5750a6 commit: 6e078f8a6e665f473bbf96668f13871e6119e0d8 Author: Ulrich Müller gentoo org> AuthorDate: Mon Oct 31 08:30:55 2016 +0000 Commit: Ulrich Müller gentoo org> CommitDate: Mon Oct 31 08:30:55 2016 +0000 URL: https://gitweb.gentoo.org/proj/eselect.git/commit/?id=6e078f8a Disable eval again. * libs/core.bash.in (eval): Disable eval again, because the workaround for the rc module (sourcing functions.sh) is no longer needed. See also 2005-05-15 change by ciaranm. This partially reverts commit 76867bf1a47570cd9548100caed519252b5ced5a. ChangeLog | 6 ++++++ README | 2 +- libs/core.bash.in | 6 ++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index c7a54f6..80bc483 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2016-10-31 Ulrich Müller + + * libs/core.bash.in (eval): Disable eval again, because the + workaround for the rc module (sourcing functions.sh) is no longer + needed. See also 2005-05-15 change by ciaranm. + 2016-10-30 Ulrich Müller * configure.ac: Update version to 1.4.7. diff --git a/README b/README index 945dc41..de19882 100644 --- a/README +++ b/README @@ -34,7 +34,7 @@ Style Notes one tab per indent level, with each tab representing 4 places. * Avoid lines wider than 79 positions. * Public functions don't get the ``es_`` prefix, private functions do. -* eval is evil, so don't use it. +* eval is evil, so we disabled it. * Absolute paths to executables are not portable, so don't use them. diff --git a/libs/core.bash.in b/libs/core.bash.in index baddfde..da35ee9 100644 --- a/libs/core.bash.in +++ b/libs/core.bash.in @@ -119,6 +119,12 @@ inherit() { done } +# make eval not work, because it's evil +eval() { + write_warning_msg "Don't use eval. Find another way." + builtin eval "$@" +} + # GNU sed wrapper (sed or gsed, as determined by configure) sed() { command @SED@ "$@"