From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 5D7F1138CD4 for ; Mon, 24 Oct 2016 16:49:42 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id B1908E0AA9; Mon, 24 Oct 2016 16:49:38 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 96177E0AA9 for ; Mon, 24 Oct 2016 16:49:38 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 85CE73413F6 for ; Mon, 24 Oct 2016 16:49:36 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id 54BCC304 for ; Mon, 24 Oct 2016 16:49:35 +0000 (UTC) From: "Robin H. Johnson" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Robin H. Johnson" Message-ID: <1477327490.7e3c6ff7af8c1559301bf1e28f1b9c8188c519ac.robbat2@OpenRC> Subject: [gentoo-commits] proj/netifrc:master commit in: net/ X-VCS-Repository: proj/netifrc X-VCS-Files: net/iproute2.sh X-VCS-Directories: net/ X-VCS-Committer: robbat2 X-VCS-Committer-Name: Robin H. Johnson X-VCS-Revision: 7e3c6ff7af8c1559301bf1e28f1b9c8188c519ac X-VCS-Branch: master Date: Mon, 24 Oct 2016 16:49:35 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 83e98cb9-1045-4393-b70e-463582ffb95c X-Archives-Hash: d69680ab3d09e2df1ac46dde2d701280 commit: 7e3c6ff7af8c1559301bf1e28f1b9c8188c519ac Author: Robin H. Johnson gentoo org> AuthorDate: Mon Oct 24 16:44:45 2016 +0000 Commit: Robin H. Johnson gentoo org> CommitDate: Mon Oct 24 16:44:50 2016 +0000 URL: https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=7e3c6ff7 net/iproute2: IPv6 DAD delay must be non-fatal. Commit 50c9fd7827fa58d27a593c8c480068f85c047cec introduced a subtle accidental change in the handling of IPv6 tentative addresses. In an environment where the DAD completion time exceeds the configured timeout (which was also reduced to 5 seconds, while the docs say 10 seconds), the interface was recorded as failing to start when the timeout was hit without DAD completion. This means that the interface was then marked as failed and later services did not start. No rollback took place either. Signed-off-by: Robin H. Johnson gentoo.org> net/iproute2.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/iproute2.sh b/net/iproute2.sh index 9ef704d..32d3c88 100644 --- a/net/iproute2.sh +++ b/net/iproute2.sh @@ -441,6 +441,8 @@ iproute2_post_start() [ -z "$policyroute_order" ] && policyroute_order=${policy_rules_before_routes:-no} yesno "$policyroute_order" || _iproute2_policy_routing + # This block must be non-fatal, otherwise the interface will not be + # recorded as starting, and later services may be blocked. if _iproute2_ipv6_tentative; then einfon "Waiting for IPv6 addresses (${_dad_timeout} seconds) " while [ $_dad_timeout -gt 0 ]; do @@ -454,7 +456,6 @@ iproute2_post_start() if [ $_dad_timeout -le 0 ]; then eend 1 - return 1 else eend 0 fi