public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Tobias Klausmann" <klausman@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: sys-process/cronbase/files/, sys-process/cronbase/
Date: Mon,  3 Oct 2016 17:19:12 +0000 (UTC)	[thread overview]
Message-ID: <1475515148.d2d619f187661a12b4ed0dfed504fba057251f92.klausman@gentoo> (raw)

commit:     d2d619f187661a12b4ed0dfed504fba057251f92
Author:     Tobias Klausmann <klausman <AT> gentoo <DOT> org>
AuthorDate: Mon Oct  3 17:17:57 2016 +0000
Commit:     Tobias Klausmann <klausman <AT> gentoo <DOT> org>
CommitDate: Mon Oct  3 17:19:08 2016 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2d619f1

sys-process/cronbase: Fix the parall-job check once and for all.

Thanks to Dan Goodliffe for suggesting this approach.

Gentoo-Bug: 595492

 .../cronbase/{cronbase-0.3.7-r4.ebuild => cronbase-0.3.7-r5.ebuild} | 0
 sys-process/cronbase/files/run-crons-0.3.7                          | 6 +-----
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/sys-process/cronbase/cronbase-0.3.7-r4.ebuild b/sys-process/cronbase/cronbase-0.3.7-r5.ebuild
similarity index 100%
rename from sys-process/cronbase/cronbase-0.3.7-r4.ebuild
rename to sys-process/cronbase/cronbase-0.3.7-r5.ebuild

diff --git a/sys-process/cronbase/files/run-crons-0.3.7 b/sys-process/cronbase/files/run-crons-0.3.7
index 958ef06..902794e 100755
--- a/sys-process/cronbase/files/run-crons-0.3.7
+++ b/sys-process/cronbase/files/run-crons-0.3.7
@@ -56,11 +56,7 @@ grab_lock() {
 
 		# This is better than kill -0 because we can verify that it's really
 		# another run-crons process.
-		# The tr call deletes null bytes so newer bash versions do not complain
-		# about them.
-		cmdline1=$(sed -e 's/\0/ /g' "/proc/${cronpid}/cmdline" 2>/dev/null) || :
-		cmdline2=$(sed -e 's/\0/ /g' /proc/$$/cmdline)
-		if [ "${cmdline1}" = "${cmdline2}" ] ; then
+		if diff -qs /proc/{${cronpid},$$}/cmdline > /dev/null 2>&1; then
 			# Whoa, another run-crons is really running.
 			return 1
 		fi


             reply	other threads:[~2016-10-03 17:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 17:19 Tobias Klausmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-10-02  8:48 [gentoo-commits] repo/gentoo:master commit in: sys-process/cronbase/files/, sys-process/cronbase/ Tobias Klausmann
2016-09-30 14:17 Tobias Klausmann
2016-03-15  2:33 Mike Frysinger
2015-08-19 21:49 Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475515148.d2d619f187661a12b4ed0dfed504fba057251f92.klausman@gentoo \
    --to=klausman@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox