public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "David Seifert" <soap@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: media-sound/clementine/, media-sound/clementine/files/
Date: Tue, 13 Sep 2016 08:04:36 +0000 (UTC)	[thread overview]
Message-ID: <1473752962.1d8124918ec0cf8cec6dbac8aa84cbd84855b2ea.soap@gentoo> (raw)

commit:     1d8124918ec0cf8cec6dbac8aa84cbd84855b2ea
Author:     Alexander Golubev <fatzer2 <AT> gmail <DOT> com>
AuthorDate: Mon Sep 12 17:27:32 2016 +0000
Commit:     David Seifert <soap <AT> gentoo <DOT> org>
CommitDate: Tue Sep 13 07:49:22 2016 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d812491

media-sound/clementine: fix desktop file QA notice

This fixes QA notice complaning that OnlyShowIn key for action groups is
deprecated.
See gentoo bug 460412#3
Closes: https://github.com/gentoo/gentoo/pull/2311

Signed-off-by: David Seifert <soap <AT> gentoo.org>

 ...-1.3.1-r2.ebuild => clementine-1.3.1-r3.ebuild} |  1 +
 .../files/clementine-1.3.1-fix-desktop-file.patch  | 52 ++++++++++++++++++++++
 2 files changed, 53 insertions(+)

diff --git a/media-sound/clementine/clementine-1.3.1-r2.ebuild b/media-sound/clementine/clementine-1.3.1-r3.ebuild
similarity index 99%
rename from media-sound/clementine/clementine-1.3.1-r2.ebuild
rename to media-sound/clementine/clementine-1.3.1-r3.ebuild
index 18f42ef..d0baf97 100644
--- a/media-sound/clementine/clementine-1.3.1-r2.ebuild
+++ b/media-sound/clementine/clementine-1.3.1-r3.ebuild
@@ -94,6 +94,7 @@ S="${WORKDIR}/${MY_P^}"
 
 PATCHES=(
 	"${FILESDIR}"/${PN}-1.3-fix-tokenizer.patch
+	"${FILESDIR}"/${P}-fix-desktop-file.patch
 )
 
 src_prepare() {

diff --git a/media-sound/clementine/files/clementine-1.3.1-fix-desktop-file.patch b/media-sound/clementine/files/clementine-1.3.1-fix-desktop-file.patch
new file mode 100644
index 00000000..bb56131
--- /dev/null
+++ b/media-sound/clementine/files/clementine-1.3.1-fix-desktop-file.patch
@@ -0,0 +1,52 @@
+This patch fixes gentoo QA notices against the desktop file (see gentoo bug 460412#3)
+Based upon patch extracted from upstream git; original patch info:
+commit 04f73d125365d97fa6f72677ec5d220292690e56
+Author: Golubev Alexander <fatzer2@gmail.com>
+Date:   Mon Jul 18 13:45:03 2016 +0400
+
+    Remove OnlyShowIn=Unity from clementine.desktop's action sections (#5444)
+
+diff --git a/dist/clementine.desktop b/dist/clementine.desktop
+index 2fb9559..9ee881e 100644
+--- a/dist/clementine.desktop
++++ b/dist/clementine.desktop
+@@ -38,7 +38,6 @@ Actions=Play;Pause;Stop;Previous;Next;
+ [Desktop Action Play]
+ Name=Play
+ Exec=clementine --play
+-OnlyShowIn=Unity;
+ Name[af]=Speel
+ Name[be]=Прайграць
+ Name[bg]=Възпроизвеждане
+@@ -89,7 +88,6 @@ Name[zh_TW]=播放
+ [Desktop Action Pause]
+ Name=Pause
+ Exec=clementine --pause
+-OnlyShowIn=Unity;
+ Name[be]=Прыпыніць
+ Name[bg]=Пауза
+ Name[br]=Ehan
+@@ -135,7 +133,6 @@ Name[zh_TW]=暫停
+ [Desktop Action Stop]
+ Name=Stop
+ Exec=clementine --stop
+-OnlyShowIn=Unity;
+ Name[be]=Спыніць
+ Name[bg]=Спиране
+ Name[br]=Paouez
+@@ -184,7 +181,6 @@ Name[zh_TW]=停止
+ [Desktop Action Previous]
+ Name=Previous
+ Exec=clementine --previous
+-OnlyShowIn=Unity;
+ Name[af]=Vorige
+ Name[be]=Папярэдні
+ Name[bg]=Предишна
+@@ -232,7 +228,6 @@ Name[zh_TW]=往前
+ [Desktop Action Next]
+ Name=Next
+ Exec=clementine --next
+-OnlyShowIn=Unity;
+ Name[af]=Volgende
+ Name[be]=Далей
+ Name[bg]=Следваща


             reply	other threads:[~2016-09-13  8:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13  8:04 David Seifert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-02 12:32 [gentoo-commits] repo/gentoo:master commit in: media-sound/clementine/, media-sound/clementine/files/ Viorel Munteanu
2020-05-28  8:56 Lars Wendler
2018-12-02 18:43 Andreas Sturmlechner
2018-12-02 18:43 Andreas Sturmlechner
2018-04-26  3:32 Andreas Sturmlechner
2018-03-22 18:02 Andreas Sturmlechner
2017-12-08 18:32 Andreas Sturmlechner
2017-11-21 10:19 Andreas Sturmlechner
2017-05-16 19:53 Lars Wendler
2017-01-04 15:07 Lars Wendler
2016-12-26 16:14 Lars Wendler
2016-05-03 14:59 Lars Wendler
2016-04-27 12:22 Lars Wendler
2016-04-17  4:33 Jason Donenfeld
2016-03-16  0:48 Jason Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1473752962.1d8124918ec0cf8cec6dbac8aa84cbd84855b2ea.soap@gentoo \
    --to=soap@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox