From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D8C1F13832E for ; Thu, 18 Aug 2016 03:01:25 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 119B421C043; Thu, 18 Aug 2016 03:01:16 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 3A05121C043 for ; Thu, 18 Aug 2016 03:01:15 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 37085340836 for ; Thu, 18 Aug 2016 03:01:13 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id CE30F2469 for ; Thu, 18 Aug 2016 03:01:08 +0000 (UTC) From: "Kent Fredric" To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Kent Fredric" Message-ID: <1471489250.921cf27f622f860fb3f96f5232f33607ca703f09.kentnl@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-perl/Cache/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-perl/Cache/Cache-2.40.0-r1.ebuild X-VCS-Directories: dev-perl/Cache/ X-VCS-Committer: kentnl X-VCS-Committer-Name: Kent Fredric X-VCS-Revision: 921cf27f622f860fb3f96f5232f33607ca703f09 X-VCS-Branch: master Date: Thu, 18 Aug 2016 03:01:08 +0000 (UTC) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: 40611edd-811e-4dcf-a709-94f6808163a1 X-Archives-Hash: f76f95e9dcd335317d8889cd603f9737 commit: 921cf27f622f860fb3f96f5232f33607ca703f09 Author: Kent Fredric gentoo org> AuthorDate: Tue Aug 16 10:06:52 2016 +0000 Commit: Kent Fredric gentoo org> CommitDate: Thu Aug 18 03:00:50 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=921cf27f dev-perl/Cache: Normalise variable order This ebuild had a very unusual variable order where KEYWORDS was buried at the bottom. This makes any tooling that relies on determining keyword and dependency matches in a single pass more complicated and harder to be efficient, because it means you have to read the whole file in every case just in case keywords are declared after dependencies. Tooling that makes this mistake is fixable, but a more consistent standard of ebuild also helps a lot. Package-Manager: portage-2.3.0 dev-perl/Cache/Cache-2.40.0-r1.ebuild | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/dev-perl/Cache/Cache-2.40.0-r1.ebuild b/dev-perl/Cache/Cache-2.40.0-r1.ebuild index 5cdca88..bda80d7 100644 --- a/dev-perl/Cache/Cache-2.40.0-r1.ebuild +++ b/dev-perl/Cache/Cache-2.40.0-r1.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2014 Gentoo Foundation +# Copyright 1999-2016 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ @@ -9,6 +9,9 @@ MODULE_VERSION=2.04 inherit perl-module DESCRIPTION="the Cache interface" +SLOT="0" +KEYWORDS="amd64 x86" +IUSE="" RDEPEND=">=virtual/perl-DB_File-1.72 >=virtual/perl-File-Spec-0.8 @@ -20,8 +23,4 @@ RDEPEND=">=virtual/perl-DB_File-1.72 dev-perl/File-NFSLock" DEPEND="${RDEPEND}" -SLOT="0" -KEYWORDS="amd64 x86" -IUSE="" - SRC_TEST="do"