From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-commits+bounces-894784-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id EFBF713832E for <garchives@archives.gentoo.org>; Tue, 2 Aug 2016 22:15:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 90CF7E0ABC; Tue, 2 Aug 2016 22:15:18 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 1A2BEE0ABC for <gentoo-commits@lists.gentoo.org>; Tue, 2 Aug 2016 22:15:17 +0000 (UTC) Received: from oystercatcher.gentoo.org (unknown [IPv6:2a01:4f8:202:4333:225:90ff:fed9:fc84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTPS id 566CC3408CF for <gentoo-commits@lists.gentoo.org>; Tue, 2 Aug 2016 22:15:16 +0000 (UTC) Received: from localhost.localdomain (localhost [127.0.0.1]) by oystercatcher.gentoo.org (Postfix) with ESMTP id A27A97DC for <gentoo-commits@lists.gentoo.org>; Tue, 2 Aug 2016 22:15:13 +0000 (UTC) From: "Kent Fredric" <kentnl@gentoo.org> To: gentoo-commits@lists.gentoo.org Content-Transfer-Encoding: 8bit Content-type: text/plain; charset=UTF-8 Reply-To: gentoo-dev@lists.gentoo.org, "Kent Fredric" <kentnl@gentoo.org> Message-ID: <1470176075.1e16f7f70a224731b1b7bc53bb47b8ab1da211e9.kentnl@gentoo> Subject: [gentoo-commits] repo/gentoo:master commit in: dev-perl/Test-CleanNamespaces/ X-VCS-Repository: repo/gentoo X-VCS-Files: dev-perl/Test-CleanNamespaces/Test-CleanNamespaces-0.180.0.ebuild X-VCS-Directories: dev-perl/Test-CleanNamespaces/ X-VCS-Committer: kentnl X-VCS-Committer-Name: Kent Fredric X-VCS-Revision: 1e16f7f70a224731b1b7bc53bb47b8ab1da211e9 X-VCS-Branch: master Date: Tue, 2 Aug 2016 22:15:13 +0000 (UTC) Precedence: bulk List-Post: <mailto:gentoo-commits@lists.gentoo.org> List-Help: <mailto:gentoo-commits+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-commits+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-commits+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-commits.gentoo.org> X-BeenThere: gentoo-commits@lists.gentoo.org X-Archives-Salt: c0a5cb53-de56-4975-bd36-6f8088a81eca X-Archives-Hash: a5d39bf87f4b19987d9526358ebad37b commit: 1e16f7f70a224731b1b7bc53bb47b8ab1da211e9 Author: Kent Fredric <kentnl <AT> gentoo <DOT> org> AuthorDate: Tue Aug 2 21:51:05 2016 +0000 Commit: Kent Fredric <kentnl <AT> gentoo <DOT> org> CommitDate: Tue Aug 2 22:14:35 2016 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1e16f7f7 dev-perl/Test-CleanNamespaces: Weaken dependency on dev-perl/Test-Tester Without this fix, Test-CleanNamespaces effectively needs perl-5.22 stabilized in order to satisfy Test-Tester from Perl-5.22 However, satisfying Test-Tester from a mechanism other than Perl-5.22 confuses portages dependency resolver, and confuses portage to not be able to upgrade perl, and not being able to upgrade perl means perl can't be stabilized, invoking a stabilization-needs-stabilization bug. Hence, the choice here optimises for assuming stabilization will happen/has happened, and removes any dependency on Test::Tester, assuming portage will eventually provide it for you. And just to be sure, we use perl before the test phase executes to determine if Test::Tester was /actually/ installed and then only run tests if it was. This means before stabilization, some people *might* install this and not have tests run, but everyone *will* get tests working after stabilization, as opposed to the opposite occurring and stabilization being blocked. Bug: https://bugs.gentoo.org/584238 Package-Manager: portage-2.3.0 RepoMan-Options: --include-arches="alpha amd64 amd64-fbsd arm arm64 hppa ia64 m68k mips nios2 ppc ppc64 riscv s390 sh sparc sparc-fbsd x86 x86-fbsd" .../Test-CleanNamespaces-0.180.0.ebuild | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/dev-perl/Test-CleanNamespaces/Test-CleanNamespaces-0.180.0.ebuild b/dev-perl/Test-CleanNamespaces/Test-CleanNamespaces-0.180.0.ebuild index 9341e56..fcb229a 100644 --- a/dev-perl/Test-CleanNamespaces/Test-CleanNamespaces-0.180.0.ebuild +++ b/dev-perl/Test-CleanNamespaces/Test-CleanNamespaces-0.180.0.ebuild @@ -1,4 +1,4 @@ -# Copyright 1999-2015 Gentoo Foundation +# Copyright 1999-2016 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ @@ -43,7 +43,6 @@ DEPEND="${RDEPEND} dev-perl/Test-Deep >=virtual/perl-Test-Simple-0.880.0 dev-perl/Test-Requires - || ( >=virtual/perl-Test-Simple-1.1.14 dev-perl/Test-Tester ) >=dev-perl/Test-Warnings-0.9.0 virtual/perl-if virtual/perl-parent @@ -51,3 +50,14 @@ DEPEND="${RDEPEND} " SRC_TEST="do parallel" + +src_test() { + # Bug 584238 Avoidance + if perl -e 'exit ( eval { require Test::Tester; 1 } ? 0 : 1 )'; then + perl-module_src_test + else + einfo "Test phase skipped: Test::Tester required for tests" + einfo "Please upgrade to >=dev-lang/perl-5.22.0 or >=virtual/perl-Test-Simple-1.1.10" + einfo "if you want this tested" + fi +}